Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2876547rwl; Tue, 27 Dec 2022 00:36:29 -0800 (PST) X-Google-Smtp-Source: AMrXdXvoRYdHjtio1BllYhkdxk1zQ5nneE4JfgdiigjLFy436eHqF5ojT0Lrgvkxe+4hSLVuVs3r X-Received: by 2002:a17:906:8806:b0:829:6036:eaa1 with SMTP id zh6-20020a170906880600b008296036eaa1mr22743935ejb.49.1672130189304; Tue, 27 Dec 2022 00:36:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672130189; cv=none; d=google.com; s=arc-20160816; b=I9/e85tVsV4D1d7yo1rnPnB0w5xRelQrglcywZLBCXWHdJ7YjaEIhPeJpgqsaQs1Fx 9dPyZO/jJ8nGoXRVsYGu4ZDydrhIXf+gJTTBmpS6wiZVtgfcaTZh+/XacwltdSZHqdfd D35YoPI0/oEsXaT3Zd2Pjhx5hJ685Ij58n/7SwP5PrwpRZVwO6dJ5OK/KtQgKv+sG+vJ 2HlIfL09VNlZZSF19ftLSvacwEcU0mqLvWSysDuuaHMK6c6t/RLTMZmr9kV2JvXY1XcJ av7h+Gh2Sn1Iyf5l/Bg1akO6zDxsxJmervsy17Ofi5AvaYnQyO+dkH4BwIFV2fh3Njmd 5q6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=wCYHbxHWnWYY7tZ4H0UhQ5PUVEgDjPe+BXvjxGYqJRE=; b=d/6fS9RQsGusSam3qNEo08C+cJEvp1Qt1Ub7ODHAwv+iMmxViwXLJ7Yqc6TJ0V/cNh CJnis0SrJcNTJXbCtGGkP0mqs32cLP7dGlUWalDMXfddvwXVM2i2Otw1Q9+OWkmX8NwF yaNwHCjOKYL8ksW5YZHI3rHkuI0QpSTT7uz6SNYGaGMeLmXhftBOrshmlHlsvD2cZqbw m85x+BGMJMHhEUx38C/knDdOx4P0J4OStl75pEUn/uMJNV+U4WmeW2XwexARBP3I7KM1 hp01PssX2Rf9BM94Y2cd0UszAI+BIRAh2gNJITKLehtnvcu4zK5JlaBou8NHSddjhlQd Q/JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I2NrB8W1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sh40-20020a1709076ea800b007c122aedb46si11775917ejc.204.2022.12.27.00.36.13; Tue, 27 Dec 2022 00:36:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=I2NrB8W1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230461AbiL0IK2 (ORCPT + 67 others); Tue, 27 Dec 2022 03:10:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbiL0IKV (ORCPT ); Tue, 27 Dec 2022 03:10:21 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B44E965A6 for ; Tue, 27 Dec 2022 00:10:19 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id y25so18650623lfa.9 for ; Tue, 27 Dec 2022 00:10:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wCYHbxHWnWYY7tZ4H0UhQ5PUVEgDjPe+BXvjxGYqJRE=; b=I2NrB8W1olYs8aDi8D6AgwGHmQOx6Q6w80is4wEh108GPccO6rvIdd1cdztaHdw6p9 LICStazFg0X2HEnszNDnv6fDOsoyA/SPj/golzNIyitKASbSi3LNTOvfLA4Xfkuab3bI MFsXCnZVvRUutwum3+gkpyfBoRIuTDKdS84g6XIx5cDtyZ+YF+ruxFTouBJbr9zgPQqe K+CW2OBjjLP+3sqOGbaTqtOxVnZl4z7rNDWxoL1jWJ3MYDyZaUhVj3zDDDa+nNL4rbE6 iHtLGdu8iv0il0VXgPuh+eeYoaOwOFHjh9T9c/mFAzUDRvkFhsZJlgmewXOnV4IRAlVk 6k9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wCYHbxHWnWYY7tZ4H0UhQ5PUVEgDjPe+BXvjxGYqJRE=; b=WBu9n409ppe3EnXkQJPoIjyz8WXdj4cHXk28iMrz6pQxGO5HaG9PIlHHTt0YQ0Sakf LgVfPOvrIr/tg0XMLNChZ2DgRJqG/8vVx55XOwOJDmOV5wd3+lSXHHuk+gWMe8WFd2fy 8CQeD10CVwcMWtOKYU224R3Sr/X/A3qB+5aJHj9sEMPd3GrG2pa07TbtkTlDPNRAr46Z qoVveTOJ1+WAVslmKp2CEVLY1OjFyAxOQ5Aza9M4BRfWM3wj9viqL2+Pskv4j2E+Yr2E uh2KoUASJnsxRKH383n/7bak3MGKgFL0jMnT+mAj83FtNVeKKYog09Nzq7LPNI5yc9p7 AVLQ== X-Gm-Message-State: AFqh2kojHgMBluRCYi2IC3QO1/xfL5X4T5vb0mOSHdS1MjzOjmTXivvG sQGUPHHUgHohw9lZdIxnQaiTww== X-Received: by 2002:a05:6512:1116:b0:4a4:68b7:dee8 with SMTP id l22-20020a056512111600b004a468b7dee8mr8042309lfg.68.1672128618052; Tue, 27 Dec 2022 00:10:18 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m1-20020a197101000000b004b094730074sm2140275lfc.267.2022.12.27.00.10.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Dec 2022 00:10:17 -0800 (PST) Message-ID: <7f6a2072-f26b-e2f0-9c07-d2ea43c8c4bc@linaro.org> Date: Tue, 27 Dec 2022 09:10:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [net PATCH 2/2] dt-bindings: net: marvell,orion-mdio: Fix examples Content-Language: en-US To: =?UTF-8?Q?Micha=c5=82_Grzelak?= , devicetree@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, chris.packham@alliedtelesis.co.nz, netdev@vger.kernel.org, upstream@semihalf.com, linux-kernel@vger.kernel.org References: <20221227010523.59328-1-mig@semihalf.com> <20221227010523.59328-3-mig@semihalf.com> From: Krzysztof Kozlowski In-Reply-To: <20221227010523.59328-3-mig@semihalf.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/12/2022 02:05, Michał Grzelak wrote: > As stated in marvell-orion-mdio.txt deleted in 'commit 0781434af811f > ("dt-bindings: net: orion-mdio: Convert to JSON schema")' if Drop '' quotes. BTW, read the original binding to find the answer for your first patch. > 'interrupts' property is present, width of 'reg' should be 0x84. > Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and extend it > by second example from marvell-orion-mdio.txt. The original binding did not say that, unless you mean giving different examples? Examples are not a binding. > > Signed-off-by: Michał Grzelak > --- > .../devicetree/bindings/net/marvell,orion-mdio.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml > index 2b2b3f8709fc..d260794e92c5 100644 > --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml > +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml > @@ -47,9 +47,10 @@ unevaluatedProperties: false > > examples: > - | > + // MDIO binding with interrupt > mdio@d0072004 { > compatible = "marvell,orion-mdio"; > - reg = <0xd0072004 0x4>; > + reg = <0xd0072004 0x84>; > #address-cells = <1>; > #size-cells = <0>; > interrupts = <30>; > @@ -62,3 +63,12 @@ examples: > reg = <1>; > }; > }; > + > + - | > + // MDIO binding without interrupt > + mdio@d0072004 { > + compatible = "marvell,orion-mdio"; > + reg = <0xd0072004 0x4>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; Why? The same compatible, the same nodes. No differences. Missing pieces is not a big difference justifying new example. Best regards, Krzysztof