Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= <Nancy.Lin@mediatek.com>
To:     "wenst@chromium.org" <wenst@chromium.org>
CC:     "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        =?utf-8?B?WW9uZ3FpYW5nIE5pdSAo54mb5rC45by6KQ==?= 
        <yongqiang.niu@mediatek.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        =?utf-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= 
        <Singo.Chang@mediatek.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "nathan@kernel.org" <nathan@kernel.org>,
        "chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        =?utf-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= 
        <Jason-JH.Lin@mediatek.com>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@mediatek.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "angelogioacchino.delregno@collabora.com" 
        <angelogioacchino.delregno@collabora.com>,
        "nfraprado@collabora.com" <nfraprado@collabora.com>,
        "ndesaulniers@google.com" <ndesaulniers@google.com>
Subject: Re: [PATCH v28 05/11] soc: mediatek: refine code to use
 mtk_mmsys_update_bits API
Thread-Topic: [PATCH v28 05/11] soc: mediatek: refine code to use
 mtk_mmsys_update_bits API
Thread-Index: AQHY8nnThJFnySWTO0qldYSJ6lapG65ZD7WAgCicIoA=
Date:   Tue, 27 Dec 2022 07:54:15 +0000
Message-ID: <2c88e8f6327475539a1c6a8d9d8679c08efc2a85.camel@mediatek.com>
References: <20221107072243.15748-1-nancy.lin@mediatek.com>
         <20221107072243.15748-6-nancy.lin@mediatek.com>
         <CAGXv+5Hj-H6Q3N+j2tEntd9M=9p0o7TxWYn_4aawhqFUbX7+PQ@mail.gmail.com>
In-Reply-To: <CAGXv+5Hj-H6Q3N+j2tEntd9M=9p0o7TxWYn_4aawhqFUbX7+PQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?clUwMGFxUW10SlRNZTdzeXBDNFN0QjNMSWdsdy8vbzM5ekc5UW1vdC9ZaWNa?=
 =?utf-8?B?UjMybldIcEhhYnZMNk5YOUF4cXJiUzdNR2tmeDB2dXcwVmhFSjZYUzZSS0Iz?=
 =?utf-8?B?L0sxMGROdEJrMHIwM0M0aW1TaEttaWk4ZnVIRThBV3p2SUpJOFZZelhJOWx4?=
 =?utf-8?B?N0VTbUFJSGk2QjVEYi9YbC9KZ0RneTZneVRhZ213RGo3Mkw3NStTSU5WbmpY?=
 =?utf-8?B?N2tQY0c0UVphZlpKVTRvbisrSm9Nd2owakI3UDJrVTIzdkJhSFQzYTkwc2Qr?=
 =?utf-8?B?QjEvZWx0U2h5Y0JtSTNIVXF3WDNxOExYaEZ3SlBnTnNVRWxmRmRtOENDSEx1?=
 =?utf-8?B?dW5vYTlZMGJ6aENRSGNwR3RRWmF1bml2cU9rZ1RuL3NEMm9JMjFOeVNub3NQ?=
 =?utf-8?B?QUZ6cTFVRGs0VnY4SUNFQytRWjNFNFhCOGU5eVZFT3BQeUhjUmpjRmNtQnJm?=
 =?utf-8?B?THROdUtMMWd2WG1sOVJpbWVBSnBLMjFrV3dJbGtnNGgrVytFTCtOVGE1Mk04?=
 =?utf-8?B?YmNkZlFjZ3kzZjY3VENUQ2xBMmFGa0JwOWhzSitET3Vsa3ByOXRyZ1BnYlV4?=
 =?utf-8?B?bmhqSEpDZUJhRlVvay9odHNnQkpYTURibnA0OWJUVDFkS3dneXdGN2FFd3lt?=
 =?utf-8?B?OC83LzBaNG1DdzRRS0tTeHoxaFZGaHNTYzAwV3BXa0RPWGR5SGExTHpoc1VG?=
 =?utf-8?B?Yy9SRDd0dTdVWktBdGozU1RPQkdoTHdZVTZBQ0p3QSs1Z1Yva0dIOGl4d3Ri?=
 =?utf-8?B?TFI2VVRtMDBibklBdnJBUkRkT0IxckdTNVVjUmdOMllOMElWbU84U2dEanZI?=
 =?utf-8?B?TFAzWUpqK083NHJiQ1pKdERQdE5oNFlCQ2N1cGVTd2YvR01kRXNwMUN6Vitj?=
 =?utf-8?B?d3FXODMva1NvazJ2NzVXTDhCTTVTZEFGZW9DNFc0TVNkQmI5ZGt3VDM2NWJo?=
 =?utf-8?B?L3U2ODk3UnhrOGhaZ2pFZUlLNFBuMUZmTzNINXJ2TDVWbzZWTEdaQUJtcGFL?=
 =?utf-8?B?Z2FadUZNNUFWSktidmlJamZrekIxUzVVcEtnbmZMUUswRG5LUlZGMGU2cE5t?=
 =?utf-8?B?MlBvdnVIQTg5SW9tekcydnVkSTRvblZ2Mm9DV09YdWFTeEN1UHFHYjVqSnF1?=
 =?utf-8?B?ZWM1alpvQ2h6cldlY3BOWEZRWlkvRkJqMzhJRVA3QkI5VnJUdEoyMDZGMEtu?=
 =?utf-8?B?QXJoRktHRXkxdkkwekNHZURQakRhUm01NGxGQU50L1ZSTVc5T0NzMW1VNzFZ?=
 =?utf-8?B?a1g3ZjlVd3RyU2R5MVY0dUlkK0JvY28wZEtmNGhNWUZmZWM2VHZraWNHTm8w?=
 =?utf-8?B?TURpZDFHdTE3eUE4L0w5S0dUN3dBaVV4cVhuR2xUMGlERS9WSFNUazhucFc2?=
 =?utf-8?B?alg0VEJpL1FJcFZjTUhvSTFiVE1YcWo2UzFiOGJ5RnQzNXpkMlJkcmxUMC85?=
 =?utf-8?B?MVorZzlJUHRKY2ZmSXNNTWlnNGRnSXkyV213YXZVKzNRYXd1UHhiakpuUXkv?=
 =?utf-8?B?Z3VLNmQ2UFhhYk03QXJsbTVOKysxKzdlS2VuZG1POG92d2tJUUQ3cU5NUzlH?=
 =?utf-8?B?eEhwc09XdGZSTFV4WjNSL1UvR3B6RnNDOVdhd1VmMzhKczV5MHJGWXI4dWU1?=
 =?utf-8?B?R1RvRytZTzlqbnVMM0ZaSzdVQitGZUt4ZDdqREdXVVQ4dVVxMW90eGFXemtp?=
 =?utf-8?B?bmkxVmRkT2dWZWlvemYzZWhjVWREc2gwSFJOSkF5OU5QNDhwUzBFKzZzSi9H?=
 =?utf-8?B?NUtjRW1pSGpSRDRaMGpXdnQrREswYXVSVnpueCtQbllhOFJteDBTZmY2MWhT?=
 =?utf-8?B?RnVydWJPN3pBNUEwVTBvWmxsUzdUQTlLV1JmaUFSNjMxNnhsMFV1SzZBNjB3?=
 =?utf-8?B?SWgxNG4xK1NDOVhXNC94bXAvUDZkakt6RUdoYm5GSHVjUEpkclk3aU90bHk0?=
 =?utf-8?B?enBsYkFQMnBPVk5YcUl3MWwzWHp4L2FVRzh2T1pRcGdqUGJsOUtzTEEyMHUx?=
 =?utf-8?B?RHMvcFdscEk3ZEhSc05USFNOdDBLRHM0ajZaY3B6Z0ZMekJzcE5ZNk1JVFho?=
 =?utf-8?B?eHV2cm5rdHBkNmJ3TkJTZi96WDlZZUtMeWVxVHlXclNSd3FjU1U2NFdzZ1Jm?=
 =?utf-8?B?OFBkS1grNHgrSFk2b1lrcFdLQ1lZWHdlYi9RZHB3WXFTRENDZU1qV2V6d2NN?=
 =?utf-8?B?c1E9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <B710263C3169C04580D3F54E460D53CF@apcprd03.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB5175.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08ff4877-1e5a-4fcf-7708-08dae7df8d4f
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2022 07:54:16.0396
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p0WqFq6uEHLYJ4r4637hAnNjpToJmrBlQ+/fMfd6ZA71SBmcLInLMZx7Yz12VgCDRQaBVNzQzyCaW3I9QbiVng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR03MB5510
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

RGVhciBDaGVuLVl1LA0KDQpTb3JyeSBmb3IgbGF0ZSByZXNwb25zZSBhbmQgdGhhbmtzIGZvciB0
aGUgcmV2aWV3Lg0KDQpPbiBUaHUsIDIwMjItMTItMDEgYXQgMTk6NDQgKzA4MDAsIENoZW4tWXUg
VHNhaSB3cm90ZToNCj4gT24gTW9uLCBOb3YgNywgMjAyMiBhdCAzOjIzIFBNIE5hbmN5LkxpbiA8
bmFuY3kubGluQG1lZGlhdGVrLmNvbT4NCj4gd3JvdGU6DQo+ID4gDQo+ID4gU2ltcGxpZnkgY29k
ZSBmb3IgdXBkYXRlICBtbXN5cyByZWcuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogTmFuY3ku
TGluIDxuYW5jeS5saW5AbWVkaWF0ZWsuY29tPg0KPiA+IFJldmlld2VkLWJ5OiBBbmdlbG9HaW9h
Y2NoaW5vIERlbCBSZWdubyA8DQo+ID4gYW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xsYWJv
cmEuY29tPg0KPiA+IFJldmlld2VkLWJ5OiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29tPg0KPiA+
IFRlc3RlZC1ieTogQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gPA0KPiA+IGFuZ2Vsb2dpb2Fj
Y2hpbm8uZGVscmVnbm9AY29sbGFib3JhLmNvbT4NCj4gPiBUZXN0ZWQtYnk6IEJvLUNoZW4gQ2hl
biA8cmV4LWJjLmNoZW5AbWVkaWF0ZWsuY29tPg0KPiA+IFJldmlld2VkLWJ5OiBOw61jb2xhcyBG
LiBSLiBBLiBQcmFkbyA8bmZyYXByYWRvQGNvbGxhYm9yYS5jb20+DQo+ID4gLS0tDQo+ID4gIGRy
aXZlcnMvc29jL21lZGlhdGVrL210ay1tbXN5cy5jIHwgNDUgKysrKysrKysrKysrLS0tLS0tLS0t
LS0tLS0NCj4gPiAtLS0tLS0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyks
IDI5IGRlbGV0aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRp
YXRlay9tdGstbW1zeXMuYw0KPiA+IGIvZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLW1tc3lzLmMN
Cj4gPiBpbmRleCA5YTMyN2ViNWQ5ZDcuLjczYzhiZDI3ZTZhZSAxMDA2NDQNCj4gPiAtLS0gYS9k
cml2ZXJzL3NvYy9tZWRpYXRlay9tdGstbW1zeXMuYw0KPiA+ICsrKyBiL2RyaXZlcnMvc29jL21l
ZGlhdGVrL210ay1tbXN5cy5jDQo+IA0KPiBbLi4uXQ0KPiANCj4gPiBAQCAtMTI0LDI3ICsxMjks
MTQgQEAgdm9pZCBtdGtfbW1zeXNfZGRwX2Rpc2Nvbm5lY3Qoc3RydWN0IGRldmljZQ0KPiA+ICpk
ZXYsDQo+ID4gIHsNCj4gPiAgICAgICAgIHN0cnVjdCBtdGtfbW1zeXMgKm1tc3lzID0gZGV2X2dl
dF9kcnZkYXRhKGRldik7DQo+ID4gICAgICAgICBjb25zdCBzdHJ1Y3QgbXRrX21tc3lzX3JvdXRl
cyAqcm91dGVzID0gbW1zeXMtPmRhdGEtDQo+ID4gPnJvdXRlczsNCj4gPiAtICAgICAgIHUzMiBy
ZWc7DQo+ID4gICAgICAgICBpbnQgaTsNCj4gPiANCj4gPiAgICAgICAgIGZvciAoaSA9IDA7IGkg
PCBtbXN5cy0+ZGF0YS0+bnVtX3JvdXRlczsgaSsrKQ0KPiA+IC0gICAgICAgICAgICAgICBpZiAo
Y3VyID09IHJvdXRlc1tpXS5mcm9tX2NvbXAgJiYgbmV4dCA9PQ0KPiA+IHJvdXRlc1tpXS50b19j
b21wKSB7DQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgcmVnID0gcmVhZGxfcmVsYXhlZCht
bXN5cy0+cmVncyArDQo+ID4gcm91dGVzW2ldLmFkZHIpOw0KPiA+IC0gICAgICAgICAgICAgICAg
ICAgICAgIHJlZyAmPSB+cm91dGVzW2ldLm1hc2s7DQo+ID4gLSAgICAgICAgICAgICAgICAgICAg
ICAgd3JpdGVsX3JlbGF4ZWQocmVnLCBtbXN5cy0+cmVncyArDQo+ID4gcm91dGVzW2ldLmFkZHIp
Ow0KPiA+IC0gICAgICAgICAgICAgICB9DQo+ID4gKyAgICAgICAgICAgICAgIGlmIChjdXIgPT0g
cm91dGVzW2ldLmZyb21fY29tcCAmJiBuZXh0ID09DQo+ID4gcm91dGVzW2ldLnRvX2NvbXApDQo+
ID4gKyAgICAgICAgICAgICAgICAgICAgICAgbXRrX21tc3lzX3VwZGF0ZV9iaXRzKG1tc3lzLA0K
PiA+IHJvdXRlc1tpXS5hZGRyLCByb3V0ZXNbaV0ubWFzaywgMCk7DQo+ID4gIH0NCj4gPiAgRVhQ
T1JUX1NZTUJPTF9HUEwobXRrX21tc3lzX2RkcF9kaXNjb25uZWN0KTsNCj4gPiANCj4gPiAtc3Rh
dGljIHZvaWQgbXRrX21tc3lzX3VwZGF0ZV9iaXRzKHN0cnVjdCBtdGtfbW1zeXMgKm1tc3lzLCB1
MzINCj4gPiBvZmZzZXQsIHUzMiBtYXNrLCB1MzIgdmFsKQ0KPiA+IC17DQo+ID4gLSAgICAgICB1
MzIgdG1wOw0KPiA+IC0NCj4gPiAtICAgICAgIHRtcCA9IHJlYWRsX3JlbGF4ZWQobW1zeXMtPnJl
Z3MgKyBvZmZzZXQpOw0KPiA+IC0gICAgICAgdG1wID0gKHRtcCAmIH5tYXNrKSB8IHZhbDsNCj4g
PiAtICAgICAgIHdyaXRlbF9yZWxheGVkKHRtcCwgbW1zeXMtPnJlZ3MgKyBvZmZzZXQpOw0KPiA+
IC19DQo+ID4gLQ0KPiA+ICB2b2lkIG10a19tbXN5c19kZHBfZHBpX2ZtdF9jb25maWcoc3RydWN0
IGRldmljZSAqZGV2LCB1MzIgdmFsKQ0KPiA+ICB7DQo+ID4gICAgICAgICBpZiAodmFsKQ0KPiAN
Cj4gVGhpcyBodW5rIG5vdyBkb2Vzbid0IGFwcGx5IGR1ZSB0bw0KPiANCj4gICAgIHNvYzogbWVk
aWF0ZWs6IEFkZCBhbGwgc2V0dGluZ3MgdG8gbXRrX21tc3lzX2RkcF9kcGlfZm10X2NvbmZpZw0K
PiBmdW5jDQo+IA0KPiB0b3VjaGluZyBtdGtfbW1zeXNfZGRwX2RwaV9mbXRfY29uZmlnKCkgYXMg
d2VsbC4gSXQncyB0cml2aWFsIHRvDQo+IHJlc29sdmUNCj4gdGhvdWdoLg0KPiANCj4gQ2hlbll1
DQoNCkkgd2lsbCB1cGRhdGUgbmV4dCByZXZpc2lvbiBiYXNlIG9uIG5leHQtMjAyMjEyMjYgd2hp
Y2ggaW5jbHVkZSB0aGUNCnBhdGNoIHlvdSBtZW50aW9uZWQuDQoNClJlZ2FyZHMsDQpOYW5jeQ0K