Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2903016rwl; Tue, 27 Dec 2022 01:07:18 -0800 (PST) X-Google-Smtp-Source: AMrXdXvreSdkyxL8LPBLazt6ln/QJgXTIXoUQWGJdOvLYpYgETLAisyMGAHCPyeOMktJFDmLXvfe X-Received: by 2002:a05:6a20:8f0c:b0:af:cc4e:f2f with SMTP id b12-20020a056a208f0c00b000afcc4e0f2fmr33842441pzk.34.1672132038461; Tue, 27 Dec 2022 01:07:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672132038; cv=none; d=google.com; s=arc-20160816; b=HuoU5tIt2P5hknkoqzol0Y14wGadSN56cIl/qpm8SqQuYhOccV8Bq47E8j2LhXuJ5w umiLBV9Qb5Nlv1rwCH21GnqJ8nkGqstwlXJrpXLdfPADQvSQArjDj7T5yLjCZSky6P6n ZPfAXsr7h1SRZ2rjpV+4l9gcjCs0t68dpSzzXs7kceqjODdOIdV46U791z8/WWQCi64V 7cH4RfenZkwwRkgZjSou69pR0ZVYdMArv6GTwpbVgUHP+TRZMnYvT0qTbTwipuIiYoYC s8v/ka67Hjvy74FbjwC0DIltAgy1SVuFH+Qf7j/tgqX7iVuBmFvJKOGFc2LqKxRVXORe V98Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WbR8qz6wS5XA+MVJzbHXZiK+aUgwbKxaugtwRJh61nQ=; b=eOlYk/SLNX/1v6WB+dPDthxO2TTbPl/PjSCxdkqbBDaWF6Jc+flSNG2NUQkbZZ1e66 ZHlbjRQ5tsGJlmE9gIXmsgJaXxzQBrqR1P0fq9GA2uyuP+nkVqiZeYSGjFWOMRGQLZnU jXBHe3ztoRW7wzHyRX7vsRnf+R/WXDRVUfXAvqYh5LojBv7s4PlYzfTPkUNli+cMEWFk B94xi5v/6b2UAiGotrAl0nVH/Ng6YfKvW+vRtbWPaMtgP6MYVz3g0nj/EjZKFyCiLpVS uJr+8Je2qg3U7n6Uuf4WT8wMrV4keH1EICsxPEDaqyAk84EI0i3z+jU5APMVM7B0tA9i 72bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o52vghbu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a63d30c000000b004790f4d8a1bsi14046656pgg.227.2022.12.27.01.07.09; Tue, 27 Dec 2022 01:07:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o52vghbu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbiL0I7y (ORCPT + 67 others); Tue, 27 Dec 2022 03:59:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbiL0I7v (ORCPT ); Tue, 27 Dec 2022 03:59:51 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EEF064EF for ; Tue, 27 Dec 2022 00:59:50 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id g13so18771357lfv.7 for ; Tue, 27 Dec 2022 00:59:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WbR8qz6wS5XA+MVJzbHXZiK+aUgwbKxaugtwRJh61nQ=; b=o52vghbuY6ZVpBuLjQdn6P4QMVd7TA4V1br63TkBl8psvVrOeaDF0pdkAwZyIXgUld AV+JoYEITtQ28ZArVk1Nq6yIOy2xU36pbynODzYSoHH/GQEZUsQDV0CNbLG++M04fCRt kpnNET5MN8/gcKnqqdeHjApZ2HrWkCqBK4eq5klnYYMEP5zOoOIG9kC76W0s/Jt9D2rx AIV47YM/XqFyQtlzxiWECRUBtdjvnAvSv2JNCLH39XksPBhnnOlItssNBEUSLShC/rRc lpE1LXtWTyxUhlXSFrFoBbKY6vz/kLbCoUB6dliOdQBxfcIEu1niffKOuZjlc0/7Xrcb BirQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WbR8qz6wS5XA+MVJzbHXZiK+aUgwbKxaugtwRJh61nQ=; b=G9xpYS4WH/tliGogdrx4KohBgg1TA+TMWNivDnCJEBBP6HtxQXKSAFLg3tIlbrItCi 94gHoFRgys2UtORMsjF0yw2ni026JBJ+4TMF9HyWjZQV3Y9DVz7I1bTMY6B5smy32bAX 2iGYD4lEOxG4x8094zVeB9XO/1oFLpbOjxSHHqXFXiDMEL13p2/Rm5maqSIKY6CQ1u/6 vYWnVPMnuhor+w2lNv8NgamVojgWzov1Osl3ZjX0kDngcS+jGlZdYlWK/yATGj+9S5cw c1pFYhK9Zo7dUKxVv0XWHKIxSJTYvCQmcaTUanQBhU9vQpt4pT4M+i/qLig1kMRXHsjd BnUw== X-Gm-Message-State: AFqh2krT3vbUGIqFpsrw8QTzaxweUR8TdijG+e/aoW4og6+rhbnUBgZ3 zyolYv567bbItWwE+rmfcWIUTw== X-Received: by 2002:ac2:598f:0:b0:4cb:df5:92a6 with SMTP id w15-20020ac2598f000000b004cb0df592a6mr779565lfn.30.1672131588704; Tue, 27 Dec 2022 00:59:48 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a18-20020a05651c031200b0026bf0d71b1esm1534837ljp.93.2022.12.27.00.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 00:59:48 -0800 (PST) From: Krzysztof Kozlowski To: dmitry.osipenko@collabora.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, jonathanh@nvidia.com, Ashish Mhetre , thierry.reding@gmail.com Cc: Krzysztof Kozlowski Subject: Re: [Patch V3] memory: tegra: Remove clients SID override programming Date: Tue, 27 Dec 2022 09:59:40 +0100 Message-Id: <167213158105.15520.15913236649862406836.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221125040752.12627-1-amhetre@nvidia.com> References: <20221125040752.12627-1-amhetre@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Nov 2022 09:37:52 +0530, Ashish Mhetre wrote: > On newer Tegra releases, early boot SID override programming and SID > override programming during resume is handled by bootloader. > In the function tegra186_mc_program_sid() which is getting removed, SID > override register of all clients is written without checking if secure > firmware has allowed write on it or not. If write is disabled by secure > firmware then it can lead to errors coming from secure firmware and hang > in kernel boot. > Also, SID override is programmed on-demand during probe_finalize() call > of IOMMU which is done in tegra186_mc_client_sid_override() in this same > file. This function does it correctly by checking if write is permitted > on SID override register. It also checks if SID override register is > already written with correct value and skips re-writing it in that case. > > [...] Applied, thanks! [1/1] memory: tegra: Remove clients SID override programming https://git.kernel.org/krzk/linux-mem-ctrl/c/ef86b2c2807f41c045e5534d8513a8b83f63bc39 Best regards, -- Krzysztof Kozlowski