Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp2909336rwl; Tue, 27 Dec 2022 01:14:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXtlGDlDFG7vkThlgef02jQDVu+pzpthU4SDY7byLpOl2T4Yx2XqiQsiuT47mo5QZ1Vjwimr X-Received: by 2002:a62:168e:0:b0:56c:a75d:43e6 with SMTP id 136-20020a62168e000000b0056ca75d43e6mr23874902pfw.1.1672132447746; Tue, 27 Dec 2022 01:14:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672132447; cv=none; d=google.com; s=arc-20160816; b=VQrhBTDu9Scg8nCfVM/NB81ThyT8NVOtGo/uBaDHFt4+GRh5x1VP0U61ozAHRUzhjh HlZWK9UU6/uBe3oS9z4LLhBKj/POVelGbVhrHkcG/ttf6gTEWCyOzYyv1Qc/E1SgSu4l P6Um/lGLzn9I/C2YcLi2m1/RUQpBAXkCRJQQlVFYJ/H47RGfvTVPmHW+X7cG3r/SzpdI gmx+Bm680QPGYviESnQNRDoywQjtjCFuVtRmvpTZRWyU9ZFc8dyZr7q4W29vrcgLQxPm vzQQg+QnklO9LI2GxvnJ9HFLiEqTYfa3iullLitkUmMVSHNaAVSMYPgcT+TTvsar/gim hz9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YMN5DjdXVGY4mvOE68Hle4bCHMTIkVTbibmpiWxbBPQ=; b=PO3U2+I3BObNvxy8IJStSQt3FNCdcn1Dd/W0958+09w2rh0TIIo5IANiO+35nkW2RW 53dXNWo/5Xl6/j4r+jEQibZTMmd7YyNpzPzM7zg8h5th2aDfMbvh6zN8AhEAnzzMFYky zMhSuytPZbgdTa3meuI9OtRz/zqyEatEeQFuoBTxlP/BphmTMITcWY6jL/G10Xmq5Z7D to9z/fyruD7OdsPOmn9j+gjYvtljZ2jBiMgSHxCGHHHjiQQlsauEvdsWIIpSyNJiDiCu Mu8ANVRmkpfvZGTd7xYB92D0Inz8/amdz5ITIdzIsGGRiS+qiHGcEGCWu3eZHr6tzvgc ViBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ggD/er6M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u124-20020a627982000000b00580ccf54452si10340535pfc.295.2022.12.27.01.13.58; Tue, 27 Dec 2022 01:14:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="ggD/er6M"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230375AbiL0I74 (ORCPT + 66 others); Tue, 27 Dec 2022 03:59:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbiL0I7y (ORCPT ); Tue, 27 Dec 2022 03:59:54 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 600D964EF for ; Tue, 27 Dec 2022 00:59:53 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id e13so10591499ljn.0 for ; Tue, 27 Dec 2022 00:59:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YMN5DjdXVGY4mvOE68Hle4bCHMTIkVTbibmpiWxbBPQ=; b=ggD/er6MwaOH37j0DKAjeXxjLtZEC2uHDCbUkkP6kVfzsvdd6YRr0q7qvFmpPBwbpd qY0s3Kww4Lc9H0uuXLmrNKxqu3R6V7t9OAUU16hoUTNaC2aRIEB1l608WcEiGMkmz6ZU 2KNymXkyWVwamocPfDp4nfsR5/6sMl9rADzuHGhoBLsN6b2qOBvN/XIhp9n/nLiXFWmd JSxSqYf/cB8aJ9OdbECg2OhBDmyTmCIfP+uDsHCrCSPG6jNjUVMgPs9iyXAJY++EIXzm 5bF8UJOmllK+Vduvl8hffWGnlHrnxJvaOV9IVS6MM54bH93ZOIhOme/O956KY3bF/t8z Zzmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YMN5DjdXVGY4mvOE68Hle4bCHMTIkVTbibmpiWxbBPQ=; b=mcZqTaxVJDgaUpUb3Xf1ECNHfqTgOVLF4fh64mxc7gqMuh1Wp5eTritMAjk69h2O5H CUqUC40tomebXihoXpdQ+zIbMbyPKhgr7kfXqYPl/Dzovkp6fWMs7GPMzSbVWL0XHu4N dGGo+TcANhsXaPpTG6rdvcge+pmy2v2yszqrByy8qzNKvF4PP2PJhNkNlqRSQeE4sG6f 69kSkzsPUY4XN6gULv0iftK1ABGOgpRwMqCeT0ScUYuwYPw4C8ncNEp+sJe4hZDD8hPu ctO8nJRKVc4HK4Gp5iWeQp4SULacZm3LjmNROliRodnpo/R47Erq7NOiDFE7nnwWKqsO 5L3w== X-Gm-Message-State: AFqh2kruIX1EXFyivmao+cXmWsEu2EMzAJYLImHUj4e0NLUI0wAXQnPp +eSefqQrtT4r+lobj6v2UE6QrQ== X-Received: by 2002:a2e:934c:0:b0:27f:b489:d8d4 with SMTP id m12-20020a2e934c000000b0027fb489d8d4mr3729494ljh.47.1672131591753; Tue, 27 Dec 2022 00:59:51 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a18-20020a05651c031200b0026bf0d71b1esm1534837ljp.93.2022.12.27.00.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Dec 2022 00:59:51 -0800 (PST) From: Krzysztof Kozlowski To: Gaosheng Cui , nicolas.ferre@microchip.com, mripard@kernel.org, alexandre.belloni@bootlin.com Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe() Date: Tue, 27 Dec 2022 09:59:43 +0100 Message-Id: <167213158106.15520.1724500353419940365.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221126044911.7226-1-cuigaosheng1@huawei.com> References: <20221126044911.7226-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Nov 2022 12:49:11 +0800, Gaosheng Cui wrote: > The clk_disable_unprepare() should be called in the error handling > of devbus_get_timing_params() and of_platform_populate(), fix it by > replacing devm_clk_get and clk_prepare_enable by devm_clk_get_enabled. > > Applied, thanks! [1/1] memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe() https://git.kernel.org/krzk/linux-mem-ctrl/c/cb8fd6f75775165390ededea8799b60d93d9fe3e Best regards, -- Krzysztof Kozlowski