Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Dec 2022 15:45:09 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Paul Gazzillo <paul@pgazz.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Zheng Bin <zhengbin13@huawei.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Suman Ghosh <sumang@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        Sunil Goutham <sgoutham@marvell.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] octeontx2_pf: Select NET_DEVLINK when enabling
 OCTEONTX2_PF
Message-ID: <Y6r25RChRDBmk8YX@unreal>
References: <20221219171149.833822-1-paul@pgazz.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221219171149.833822-1-paul@pgazz.com>
Precedence: bulk

On Mon, Dec 19, 2022 at 12:11:28PM -0500, Paul Gazzillo wrote:
> When using COMPILE_TEST, the driver controlled by OCTEONTX2_PF does
> not select NET_DEVLINK while the related OCTEONTX2_AF driver does.
> This means that when OCTEONTX2_PF is enabled from a default
> configuration, linker errors will occur due to undefined references to
> code controlled by NET_DEVLINK.
> 
> 1. make.cross ARCH=x86_64 defconfig
> 2. make.cross ARCH=x86_64 menuconfig
> 3. Enable COMPILE_TEST
>    General setup  --->
>      Compile also drivers which will not load
> 4. Enable OCTEONTX2_PF
>    Device Drivers  --->
>      Network device support  --->
>        Ethernet driver support  --->
>          Marvell OcteonTX2 NIC Physical Function driver
> 5. Exit and save configuration.  NET_DEVLINK will still be disabled.
> 6. make.cross ARCH=x86_64 several linker errors, for example,
>    ld: drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.o:
>      in function `otx2_register_dl':
>    otx2_devlink.c:(.text+0x142): undefined reference to `devlink_alloc_ns'
> 
> This fix adds "select NET_DEVLINK" link to OCTEONTX2_PF's Kconfig
> specification to match OCTEONTX2_AF.
> 
> Fixes: 2da489432747 ("octeontx2-pf: devlink params support to set mcam entry count")
> Signed-off-by: Paul Gazzillo <paul@pgazz.com>
> ---
> v1 -> v2: Added the fixes tag
> 
>  drivers/net/ethernet/marvell/octeontx2/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>