Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221112203300.536010-1-dsankouski@gmail.com> <20221112203300.536010-3-dsankouski@gmail.com>
 <20221222115922.jlachctn4lxopp7a@SoMainline.org>
In-Reply-To: <20221222115922.jlachctn4lxopp7a@SoMainline.org>
From:   Dzmitry Sankouski <dsankouski@gmail.com>
Date:   Tue, 27 Dec 2022 18:09:13 +0300
Message-ID: <CABTCjFBrGPW07AOnGgL0FD9KhHZAhRoj=n6QmttfDEobisgCqA@mail.gmail.com>
Subject: Re: [PATCH v12 2/2] arm64: dts: qcom: sagit: add initial device tree
 for sagit
To:     Marijn Suijten <marijn.suijten@somainline.org>
Cc:     linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        "open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks for the note, I'll send the fix.

=D1=87=D1=82, 22 =D0=B4=D0=B5=D0=BA. 2022 =D0=B3. =D0=B2 14:59, Marijn Suij=
ten <marijn.suijten@somainline.org>:
>
> On 2022-11-12 23:33:00, Dzmitry Sankouski wrote:
> > New device support - Xiaomi Mi6 phone
>
> <snip>
>
> > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts=
/qcom/pm8998.dtsi
> > index 6a0e14382be8..6a5854333b2b 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> > @@ -52,6 +52,14 @@ pm8998_pwrkey: pwrkey {
> >                               bias-pull-up;
> >                               linux,code =3D <KEY_POWER>;
> >                       };
> > +
> > +                     pm8998_resin: resin {
> > +                             compatible =3D "qcom,pm8941-resin";
> > +                             interrupts =3D <GIC_SPI 0x8 1 IRQ_TYPE_ED=
GE_BOTH>;
> > +                             debounce =3D <15625>;
> > +                             bias-pull-up;
> > +                             status =3D "disabled";
> > +                     };
>
> This should have been a separate patch, one that deduplicated
> overlapping nodes with existing msm8998 / sdm845 boards which all add
> this node individually to &pm8998_pon.
>
> What's more, their override has the same node name and will be merged
> with this one without setting status =3D "okay", leading to all those
> boards suddenly having a broken resin key because they inherit your
> status=3D"disabled".
>
> Can you send a fix to address that, with proper Fixes: tag?
>
> - Marijn
>
> >               };
> >
> >               pm8998_temp: temp-alarm@2400 {
> > --
> > 2.30.2
> >