Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b202aa79-d0ea-50c4-ea49-4b65a4244cb1@linaro.org>
Date:   Tue, 27 Dec 2022 17:36:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180-trogdor: align DAI children
 names with DT schema
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221227163158.102737-1-krzysztof.kozlowski@linaro.org>
 <20221227163158.102737-2-krzysztof.kozlowski@linaro.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20221227163158.102737-2-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 27.12.2022 17:31, Krzysztof Kozlowski wrote:
> Bindings expect DAI children to be named "dai-link":
> 
>   sc7180-trogdor-coachz-r1.dtb: lpass@62d87000: Unevaluated properties are not allowed ('hdmi@5', 'mi2s@0', 'mi2s@1' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index d134d172a3c5..64e85cfb36d3 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -788,18 +788,18 @@ &lpass_cpu {
>  	#address-cells = <1>;
>  	#size-cells = <0>;
>  
> -	mi2s@0 {
> +	dai-link@0 {
>  		reg = <MI2S_PRIMARY>;
>  		qcom,playback-sd-lines = <1>;
>  		qcom,capture-sd-lines = <0>;
>  	};
>  
> -	secondary_mi2s: mi2s@1 {
> +	secondary_mi2s: dai-link@1 {
>  		reg = <MI2S_SECONDARY>;
>  		qcom,playback-sd-lines = <0>;
>  	};
>  
> -	hdmi@5 {
> +	dai-link@5 {
>  		reg = <LPASS_DP_RX>;
>  	};
>  };