Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Dec 2022 09:09:42 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Mike Leach <mike.leach@linaro.org>
Cc:     linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
        linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org,
        suzuki.poulose@arm.com, acme@kernel.org, james.clark@arm.com
Subject: Re: [PATCH v5 3/6] coresight: configfs: Add in binary attributes to
 load files
Message-ID: <Y6sm1gXTER/XaggE@infradead.org>
References: <20221219234638.3661-1-mike.leach@linaro.org>
 <20221219234638.3661-4-mike.leach@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221219234638.3661-4-mike.leach@linaro.org>
Precedence: bulk

On Mon, Dec 19, 2022 at 11:46:35PM +0000, Mike Leach wrote:
> Add in functionality and binary attribute to load and unload
> configurations as binary data.
> 
> Files are loaded via the 'load' binary attribute. System reads the incoming
> file, which must be formatted correctly as defined in the file reader code.
> This will create configuration(s) and/or feature(s) and load them
> into the system.

Binary attributes are intended to pass things such as firmware
through.  Defining your own structured file format seems like a
major abuse of the configfs design.  What's the advantage of this
over simply using an ioctl?