Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Dec 2022 11:59:28 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
        "LKML Mailing List" <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v2 1/6] x86/microcode/core: Move microcode_check() to
 cpu/microcode/core.c
Message-ID: <Y6tOoF8HBOkFR97C@a4bf019067fa.jf.intel.com>
References: <20221227192340.8358-1-ashok.raj@intel.com>
 <20221227192340.8358-2-ashok.raj@intel.com>
 <Y6tMgcU2aGbx/6yt@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y6tMgcU2aGbx/6yt@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d5xC1LIVa3AC4xvMf9/HCUCYk1g3883mJ0PqkGzlGiWGJvFCQD1saF/nqTyk?=
 =?us-ascii?Q?7FDYRO60johfwNtfL9SZeaiWEc6w1q52IgcbRjDw9wT5u0A2uycaPHZ/SHrs?=
 =?us-ascii?Q?kPezWW3s/azVTCsa5wWnoZVMG1v2EY8cBijdF5FMrnYlbBAi5qVCpwVFTSut?=
 =?us-ascii?Q?7fsB4/8ce36/9FKEn+u1NmYLBHphOQkblBsoJHfS6AL6pCBjnfh+UMCP8Nda?=
 =?us-ascii?Q?RRErrszEwd0xwJLK8gi88jT3YaYJ/rG0XKTuwy7h7vFnpO8Lrpzae2VUP/wq?=
 =?us-ascii?Q?zj7y4qUzI56fCMXbocLfR4A0Z1C7oFfFYkzHUR/wBkGyVnP0YDA1iiPJ3tuY?=
 =?us-ascii?Q?IXyUb947PlI4tEE1PVBYBVEAvj04iKU1/etF3d/Uu5naXhZKkhN9eGE3hRx7?=
 =?us-ascii?Q?7J80yizAXon7bAyXhs8b/jGMHVqux1RejToC4Lyx5PwhvDGrVLwUF7uNUSeS?=
 =?us-ascii?Q?Ry96f0vWg46mBU+968x+sJobs90lMts76yhexDjtaeh6vtq5Qj74hD8zvKY/?=
 =?us-ascii?Q?xy5UOdY/wZonH0oib2X+tzaPX/tqx3YxKtAhcJq4dBqYmFVDWHwCRoa40yCj?=
 =?us-ascii?Q?8FRyAf4aUIKDssLektjMW+GqO4Ig2MWX7SKoG3ySNlpGztu4MxwHupH2CPzh?=
 =?us-ascii?Q?8axMIQDlb2AkXfXA15vKau+mbncrXbouRRzFUuwfKgXWDM1quv14MAOfKXRT?=
 =?us-ascii?Q?mDaVNDAvbmFfXwTFXnDtgeJaL9AB6m44lcxZKuEaF6aPLs9HwZc1LgvlCRtb?=
 =?us-ascii?Q?m0H942ETFSjbhDEsyNFknqT5nS2xANKrhMvh3oVcbjwsbM1kLC1AFV6ahHDo?=
 =?us-ascii?Q?QD8UryKW/jXONgMIxb/rhdyqeBx8Dry+l80htprnBXp1xSz697R2X9J2FFVw?=
 =?us-ascii?Q?0V8KB4ROTNdIghoGoADF8HH/fX5YHOtCK6qhpRBwyiAhHVHKYtd5NOp1iAIW?=
 =?us-ascii?Q?34mTnpv5D9MebixQz5ADE0g+Kpc5t0w9tpSmvAxm6QF6TcABX4d+Cg52/LV3?=
 =?us-ascii?Q?97uA20Abhq0dqm5b4RVUQ6qvSnrkionPyUpcGZumjX8xSIzZIAoFO3P7CMbx?=
 =?us-ascii?Q?tDyq9GZl/jmu59+6cAm+L3w9zxQJqMOubxRC9ggjd7yb4gY0/GtE/jAQUEH8?=
 =?us-ascii?Q?v7o8jnzfCUlgxgxOe/LvJtuzh3x0Hj8xDPjeJA9SawUZWr63yyzwXQjMbsLf?=
 =?us-ascii?Q?wHxL8VdsRbjqEOrQytxOFppVOfrjIp4PYokeyuYeETv8RNhYvC17axgssirQ?=
 =?us-ascii?Q?3LExNH9FTY+gItdFk5XpArcM4n+3tZz+OpwUn5G/BylBXAa7gAZLm6zZiX6Y?=
 =?us-ascii?Q?1PutP+Q8Ns3nsvTgQywnQ5c3tCTUES0V7VscY9APSi9HcizlrDwcggncdaD/?=
 =?us-ascii?Q?c3P5KN6O3s5RLMb80fbttkBIAKKXb74+UzMeT5RrenbgIhz9rBUEV2d+3tDr?=
 =?us-ascii?Q?cgXTXdQqd3t+NCo6WV2wgmutcNnBG4fhgdcEFoXOehix9dkKUMUdaqVjToCf?=
 =?us-ascii?Q?aJ5OrDp/NN/i6w5D1hfdEID0xYOm+dyhETN4pBhGc6LuuEQM0UpSNdB6OMM9?=
 =?us-ascii?Q?SkxmlTbO/LbRfHrWdbrcx6ZxJBefLIAwlbgL5QaBlpBYDiQn0AUnMIHoY/p2?=
 =?us-ascii?Q?Fg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 353e3c73-319b-45b3-901a-08dae844de26
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2022 19:59:31.0085
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f5A5/tRDP1WXxb9Xu8cw3cUOnqsiVhANfryt4vsc4tI752zzDMyLSpL1ohz+4QsGv4GdVfV03r3ESeSnhSLSsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5536
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 27, 2022 at 08:50:25PM +0100, Borislav Petkov wrote:
> On Tue, Dec 27, 2022 at 11:23:35AM -0800, Ashok Raj wrote:
> > microcode_check() is only called from microcode/core.c. Move it and make
> > it static to prepare for upcoming fix for false negative when checking CPU
> > features after a microcode update. Also move get_cpu_cap() to processor.h
> > for general use outside of arch/x86/kernel/cpu/cpu.h
> 
> I thought we agreed not to do this:
> 
> https://lore.kernel.org/r/Y44bbZMMf8I6Lzl/@zn.tnic
> 
> Or was this a misunderstanding?

Bah... you are correct, I should drop this one.

I'll fix it up

Cheers,
Ashok