Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762824AbXHQUnb (ORCPT ); Fri, 17 Aug 2007 16:43:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754703AbXHQUnW (ORCPT ); Fri, 17 Aug 2007 16:43:22 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:46596 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754544AbXHQUnW (ORCPT ); Fri, 17 Aug 2007 16:43:22 -0400 Date: Fri, 17 Aug 2007 13:43:20 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Andrew Morton cc: Satyam Sharma , Arjan van de Ven , Tim Bird , linux kernel Subject: Re: kfree(0) - ok? In-Reply-To: <20070817112253.e6a7cb33.akpm@linux-foundation.org> Message-ID: References: <46C233CB.9000602@am.sony.com> <1187132149.2618.2.camel@laptopd505.fenrus.org> <20070817112253.e6a7cb33.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 15 On Fri, 17 Aug 2007, Andrew Morton wrote: > are we seeing a pattern here? We could stick the unlikely inside > ZERO_OR_NULL_PTR() itself. That's a little bit sleazy though - there might > be future callsites at which it is likely, who knows? Thought about that myself but then there would be a weird side effect to ZERO_OR_NULL_PTR(). But since your thinking along the same lines: Lets do it. I will fix up the patch to do just that. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/