Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1d0def42-11b7-0039-368d-d355f348767c@gmx.de>
Date:   Tue, 27 Dec 2022 22:30:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH linux-next v2] parisc: use strscpy() to instead of
 strncpy()
Content-Language: en-US
To:     Rolf Eike Beer <eike-kernel@sf-tec.de>,
        james.bottomley@hansenpartnership.com, yang.yang29@zte.com.cn
Cc:     linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org,
        xu.panda@zte.com.cn
References: <202212261840048448622@zte.com.cn>
 <2298026.kkTNVCUfUN@daneel.sf-tec.de>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <2298026.kkTNVCUfUN@daneel.sf-tec.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Yrmu8I+tIOQ=;pKAqIZhx4/65Yn3POPk/3XM0NrY
 XwFYnErerMkCScZNllGiVmYIQcT1f+u8bNZtWDFtnyi9Eel7lVKZL4PWmEEhEYe91zxTN/DNk
 fF6YHESa6WXS/T4iMJXjDgnTtWXgsNiiQ/AMJ7A+ZihHcEQPEtFxYtrVVTagH+hdCuQZypeNo
 qZc9t90B4A+dLkCcOQPg3AtURSuloD80yD7rO6oCkrGYVXbmt6QeBamw0wPcRBmbF20U8Bm2p
 4GbZwhyQgtnIKnj8Aat2G5dVzzdWIL+6yZaruqs/h/JNpdg18Hvai+r0vpjcNFuR1fMPJlO60
 U4ubm8YdMnlWvQuqwYxs/XkK6eAiqTAmQjbgEATnIjDdWjiu97kjg+0IxusjOBQF7Hg67fNG4
 20621mfHpfaHBaTwdkKeh9PNO3JvSEKYMCqGVvIdFH5/6mIQ5toGfQRpU00OFQ66qsdQFQG0L
 yXMyUay1R3pVI3sSM16hCaSwZfKEm8SSxoe3sSeXDYWMj22n/ViyJAWzThrn2LAHnTETypli5
 +HJOXWbqKNpuyLkunn5H+PtHxojX0miItTLHnWqkVI100k9cXLlzhhcVmeFAl1nVjeSCSu1DD
 wRDijQSK4UZ7vx0k96KmE51epKUgHlv+S3P6GVSWDWfZN3kw1G85qpqaI8ubnMLeBMH73SlB9
 KMZwflq3QHRHaTejS0D9yQrfB7m6nAnb7A1ICLe/3vcgB/Cs5zCyMx+CgEztxexuMUx7PcUGt
 RYM+Ldi1yG0up09JDFBI8Q83n3oCl4pMcnv8LMcFW48aW25nCKwHchN0BTbAI8hJNyPsNrgy3
 vc309JZoC34/ihXfcSSRrxKmrLI9MVd6mnkcvvdDiqkI8GhkWNK5Wib2hXflS4kzNCIV3o565
 M19UuEle6TSoqckkfzKfIHomGxHbtjBH3ATURchk0CCg2WJ/7v1cEqrvpay1emH1BAGfcj4U9
 uKEEH/ZBdTd23FzCSkZaMd79pg8=
Precedence: bulk

On 12/27/22 08:47, Rolf Eike Beer wrote:
> Am Montag, 26. Dezember 2022, 11:40:04 CET schrieb yang.yang29@zte.com.c=
n:
>> From: Xu Panda <xu.panda@zte.com.cn>
>>
>> The implementation of strscpy() is more robust and safer.
>> That's now the recommended way to copy NUL-terminated strings.
>>
>> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
>> Signed-off-by: Yang Yang <yang.yang29@zte.com>
>> ---
>> change for v2
>>   - sizeof(in) is better and simplified, thanks for Helge Deller.
>> ---
>>   drivers/parisc/pdc_stable.c | 9 +++------
>>   1 file changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c
>> index d6af5726ddf3..d3075445260b 100644
>> --- a/drivers/parisc/pdc_stable.c
>> +++ b/drivers/parisc/pdc_stable.c
>> @@ -274,8 +274,7 @@ pdcspath_hwpath_write(struct pdcspath_entry *entry,
>> const char *buf, size_t coun
>>
>>   	/* We'll use a local copy of buf */
>>   	count =3D min_t(size_t, count, sizeof(in)-1);
>> -	strncpy(in, buf, count);
>> -	in[count] =3D '\0';
>> +	strscpy(in, buf, sizeof(in));
>
> What is "count" now needed for? Looks like a write only variable at leas=
t in
> these hunks.

isn't count the return value?

Helge