Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sean Anderson <sean.anderson@seco.com>
To:     Ioana Ciornei <ioana.ciornei@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Sean Anderson <sean.anderson@seco.com>
Subject: [PATCH net] net: dpaa2-mac: Get serdes only for backplane links
Date:   Tue, 27 Dec 2022 18:09:18 -0500
Message-Id: <20221227230918.2440351-1-sean.anderson@seco.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EbL4ZDRFQ7/zyX9iDa53LqG4YPYGtf2ASFaf9YVCuVnv1E8UL/Wvse7AJxSB?=
 =?us-ascii?Q?8MeMDjAXNKD6agA4HqOYV557kVVou4S6CLnYpHFBkHSzhVOvuVSsNXumGxvI?=
 =?us-ascii?Q?H98A2SzGToq9UBG8fpcLrgNGvmVCv84Hq5R9GRL/pxuj17HOXh7aVmLKtVtz?=
 =?us-ascii?Q?Rc0mLwrPhCKVkxe0ihr/Kyhx4cNZOzjMCXQpvcURcTVkEizXFHOjE2JwW/ee?=
 =?us-ascii?Q?Qb34hUJbH10QgVeoC8zDNsA0u4lPrUoPKchFMx4Z6FEolt7C8JeMUJamDYuY?=
 =?us-ascii?Q?phZHhaXMbeYLVvzqmnBM+kdsFKfwCRc/fSMXbrjMJtHEpOemF3r7imAqubBL?=
 =?us-ascii?Q?9vT1PNfdwcsAPEGyWqduJXwKY4+LD47bVYpuJCApocV1X+FDochqInUAoeZj?=
 =?us-ascii?Q?3Efi8P+CSqVyfg27ZdDafkmiS4DxpumC74YbHDuxIR2iSirzk4xJ4aLJxZV1?=
 =?us-ascii?Q?Ly5YZPNCnNqPoxb1Gr3Faue2D5B9zEBXYryMGhqGqOb4e16Io/+BafXIUqdm?=
 =?us-ascii?Q?Y0xKOu5Hay2eF288XBR3zmnrCq9ZlQrAzolZbLIq+CCWWIxO6u+oM4JB788/?=
 =?us-ascii?Q?BcNdQXLcsFTL0H9hkvt6ijMw1uqwf5iiSmAx5+KrFuvrBVjmFyN7zBANOG7V?=
 =?us-ascii?Q?T0EhWffUomGbtu0Ixpcqu2Up+9lgTP5Y1Ft9If7y013Mz6aHgGgP19fmnoU+?=
 =?us-ascii?Q?Id5WE4nj2Ky0VVbR6bmceSJdVXkB3wzVvGQZnZPXns9E/FrNwvJ025XpIKYn?=
 =?us-ascii?Q?lJ6v5HdJpUpPQ6SYeIhcivpvSmUGZbpRm9sG6VsJLb8xMYQPhi1RToailQUQ?=
 =?us-ascii?Q?Rt3WkT4U3JqAnb4CMZq63CAAGRrI8Nv67+9A+fGbDIlVACHn1cd6fkqofvc2?=
 =?us-ascii?Q?PrUUEKGPEw/k34gbqEUpsGqQ3VpBg0mS7oiiJ9NA7v5oFYaX9tvIsD4a37U5?=
 =?us-ascii?Q?9zTS9F3ScQeIOiBV5uWnvsetLVQ6xlX8Uc/g7LLf12GwaGAz/zzC9irvHjWA?=
 =?us-ascii?Q?eHw3xsiCeSRCOfsZ31OgKOxLBFUtVMB4p/rK0IZ0EYSVZKPufgNSm5Hm7vDU?=
 =?us-ascii?Q?qFcFQz1cdtGG5XpP8kAeVIekqOKsVb8yMlIDtLEMAqXwT35YtqiRW/XGDxVC?=
 =?us-ascii?Q?fdM3yA1tO7RtfTkcqEwwlKTjDIS8xorOxacPRi1615kS5eYBgvgclyFloDI5?=
 =?us-ascii?Q?SIZiasFaJFio0I9luJB9mFpGS8yWJI1jjd3gujd3TcZvkztvI/sT7VmYpqJW?=
 =?us-ascii?Q?PkIwcpVgVsSWZI3M2gXk44D5Zxhfb1/dpmbPSiUCs6/YKRiBZcCh7vdZskJQ?=
 =?us-ascii?Q?bzXViMcechT9Pb7Lb6BAZTuD7fjhW2r7Ejdal8OixTycRDOXqWIM2RaTsYW0?=
 =?us-ascii?Q?lOiHRAkEr8SEAhzB+OAiHeHXkkZgPZBz44VgvCY7R6VDfAsi5BNFyqPDzI+I?=
 =?us-ascii?Q?jKwBD4G+68+N8LYa67uI9aHpyWfQWZe7Od24GIzxjAiIJ0PvrsnmJLc7mNrk?=
 =?us-ascii?Q?2lZwTybpuRdDJ+y/3MNdjOW+/2+kTFHSR8a59uVmeIiZubPwSsBwTtnyNQp5?=
 =?us-ascii?Q?Y7UvqfgZY4VaQ3knDV2gyBEZYSGIjefqSHuaBIlhxxy1kvzTlDlFcniDWh8Z?=
 =?us-ascii?Q?kg=3D=3D?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 353e07a1-291f-4c66-d633-08dae85f677a
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Dec 2022 23:09:28.3237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /eofMNOX78T//25Wh+7vwAXLxFGElmpMKHzqAp01zAHORzZZEPrE8SPMJDXKdrk+bcZqhr4yKv46msTYMn9mXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR03MB8840
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

When commenting on what would become commit 085f1776fa03 ("net: dpaa2-mac:
add backplane link mode support"), Ioana Ciornei said [1]:

> ...DPMACs in TYPE_BACKPLANE can have both their PCS and SerDes managed
> by Linux (since the firmware is not touching these). That being said,
> DPMACs in TYPE_PHY (the type that is already supported in dpaa2-mac) can
> also have their PCS managed by Linux (no interraction from the
> firmware's part with the PCS, just the SerDes).

This implies that Linux only manages the SerDes when the link type is
backplane. From my testing, the link fails to come up when the link type is
phy, but does come up when it is backplane. Modify the condition in
dpaa2_mac_connect to reflect this, moving the existing conditions to more
appropriate places.

[1] https://lore.kernel.org/netdev/20210120221900.i6esmk6uadgqpdtu@skbuf/

Fixes: f978fe85b8d1 ("dpaa2-mac: configure the SerDes phy on a protocol change")
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---
I tested this on an LS1088ARDB. I would appreciate if someone could
verify that this doesn't break anything for the LX2160A.

 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index c886f33f8c6f..0693d3623a76 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -179,9 +179,13 @@ static void dpaa2_mac_config(struct phylink_config *config, unsigned int mode,
 	if (err)
 		netdev_err(mac->net_dev,  "dpmac_set_protocol() = %d\n", err);
 
-	err = phy_set_mode_ext(mac->serdes_phy, PHY_MODE_ETHERNET, state->interface);
-	if (err)
-		netdev_err(mac->net_dev, "phy_set_mode_ext() = %d\n", err);
+	if (!phy_interface_mode_is_rgmii(mode)) {
+		err = phy_set_mode_ext(mac->serdes_phy, PHY_MODE_ETHERNET,
+				       state->interface);
+		if (err)
+			netdev_err(mac->net_dev, "phy_set_mode_ext() = %d\n",
+				   err);
+	}
 }
 
 static void dpaa2_mac_link_up(struct phylink_config *config,
@@ -317,7 +321,8 @@ static void dpaa2_mac_set_supported_interfaces(struct dpaa2_mac *mac)
 		}
 	}
 
-	if (!mac->serdes_phy)
+	if (!(mac->features & !DPAA2_MAC_FEATURE_PROTOCOL_CHANGE) ||
+	    !mac->serdes_phy)
 		return;
 
 	/* In case we have access to the SerDes phy/lane, then ask the SerDes
@@ -377,8 +382,7 @@ int dpaa2_mac_connect(struct dpaa2_mac *mac)
 		return -EINVAL;
 	mac->if_mode = err;
 
-	if (mac->features & DPAA2_MAC_FEATURE_PROTOCOL_CHANGE &&
-	    !phy_interface_mode_is_rgmii(mac->if_mode) &&
+	if (mac->attr.link_type == DPMAC_LINK_TYPE_BACKPLANE &&
 	    is_of_node(dpmac_node)) {
 		serdes_phy = of_phy_get(to_of_node(dpmac_node), NULL);
 
-- 
2.35.1.1320.gc452695387.dirty