Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2cc8378a-3f74-d4b5-613d-f9112806ec92@nvidia.com>
Date:   Tue, 27 Dec 2022 16:43:48 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH 2/7] hte: Add Tegra234 provider
From:   Dipen Patel <dipenp@nvidia.com>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     jonathanh@nvidia.com, linux-kernel@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
        linus.walleij@linaro.org, devicetree@vger.kernel.org,
        linux-doc@vger.kernel.org, robh+dt@kernel.org,
        timestamp@lists.linux.dev
References: <20221103174523.29592-1-dipenp@nvidia.com>
 <20221103174523.29592-3-dipenp@nvidia.com> <Y25x9gc4tpF1f022@orome>
 <1a186be2-498a-a63b-a383-c165a9f8e732@nvidia.com>
Content-Language: en-US
In-Reply-To: <1a186be2-498a-a63b-a383-c165a9f8e732@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0lOcGpCdW9SM3JaaFZqUENkd2FqdjkyRVVDN0pyUWJaRzFJN2pqR3ZZdEYv?=
 =?utf-8?B?N0VSNnFtUnBRQmNPYlhPcTNXQ1lVTkpOdkVlNnF2eHIvT0NHenBkakxHdlpD?=
 =?utf-8?B?Vmt0ejF4L2F3a0NzTFVBWmYrY1pTVFNEaTlSYlhSQ1FodytJNlZtTjZjMURy?=
 =?utf-8?B?aVNUbG9RUmRkL3VXaVo1UHRsVjZCaWxORDQ3dld3RHI0SmUrcFhmR3ArWWZR?=
 =?utf-8?B?MVdCRGxrVm8wQndZK2FIaXUrdWhMbVAxczI1c05xQnIwY1NtVmpxWlZKdDA4?=
 =?utf-8?B?S1h5ZERxNDhtVytjVkxhUkd6QVNZV0VrY3NlVnRRdDkwRTZzaSsvbzQ0NHYw?=
 =?utf-8?B?aUJObWRkY2Z1bDVxQks3UW5nRjMrWWgwNmhQdGgyVFZibkdIRlRFTkFBdzVW?=
 =?utf-8?B?aElGcEpVZlc5N2hmOTBFZUZPc25LblM3SVZNVHlINm0vdU1KL015YkNHZk83?=
 =?utf-8?B?MnNZc2Z3MEFMVU93amZianluTkRFcENtd2t2Zm1HU3JibWhCaTZFTWxENTNZ?=
 =?utf-8?B?azNtcUlpWUh6V0MyWEQyWlpVV1VQYzBUZk5SQWpLOWk5RTNDUlRyUEJjcW5Y?=
 =?utf-8?B?eW9HWk5YZGpYT2hmeDdCNjdWM1Y0eHdWWkIxT01yUXhDZDY5WU1OMFJkWFNx?=
 =?utf-8?B?dVRIS1ZFNFJlbzF0WElpT0ZUeElpU0dPNDQyV3VUamgrWnY5UkNjZUgwV2Fi?=
 =?utf-8?B?VE94eEIxbGR3dnI5cnBreWdOZW9WUlJ0aDlUZ1dzSW9KN2dXNERWZ3V4dHRQ?=
 =?utf-8?B?TVh6R012Mzc0MFQvVnFmUFMvOXhrNndPWXlxQnNXZ1p0TndIT1JNN0NtS2tu?=
 =?utf-8?B?VFpwRGpPQnY0cjNnSnNSNGFhU2hGODQyd0taY2VaY3phbHB2ODZIZjZLSVhV?=
 =?utf-8?B?YzZ3amlFb3czYmc3QTlyUUdXWndQSkhxZWhSY3ZXN2kyNW1Obkw2YnhDQ2FT?=
 =?utf-8?B?Skx6bDFHcGlRRTF3MDNpZTUzaDIrOVlaaVV6K3NibEpXYUVGWDBqSXVac3k2?=
 =?utf-8?B?a0dwZDZWbFU1VDNFSGJaWjN2a0VWVXhXQ1ppdlhUUFFVTW9aVFp5c21sVnZB?=
 =?utf-8?B?cGlsMDlQY1F4YTVyZUI5Qm9OWUZsZkJvMHFVa1JJL01MWnp2TUVTb2ZoQWZl?=
 =?utf-8?B?OTM1eHptZENiblJTdnFUdWxNek55K3RJNWtEZzF3SmptV0lYVTNoMVUrNTFq?=
 =?utf-8?B?TVp4MS9TRDVmLzRTTGdJUmFxUTk3U1BseDdGNnc3aENNT2NEdjBUT2loN3Rp?=
 =?utf-8?B?bjRuQmRFWlZMUHpYTjVPaS9ENlZ1RFFBYVROSEJGVk1hZlNiekE2cURzK3Rj?=
 =?utf-8?B?QlJuN0lXQTJ0YXpRVEEzWDhNdzlEa1ZkaEJjcmZzNUpmYS9UbGhTcFFWcllh?=
 =?utf-8?B?YVdQQUovV08wWmtCQjdmY3NIT1hWdStwcURuOFcyY24xMXhLd080SHRwZVd4?=
 =?utf-8?B?N2t6MXJJZmdiU2lUTjVRVkI4NzRreXI1aUx0UTFuQXFoOGJJb0dvUHVvZXVK?=
 =?utf-8?B?M3RGUTR0WW00S2h0bCswdkRuemVlSmdqZUpMM2NnUzlLYSs1UWFqbVpVQzQx?=
 =?utf-8?B?K21ObkVIZFdxZUlzMDNrWDV3Rm1HTk1Ydi91amN2bXdyM1pxdk41ZUlCb2lM?=
 =?utf-8?B?amNsMWNiWnN3SUkrcHhPT3pYVEdnYUhmRnFyc0xPWUpxMTgwY04xb1lNaFpi?=
 =?utf-8?B?MERidzdXSWdJblJ4RFJFd1M2L2RiTFRFWjZLemNVYmdsanhDekhuTEhKZXF5?=
 =?utf-8?B?bE9XZkFLRFpXQmppOGlad25NQzZaSVhmSndkbUF1VkZEWGo5NFlOekNpWC9K?=
 =?utf-8?B?TGR2SFdwdmViRGM3Y0xLZGtaNFFMSFV3WlptUGtCUGJlMVdLSlNlTWNNWDhF?=
 =?utf-8?B?Z0lRVmpaenJaajlnOFB1NXU0Mjk5Z1l0TldLUG45UVREdjRpSG1ic0lwS3BQ?=
 =?utf-8?B?bmlIUUdUc1A0S3NWOFBaV2U2ZytYNDRwRDU4eUF3bkttT1I0c2hYNUZlRitt?=
 =?utf-8?B?djhESmNkcWFjVmJYdVBnRXh5c2t3NXg1WS9zNFBrUTk1dmIzL1BsaGc0NGJn?=
 =?utf-8?B?WS9KRUlUbEE5WHRzNHhNWTF4ZExmblVVNjBDc2lTa1Q5TmNRWGdtNDJVTG1K?=
 =?utf-8?Q?9IS+nkttzjIr2vZ9+bD9rJKq0?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b2c8a38-5335-4e26-dc50-08dae86c9753
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2022 00:43:52.1501
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JW0oIIS8I5icDfqPXJVZPhfCiqxcr0owp4sym/S+VG7ggkZ4p9QMOpYTX3WGbO45VkehZiQfPBwcgXy37oR4JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4996
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/22 7:00 PM, Dipen Patel wrote:
> On 11/11/22 8:01 AM, Thierry Reding wrote:
>> On Thu, Nov 03, 2022 at 10:45:18AM -0700, Dipen Patel wrote:
>>> The Tegra234 AON GPIO instance and LIC IRQ support HTE. For the GPIO
>>> HTE support, it requires to add mapping between GPIO and HTE framework.
>>>
>>> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
>>> ---
>>>  drivers/hte/hte-tegra194-test.c |   2 +-
>>>  drivers/hte/hte-tegra194.c      | 124 ++++++++++++++++++++++++++++++--
>>>  2 files changed, 121 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
>>> index 5d776a185bd6..d79c28a80517 100644
>>> --- a/drivers/hte/hte-tegra194-test.c
>>> +++ b/drivers/hte/hte-tegra194-test.c
>>> @@ -16,7 +16,7 @@
>>>  #include <linux/hte.h>
>>>  
<snip>
>>>  MODULE_DEVICE_TABLE(of, tegra_hte_of_match);
>>> @@ -635,8 +742,17 @@ static int tegra_hte_probe(struct platform_device *pdev)
>>>  
>>>  		gc->match_from_linedata = tegra_hte_match_from_linedata;
>>>  
>>> -		hte_dev->c = gpiochip_find("tegra194-gpio-aon",
>>> -					   tegra_get_gpiochip_from_name);
>>> +		if (of_device_is_compatible(dev->of_node,
>>> +					    "nvidia,tegra194-gte-aon"))
>>> +			hte_dev->c = gpiochip_find("tegra194-gpio-aon",
>>> +						tegra_get_gpiochip_from_name);
>>> +		else if (of_device_is_compatible(dev->of_node,
>>> +						 "nvidia,tegra234-gte-aon"))
>>> +			hte_dev->c = gpiochip_find("tegra234-gpio-aon",
>>> +						tegra_get_gpiochip_from_name);
>>> +		else
>>> +			return -ENODEV;
>>
>> I'm wondering: instead of doing this cumbersome lookup, perhaps it would
>> be easier to create a direct link to the right GPIO controller with a
>> phandle?
> Possible, need to see if gpiod framework has API exposed to get the gpiochip from
> the phandle.

Thierry, I can not find any API which can help retrieve gpio_chip from the GPIO controller
phandle. I need gpio_chip->base to map GPIO line to GTE mapping.

>>
>> Thierry
>