Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Dec 2022 19:32:55 -0800
From:   Kees Cook <kees@kernel.org>
To:     Samuel Thibault <samuel.thibault@aquilenet.fr>,
        Kees Cook <keescook@chromium.org>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Simon Brand <simon.brand@postadigitale.de>,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 2/2] tty: Allow TIOCSTI to be disabled
User-Agent: K-9 Mail for Android
In-Reply-To: <20221227234000.jgosvixx7eahqb3z@begin>
References: <20221022182828.give.717-kees@kernel.org> <20221022182949.2684794-2-keescook@chromium.org> <20221227234000.jgosvixx7eahqb3z@begin>
Message-ID: <C95AF535-7A95-48BA-8921-1932C15A1931@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On December 27, 2022 3:40:00 PM PST, Samuel Thibault <samuel=2Ethibault@aqu=
ilenet=2Efr> wrote:
>Hello,
>
>Kees Cook, le sam=2E 22 oct=2E 2022 11:29:49 -0700, a ecrit:
>> TIOCSTI continues its long history of being used in privilege escalatio=
n
>> attacks[1]=2E Prior attempts to provide a mechanism to disable this hav=
e
>> devolved into discussions around creating full-blown LSMs to provide
>> arbitrary ioctl filtering, which is hugely over-engineered -- only
>> TIOCSTI is being used this way=2E 3 years ago OpenBSD entirely removed
>> TIOCSTI[2], Android has had it filtered for longer[3], and the tools th=
at
>> had historically used TIOCSTI either do not need it, are not commonly
>> built with it, or have had its use removed=2E
>
>No=2E The Brltty screen reader entirely relies on TIOCSTI to be able to
>support input from various Braille devices=2E Please make sure to keep
>TIOCSTI enabled by default, otherwise some people would just completely
>lose their usual way of simply typing on Linux=2E

Yup, it remains default enabled:

> [=2E=2E=2E]
>> +config LEGACY_TIOCSTI
>> +	bool "Allow legacy TIOCSTI usage"
>> +	default y
>> +	help
>> +	  Historically the kernel has allowed TIOCSTI, which will push
>> +	  characters into a controlling TTY=2E This continues to be used
>> +	  as a malicious privilege escalation mechanism, and provides no
>> +	  meaningful real-world utility any more=2E
>
>Yes it does=2E

Can you send a patch to adjust this language?

Also, what does FreeBSD use for screen readers?

-Kees


--=20
Kees Cook