From: Robin Getz <rgetz@blackfin.uclinux.org>
Organization: Blackfin uClinux org
To: "Mike Frysinger" <vapier.adi@gmail.com>
Subject: Re: Early printk behaviour
Date: Fri, 17 Aug 2007 17:29:33 -0400
User-Agent: KMail/1.9.5
Cc: "Gerd Hoffmann" <kraxel@redhat.com>, linux-kernel@vger.kernel.org
References: <200708152234.06734.rgetz@blackfin.uclinux.org> <200708171700.29647.rgetz@blackfin.uclinux.org> <8bd0f97a0708171409l39166daep185e89438f4104f0@mail.gmail.com>
In-Reply-To: <8bd0f97a0708171409l39166daep185e89438f4104f0@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200708171729.33621.rgetz@blackfin.uclinux.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1563
Lines: 47

On Fri 17 Aug 2007 17:09, Mike Frysinger pondered:
> On 8/17/07, Robin Getz <rgetz@blackfin.uclinux.org> wrote:
> >
> > Something like:
> >
> > Index: kernel/printk.c
> > ===================================================================
> > --- kernel/printk.c     (revision 3568)
> > +++ kernel/printk.c     (working copy)
> > @@ -1104,6 +1104,22 @@
> >  }
> >  EXPORT_SYMBOL(unregister_console);
> >
> > +int __init disable_boot_consoles(void)
> > +{
> > +       struct console *con;
> > +
> > +       for (con = console_drivers; con; con = con->next) {
> > +               if (con->flags & CON_BOOT) {
> > +                       printk(KERN_INFO "Unregister BootConsole %s%d\n",
> > +                               con->name, con->index);
> > +                       unregister_console(con);
> > +               }
> > +       }
> > +       return 0;
> > +}
> > +late_initcall(disable_boot_consoles);
> 
> is there any need for a return value then ?
> void __init disable_boot_consoles(void);

So, we don't get compiler warnings?

Otherwise:
kernel/printk.c:1119: warning: initialization from incompatible pointer type

> and if we dont think anyone else wants to call it ...
> static void __init disable_boot_consoles(void);

So I think static is Ok, but it needs to be int - that is the proper prototype

-Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/