Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932282AbXHQVd3 (ORCPT ); Fri, 17 Aug 2007 17:33:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759926AbXHQVdU (ORCPT ); Fri, 17 Aug 2007 17:33:20 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:33280 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760456AbXHQVdT (ORCPT ); Fri, 17 Aug 2007 17:33:19 -0400 Date: Sat, 18 Aug 2007 03:16:01 +0530 (IST) From: Satyam Sharma X-X-Sender: satyam@enigma.security.iitk.ac.in To: Christoph Lameter cc: Andrew Morton , Arjan van de Ven , Tim Bird , linux kernel Subject: Re: kfree(0) - ok? In-Reply-To: Message-ID: References: <46C233CB.9000602@am.sony.com> <1187132149.2618.2.camel@laptopd505.fenrus.org> <20070817112253.e6a7cb33.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1169 Lines: 30 On Fri, 17 Aug 2007, Christoph Lameter wrote: > On Sat, 18 Aug 2007, Satyam Sharma wrote: > > > Hmm, I didn't know ksize(NULL) was also allowed to succeed (and > > return 0). > > That was merged over my objections. IMHO ksize(NULL) should fail since we > are determining the size of an unallocated object. Agreed, I'd have implemented ksize() that oops'ed on NULL, myself. For that matter, I'd wish that kfree() oops'ed on NULL too (and have duly participated in such a flamewar once), but not many (if any) on this list seem to sympathize with such an opinion :-) > > Oh yes, of course. We want krealloc(NULL) cases to behave consistently > > as expected, and letting ksize(NULL) return 0 means the code for > > krealloc() can lose an extra "if (!p)" check that would otherwise have > > been required. Cool. > > krealloc should check for that. Agreed again, explicitly checking for that only sounds fair to me. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/