Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: multipart/signed;
        boundary="Apple-Mail=_40C9644B-DA5B-4EE1-AEDB-66403DCD5AE5";
        protocol="application/pgp-signature";
        micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.23\))
Subject: Re: [PATCH 7/7] rust: sync: add support for dispatching on Arc and
 ArcBorrow.
From:   Laine Taffin Altman <alexanderaltman@me.com>
In-Reply-To: <20221228060346.352362-7-wedsonaf@gmail.com>
Date:   Tue, 27 Dec 2022 23:24:37 -0800
Cc:     rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        linux-kernel@vger.kernel.org
Message-Id: <D0EB09C0-A9F6-4AB3-B9A2-98ACDAA25DAD@me.com>
References: <20221228060346.352362-1-wedsonaf@gmail.com>
 <20221228060346.352362-7-wedsonaf@gmail.com>
To:     Wedson Almeida Filho <wedsonaf@gmail.com>
Precedence: bulk


--Apple-Mail=_40C9644B-DA5B-4EE1-AEDB-66403DCD5AE5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On Dec 27, 2022, at 10:03 PM, Wedson Almeida Filho <wedsonaf@gmail.com> =
wrote:
>=20
> Trait objects (`dyn T`) require trait `T` to be "object safe". One of
> the requirements for "object safety" is that the receiver have one of
> the allowed types. This commit adds `Arc<T>` and `ArcBorrow<'_, T>` to
> the list of allowed types.
>=20
> Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>
> ---
> rust/kernel/lib.rs      |  1 +
> rust/kernel/sync/arc.rs | 20 ++++++++++++++++++--
> 2 files changed, 19 insertions(+), 2 deletions(-)
>=20
> diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> index 4bde65e7b06b..e0b0e953907d 100644
> --- a/rust/kernel/lib.rs
> +++ b/rust/kernel/lib.rs
> @@ -15,6 +15,7 @@
> #![feature(allocator_api)]
> #![feature(coerce_unsized)]
> #![feature(core_ffi_c)]
> +#![feature(dispatch_from_dyn)]
> #![feature(receiver_trait)]
> #![feature(unsize)]
>=20
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 832bafc74a90..ff73f9240ca1 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -92,9 +92,15 @@ use core::{
> /// Coercion from `Arc<Example>` to `Arc<dyn MyTrait>`:
> ///
> /// ```
> -/// use kernel::sync::Arc;
> +/// use kernel::sync::{Arc, ArcBorrow};
> +///
> +/// trait MyTrait {
> +///     // Trait has a function whose `self` type is `Arc<Self>`.
> +///     fn example1(self: Arc<Self>) {}
> ///
> -/// trait MyTrait {}
> +///     // Trait has a function whose `self` type is `ArcBorrow<'_, =
Self>`.
> +///     fn example2(self: ArcBorrow<'_, Self>) {}
> +/// }
> ///
> /// struct Example;
> /// impl MyTrait for Example {}
> @@ -123,6 +129,9 @@ impl<T: ?Sized> core::ops::Receiver for Arc<T> {}
> // dynamically-sized type (DST) `U`.
> impl<T: ?Sized + Unsize<U>, U: ?Sized> =
core::ops::CoerceUnsized<Arc<U>> for Arc<T> {}
>=20
> +// This is to allow `Arc<U>` to be dispatched on when `Arc<T>` can be =
coerced into `Arc<U>`.
> +impl<T: ?Sized + Unsize<U>, U: ?Sized> =
core::ops::DispatchFromDyn<Arc<U>> for Arc<T> {}
> +
> // SAFETY: It is safe to send `Arc<T>` to another thread when the =
underlying `T` is `Sync` because
> // it effectively means sharing `&T` (which is safe because `T` is =
`Sync`); additionally, it needs
> // `T` to be `Send` because any thread that has an `Arc<T>` may =
ultimately access `T` directly, for
> @@ -297,6 +306,13 @@ pub struct ArcBorrow<'a, T: ?Sized + 'a> {
> // This is to allow [`ArcBorrow`] (and variants) to be used as the =
type of `self`.
> impl<T: ?Sized> core::ops::Receiver for ArcBorrow<'_, T> {}
>=20
> +// This is to allow `ArcBorrow<U>` to be dispatched on when =
`ArcBorrow<T>` can be coerced into
> +// `ArcBorrow<U>`.
> +impl<T: ?Sized + Unsize<U>, U: ?Sized> =
core::ops::DispatchFromDyn<ArcBorrow<'_, U>>
> +    for ArcBorrow<'_, T>

These lifetimes need to be tied together, I think.
`impl<'a, T: ?Sized + Unsize<U> + 'a, U: ?Sized + 'a> =
core::ops::DispatchFromDyn<ArcBorrow<'a, U>> for ArcBorrow<'a, T>`

> +{
> +}
> +
> impl<T: ?Sized> Clone for ArcBorrow<'_, T> {
>     fn clone(&self) -> Self {
>         *self
> --
> 2.34.1
>=20
>=20


=E2=80=94 Laine Taffin Altman

--Apple-Mail=_40C9644B-DA5B-4EE1-AEDB-66403DCD5AE5
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEo5W+lyPTMTkLWJVjGsLcqzX23usFAmOr7zUACgkQGsLcqzX2
3utf9A//Yr/0rASWXyeNSGvowh8jtJLPNWwcaVEf2xb6/CD6zDXRvwPcTqtbSb+y
ldqt/skZJ4wFPBC2PAmOBXC5cmWNhNXuDWGWwlePtyuOghdwHwTFH7kB5Dk7m4wy
b0m50cTp859qhykWFcPC4pAWgW6Z2J+l2oYX16CUkwJK6briZmdSS7UdW9JGHqSx
s8vx3772q9CadE4NQWENlzqFAxcZ46nble/SXt2RUmKox2YzuP5EZkm7bGwPEuEE
qbRxKuL3RXIiEUrYLNakTPA8g2mZ6hO6LyogGmJ5vsD/7Lyrs2GU2dn2CvkfpwjF
91ic3q8/yju/z7L50+5sbHfHuKI8gzONVVOGcZo0nd0bkyNPoWOceiW6gFluA+52
0ws+XoOW03UkcpvRzPiTQ9ap9VaHJzEPz9B/AcM4N4zR8RICXr1hbKhBnHByoaRV
MjUKU/QvVxkBbDinD7ij1Buaw4sUbZnCMkPW/jEPviFC6grxm+V/D3LNN+y73DPI
j1ZXUKpl72/ujQ9cIJK339EvrBkSUnac/idybcncN++47yZHMyNaLczbOwAyx7Pl
gSvlrzEIggtZiD3EFMI6y4nsTimw3u8ALq2lfyxBCoE3vosHiNKLD240a+IikRbq
dFgwFw/2vAu+GEHCsfVcClTHASUAt6fas9oHBVz619zRWTsj6ao=
=mLYb
-----END PGP SIGNATURE-----

--Apple-Mail=_40C9644B-DA5B-4EE1-AEDB-66403DCD5AE5--