Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Dec 2022 11:42:22 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc:     linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hwmon@vger.kernel.org,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v1 1/5] rtc: isl12022: Get rid of unneeded private struct
 isl12022
Message-ID: <Y6wPfnRC3YeFxs3S@smile.fi.intel.com>
References: <20221126141806.62205-1-andriy.shevchenko@linux.intel.com>
 <a004a051-2f63-b5a4-bf7b-925850f1f718@rasmusvillemoes.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a004a051-2f63-b5a4-bf7b-925850f1f718@rasmusvillemoes.dk>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Nov 29, 2022 at 03:10:00PM +0100, Rasmus Villemoes wrote:
> On 26/11/2022 15.18, Andy Shevchenko wrote:
> > First of all, the struct rtc_device pointer is kept in the managed
> > resources, no need to keep it outside (no users in the driver).
> > 
> > Second, replace private struct isl12022 with a regmap.
> 
> Nice simplification.
> 
> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Thank you!

Alexandre, do you have any comments on this series?
If no, can it be applied now?


-- 
With Best Regards,
Andy Shevchenko