Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ef20a7dfa027f1a5a24a515e347af10c06a4da85.camel@icenowy.me>
Subject: Re: [PATCH v1 01/11] dt-bindings: usb: Add device id for Genesys
 Logic hub controller
From:   Icenowy Zheng <uwu@icenowy.me>
To:     Anand Moon <linux.amoon@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Wed, 28 Dec 2022 18:08:15 +0800
In-Reply-To: <20221228100321.15949-2-linux.amoon@gmail.com>
References: <20221228100321.15949-1-linux.amoon@gmail.com>
         <20221228100321.15949-2-linux.amoon@gmail.com>
Organization: Anthon Open-Source Community
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 
MIME-Version: 1.0
Precedence: bulk

=E5=9C=A8 2022-12-28=E6=98=9F=E6=9C=9F=E4=B8=89=E7=9A=84 10:03 +0000=EF=BC=
=8CAnand Moon=E5=86=99=E9=81=93=EF=BC=9A
> Add usb hub device id for Genesys Logic, Inc. GL852G-OHG Hub USB 2.0
> root hub and Genesys Logic, Inc. GL3523-QFN76 USB 3.1 root hub.
>=20
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> =C2=A0Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 2 ++
> =C2=A01 file changed, 2 insertions(+)
>=20
> diff --git
> a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> index a9f831448cca..db009f3ef438 100644
> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
> @@ -16,6 +16,8 @@ properties:
> =C2=A0=C2=A0 compatible:
> =C2=A0=C2=A0=C2=A0=C2=A0 enum:
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - usb5e3,608
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - genesys,usb5e3,610
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - genesys,usb5e3,620

I don't think genesys, is needed here because usb5e3 means USB VID
0x05e3, which is already linked to Genesys Logic.

In addition, the control logic of these two hubs are needed to be
verified.

And what's the status of the companion hub of the USB3 hub? Is it
really a USB3-only hub, or is its USB2 part just equal to another USB3
hub?

> =C2=A0
> =C2=A0=C2=A0 reg: true
> =C2=A0