Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Dec 2022 10:37:58 +0000
Message-ID: <86fsczbypl.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Sasha Levin <sashal@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Guenter Roeck <linux@roeck-us.net>, mpe@ellerman.id.au,
        christophe.leroy@csgroup.eu, windhl@126.com, Julia.Lawall@inria.fr,
        joel@jms.id.au, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH AUTOSEL 4.14 3/4] powerpc/msi: Fix deassociation of MSI descriptors
In-Reply-To: <20221227203611.1214818-3-sashal@kernel.org>
References: <20221227203611.1214818-1-sashal@kernel.org>
        <20221227203611.1214818-3-sashal@kernel.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 27 Dec 2022 20:36:08 +0000,
Sasha Levin <sashal@kernel.org> wrote:
> 
> From: Marc Zyngier <maz@kernel.org>
> 
> [ Upstream commit 4545c6a3d6ba71747eaa984c338ddd745e56e23f ]
> 
> Since 2f2940d16823 ("genirq/msi: Remove filter from
> msi_free_descs_free_range()"), the core MSI code relies on the
> msi_desc->irq field to have been cleared before the descriptor
> can be freed, as it indicates that there is no association with
> a device anymore.
> 
> The irq domain code provides this guarantee, and so does s390,
> which is one of the two architectures not using irq domains for
> MSIs.
> 
> Powerpc, however, is missing this particular requirements,
> leading in a splat and leaked MSI descriptors.
> 
> Adding the now required irq reset to the handful of powerpc backends
> that implement MSIs fixes that particular problem.
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Link: https://lore.kernel.org/r/70dab88e-6119-0c12-7c6a-61bcbe239f66@roeck-us.net
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  arch/powerpc/platforms/4xx/hsta_msi.c  | 1 +
>  arch/powerpc/platforms/cell/axon_msi.c | 1 +
>  arch/powerpc/platforms/pasemi/msi.c    | 1 +
>  arch/powerpc/sysdev/fsl_msi.c          | 1 +
>  arch/powerpc/sysdev/mpic_u3msi.c       | 1 +
>  5 files changed, 5 insertions(+)

Please drop this patch from all stable branches. It isn't needed
before 6.2, and doesn't fix anything on its own as nobody uses this
structure after this point.

	M.

-- 
Without deviation from the norm, progress is not possible.