Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Dec 2022 16:32:54 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     =?iso-8859-1?Q?P=E9ter?= Ujfalusi <peter.ujfalusi@gmail.com>
Cc:     Jayesh Choudhary <j-choudhary@ti.com>, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal
 probe deferral log
Message-ID: <Y6wiXlZh1MUL2WrF@matsya>
References: <20221128101334.512816-1-j-choudhary@ti.com>
 <f954e71b-043c-43bc-a692-530497de2d0b@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f954e71b-043c-43bc-a692-530497de2d0b@gmail.com>
Precedence: bulk

On 29-11-22, 18:28, P?ter Ujfalusi wrote:
> 
> 
> On 28/11/2022 12:13, Jayesh Choudhary wrote:
> > Change the log level from dev_err() to dev_dbg() for non-fatal probe
> > deferral log for getting MSI domain.
> > This makes the kernel log clean and we do not get recurring logs
> > stating: "Failed to get MSI domain".
> 
> Or not print at all?

that would be better one :-)

> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> 
> > 
> > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> > ---
> >   drivers/dma/ti/k3-udma.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> > index ce8b80bb34d7..e540166cf4c7 100644
> > --- a/drivers/dma/ti/k3-udma.c
> > +++ b/drivers/dma/ti/k3-udma.c
> > @@ -5344,7 +5344,7 @@ static int udma_probe(struct platform_device *pdev)
> >   	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
> >   					    DOMAIN_BUS_TI_SCI_INTA_MSI);
> >   	if (!dev->msi.domain) {
> > -		dev_err(dev, "Failed to get MSI domain\n");
> > +		dev_dbg(dev, "Failed to get MSI domain\n");
> >   		return -EPROBE_DEFER;
> >   	}
> 
> -- 
> P?ter

-- 
~Vinod