Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Dec 2022 12:28:38 +0200
From:   Sicelo <absicsz@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        tony@atomide.com, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: n900: switch accelerometer to iio driver
Message-ID: <Y6waVkobLCGqRHm7@tp440p.steeds.sam>
References: <20221227223841.2990847-1-absicsz@gmail.com>
 <20221227223841.2990847-2-absicsz@gmail.com>
 <73599d25-cd2c-e89a-20b4-d34471583a6b@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <73599d25-cd2c-e89a-20b4-d34471583a6b@linaro.org>
Precedence: bulk

Thank you for the review.

> > +	lis302dl: lis302dl@1d {
> 
> That's not really explained in commit msg and does not look related to
> your goal. If changing - in separate patch - make the node name generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
 
Now I understand that it should just be `accelerometer@1d`. To be clear,
are you saying this change should have a separate patch, i.e. not part
of the switch to iio driver?

> > -		Vdd-supply = <&vaux1>;
> > -		Vdd_IO-supply = <&vio>;
> > +		vdd-supply = <&vaux1>;
> > +		vddio-supply = <&vio>;
> 
> Does not look related/explained in commit msg.

This is from Documentation/devicetree/bindings/iio/st,st-sensors.yaml,
i.e. lowercase. I will look for a way to explain it in v2.

Sincerely
Sicelo