Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <617decfc-bab6-2ba9-53de-c9a0462a2c2a@ti.com>
Date:   Wed, 28 Dec 2022 19:02:43 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 2/2] remoteproc: k3-c7x: Add support for C7xv DSP on AM62A
 SoC
Content-Language: en-US
To:     Hari Nagalla <hnagalla@ti.com>, <andersson@kernel.org>,
        <devicetree@vger.kernel.org>, <mathieu.poirier@linaro.org>,
        <p.zabel@pengutronix.de>, <linux-remoteproc@vger.kernel.org>,
        <robh+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <s-anna@ti.com>
CC:     <praneeth@ti.com>, <nm@ti.com>, <a-bhatia1@ti.com>,
        <j-luthra@ti.com>, <devarsht@ti.com>
References: <20221228123655.15384-1-hnagalla@ti.com>
 <20221228123655.15384-3-hnagalla@ti.com>
From:   "Raghavendra, Vignesh" <vigneshr@ti.com>
In-Reply-To: <20221228123655.15384-3-hnagalla@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Hari,

On 12/28/2022 6:06 PM, Hari Nagalla wrote:
> Add support to the K3 DSP remoteproc driver to configure the C7xv
> subsystem core on AM62A SoCs. The C7xv susbsytem is based on C71 DSP
> with anlytics engine for deep leraning purposes. The remoteproc
> handling for device management is similar to the C66/C71 DSPs on K3
> J7 family SoCs, even though there are additional hardware accelerators
> and IP updates to C7xv subsystem.
> 
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> Signed-off-by: Jai Luthra <j-luthra@ti.com>
> ---

Signed-off-by of submitter should be at the last.

I see original author of the patch is Jai here. So you need to amend the
patch such that original author is set to Jai. His Signed-off-by should
be the first and then yours.

>  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> index eb9c64f7b9b4..ec626a37fef6 100644
> --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
> @@ -870,6 +870,10 @@ static const struct k3_dsp_mem_data c71_mems[] = {
>  	{ .name = "l1dram", .dev_addr = 0xe00000 },
>  };
>  
> +static const struct k3_dsp_mem_data c7xv_mems[] = {
> +	{ .name = "l2sram", .dev_addr = 0x800000 },
> +};
> +
>  static const struct k3_dsp_dev_data c66_data = {
>  	.mems = c66_mems,
>  	.num_mems = ARRAY_SIZE(c66_mems),
> @@ -884,10 +888,18 @@ static const struct k3_dsp_dev_data c71_data = {
>  	.uses_lreset = false,
>  };
>  
> +static const struct k3_dsp_dev_data c7xv_data = {
> +	.mems = c7xv_mems,
> +	.num_mems = ARRAY_SIZE(c7xv_mems),
> +	.boot_align_addr = SZ_2M,
> +	.uses_lreset = false,
> +};
> +
>  static const struct of_device_id k3_dsp_of_match[] = {
>  	{ .compatible = "ti,j721e-c66-dsp", .data = &c66_data, },
>  	{ .compatible = "ti,j721e-c71-dsp", .data = &c71_data, },
>  	{ .compatible = "ti,j721s2-c71-dsp", .data = &c71_data, },
> +	{ .compatible = "ti,am62a-c7xv-dsp", .data = &c7xv_data, },
>  	{ /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, k3_dsp_of_match);