Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Wed, 28 Dec 2022 08:43:44 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     "Cormier, Jonathan" <jcormier@criticallink.com>
Cc:     linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bob Duke <bduke@criticallink.com>,
        John Pruitt <jpruitt@criticallink.com>
Subject: Re: [PATCH v2 2/4] hwmon: ltc2945: Add devicetree match table
Message-ID: <20221228164344.GA1267483@roeck-us.net>
References: <20221214220727.1350784-1-jcormier@criticallink.com>
 <20221220000457.1163446-1-jcormier@criticallink.com>
 <20221220000457.1163446-3-jcormier@criticallink.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221220000457.1163446-3-jcormier@criticallink.com>
Precedence: bulk

On Mon, Dec 19, 2022 at 07:04:55PM -0500, Cormier, Jonathan wrote:
> Signed-off-by: "Cormier, Jonathan" <jcormier@criticallink.com>

There should still be some description here.

> ---
>  drivers/hwmon/ltc2945.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c
> index 9adebb59f604..9af3e3821152 100644
> --- a/drivers/hwmon/ltc2945.c
> +++ b/drivers/hwmon/ltc2945.c
> @@ -58,6 +58,12 @@
>  #define CONTROL_MULT_SELECT	(1 << 0)
>  #define CONTROL_TEST_MODE	(1 << 4)
> 
> +static const struct of_device_id __maybe_unused ltc2945_of_match[] = {
> +	{ .compatible = "adi,ltc2945" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, ltc2945_of_match);
> +
>  static inline bool is_power_reg(u8 reg)
>  {
>  	return reg < LTC2945_SENSE_H;
> @@ -475,8 +481,9 @@ MODULE_DEVICE_TABLE(i2c, ltc2945_id);
> 
>  static struct i2c_driver ltc2945_driver = {
>  	.driver = {
> -		   .name = "ltc2945",
> -		   },
> +		.name = "ltc2945",
> +		.of_match_table = of_match_ptr(ltc2945_of_match),
> +	},
>  	.probe_new = ltc2945_probe,
>  	.id_table = ltc2945_id,
>  };
> --
> 2.25.1