Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp4911924rwl; Wed, 28 Dec 2022 10:26:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXvQgwI7/q09eDFkEk5texzagOwqcFFE9EpPWTiDgXdS7h/66o7dzU078GibHN5nOfI/M+nl X-Received: by 2002:a05:6a20:cc59:b0:9d:efbf:48cb with SMTP id hq25-20020a056a20cc5900b0009defbf48cbmr25590943pzb.15.1672252006926; Wed, 28 Dec 2022 10:26:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672252006; cv=none; d=google.com; s=arc-20160816; b=eT0HZDnV2dE/ERR0PxIOn+b6VD/Y5eaLXJJsP2QEOjX1FtrwrAk1HbEIeaOKCM1S2D c/kcMeX+xi5M4zWaU3U0lITXtFWs16/DmpSwaDwGit1V1wsqU+QmK0F+pC3NWQE1hRC+ b8Ly50Q6UbvhGIG6f7eFlbce+p772bN32NRgDclTmj43iQoCUBElaN9nNemPn0neUoR8 9D56ystoMaAu/q7knmRQr8C2mwwTqHAdPBfoWxrx0961nj7sK+SXjdjK9Aihfb2WeFYu riefVxfnbXkDOHtsvNcpSExjRzDt3f9B1gYJ/AGQZbMdeqZI+/Y76IHiwyiBR50kCh7l ipWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yNfJeZewbC0pKTCrE+Db3iJ3tePu+J4Q4ao9Mr0HdzQ=; b=emPhbVEmHn8N9Sp42mcIb6AhVud4wq04BAD6QUkF7oessaZwzm1NLK93WOfl7L2Yug ipxQ62lJgOgA2iKw9oLrh1VQsfNFYzI2QnBYuVjbun7zgGmIJIaO12srdFga89uDwh0D ryqQziDHtZV8kNiuOHBO+9Dpi94sztvU6aJOfnedS/4UPa1huA1K7zcX0/I0OUjit4aV 46aWW3xJs8gyHOO2c361LYhUleE0nsXwQAQAM4k1XLMPpqXk0u3A1l4V/FKQGQuMYaGt NZ0Oz4873YrVN+ILKuhBiGGyHBMPlg6RVNS0R+nJq3H494CzzmeR4JlKa9nHneyQicdO Z/1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p86R2ZSD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a631d50000000b0046f75b665b8si6921741pgm.757.2022.12.28.10.26.35; Wed, 28 Dec 2022 10:26:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p86R2ZSD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233445AbiL1SS4 (ORCPT + 64 others); Wed, 28 Dec 2022 13:18:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233363AbiL1SSi (ORCPT ); Wed, 28 Dec 2022 13:18:38 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B21C175B4; Wed, 28 Dec 2022 10:18:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DDF4261582; Wed, 28 Dec 2022 18:18:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96FA2C433EF; Wed, 28 Dec 2022 18:18:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672251517; bh=uUVGWuZiaQOKU09yyOgoE6OKa2WCSHqNWbzCAny96FU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p86R2ZSD8gJHyYiWUkR96BFMTCWeYAL7LgstvOr1L8f40CZx+RrFt5buA9gtUs+NH +iXsFYz+pJ2EOR73lj3wUX+y5FVal7ILJpYcboLDc+tdfIoVWT4A3u2a7dKH48WP4O FQlxFi2noCMZQsotrOi6BNQUGFevhaGDxgiqWreHMbeLJ6m7K9U2i8dnuePfl+7uP9 WM2ybNEdVIvFxgTxXLfRzuj9CRGV0/oPk76LThe0SFwkmpJOD4gi2Kel89oIgAlibj mn3d3RKulM4AXIW4wT8KhXkzQV5R37NG1RZ+ZgXe97mXjnfTwOWKrlRjYsyLOO78SE aEtnlfgJe6Xug== From: Bjorn Andersson To: mathieu.poirier@linaro.org, abel.vesa@linaro.org, Bjorn Andersson , konrad.dybcio@somainline.org, agross@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH v2] remoteproc: qcom: q6v5: Use _clk_get_optional for aggre2_clk Date: Wed, 28 Dec 2022 12:18:26 -0600 Message-Id: <167225151223.950465.14429804095591076576.b4-ty@kernel.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220718121514.2451590-1-abel.vesa@linaro.org> References: <20220718121514.2451590-1-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jul 2022 15:15:14 +0300, Abel Vesa wrote: > Only msm8996 and msm8998 SLPIs need the RPM_SMD_AGGR2_NOC_CLK > (as aggre2 clock). None of the other platforms do. Back when the support > for the mentioned platforms was added to the q6v5 pass driver, the > devm_clk_get_optional was not available, so the has_aggre2_clk was > necessary in order to differentiate between plaforms that need this > clock and those which do not. Now that devm_clk_get_optional is available, > we can drop the has_aggre2_clk. This makes the adsp_data more cleaner > and removes the check within adsp_init_clocks. > > [...] Applied, thanks! [1/1] remoteproc: qcom: q6v5: Use _clk_get_optional for aggre2_clk commit: 6d967a5a49e8d08d8e4430aadba8d3c903b794a5 Best regards, -- Bjorn Andersson