Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Dec 2022 10:36:22 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>
CC:     X86-kernel <x86@kernel.org>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Tony Luck" <tony.luck@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v3 2/2] x86/microcode/core: Take a snapshot before and
 after applying microcode
Message-ID: <Y6yMpt+RMUL3Cqu1@a4bf019067fa.jf.intel.com>
References: <Y6tMgcU2aGbx/6yt@zn.tnic>
 <20221227210144.5112-2-ashok.raj@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221227210144.5112-2-ashok.raj@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?djljX7fYH8z5HxOH+0kHfDhWx4/q/4na8m09/45umxfeBv25uAcobv8j5IoY?=
 =?us-ascii?Q?Gfk8XQTZSvycxo+0iHsMAbRlc/HK0ckV3ZXoTaEOdxiwoS9PTRf1Pop6ztDu?=
 =?us-ascii?Q?yXi7BCAY3mEXn5SnAucjRdRYPFqMos9VaPBekIsnbREpOt5Oc7/NR2Z9FU/4?=
 =?us-ascii?Q?xUvmRvO/cvEXWDGvTEG2i2LZ8lrQbxCDHkkP+S4kMblXeMcbMRUvSVLR1wFN?=
 =?us-ascii?Q?Zu0Dc0rT70GwOvMOTeAnkmHoC7FIBDEobxLTGs6V0H56SGr7Tv9HvDpTkcXS?=
 =?us-ascii?Q?buQFfCafA0ePmCFsG+zTDcBpPXihvi4op7cg2HqCsJfxie2oiSFn0X86COnC?=
 =?us-ascii?Q?fF3kfDuI0S7FCmJ8alkSUB6stEBezf6AUez6boea52vfScWy4qgsU1lrkGh+?=
 =?us-ascii?Q?FY8rsK57N87voWoQ3c3pH8KxTqWTbawsPKNd1wXZI1R1iX2td/XqidPa+HD6?=
 =?us-ascii?Q?kS0vLzf9qCTJ2UADfv1RQewIRYCwS8E6KSbi/M2wOA0El8yg6wKqv5tKnfOl?=
 =?us-ascii?Q?JXySVaTThkx+4stCoD+FjrrMHe0jEEuw7Kcu4sXdHQ3JYAoIkXjmAmweSz2h?=
 =?us-ascii?Q?Obv6z6OGU/4o5/u9QX/iHAnYPHq4PfuGZKbLP2eh3LZaVCiayu4nWJGNVWff?=
 =?us-ascii?Q?cM89qSxgtPjMwTlwC7KYqBI/E7G7055uYkV9vb9mX29ShT8gQk9tpl3SYSya?=
 =?us-ascii?Q?trLLT6IwqXE2o5pNnB4bY+eB5vDYIDqWkcDYU3ynGBnbPqSJ5SZHkUtqjFIv?=
 =?us-ascii?Q?LIX5wv7h2jEyoTJRE43PCzmVgMcwSSRRkeC+1ypwBIKZbzPMD9KL8xGv5AGS?=
 =?us-ascii?Q?5CS9C3JEi7aGxVLTe+55NBINBKMmEuRuV1Do5rbQWrGZUNItJ4t1AqZc8tzj?=
 =?us-ascii?Q?5K7yvtlhUvxu06mWOE4AebSsBdP7bK0qdFY/HTY3oNrU+kl9pY+Npfh/JUbU?=
 =?us-ascii?Q?YI0Y1ZNgc7dD/5Ntud6ErhbUhhnmoRy79yx+YE5H/2E3CwqHK5a2toi983ZN?=
 =?us-ascii?Q?Gwx4FSGn4Dt9YzU+yVVelwPWMh9Np1/CaLTA3EeiUTnGRusf7OZP6uYrRAZu?=
 =?us-ascii?Q?lxxizHNzWj2ALAAOaroUqyL3bqcn/onlprD1oDj/FkgBMgYAl20tzorTe+wh?=
 =?us-ascii?Q?wY+jN/5A599na+2nOivQr+DRLe9KZpDQLFVPsrwwlQnyu033oLoJshCi1PNZ?=
 =?us-ascii?Q?MSscX0MCPHOFioZZAGaW0Upj4kPW5ZW2s/RS14Ugix3iPcRIpNWvbJGYS3z5?=
 =?us-ascii?Q?QZ3eCfLs856Z/U5suBlGckaiT+b0Su6TQTEXSa+5Vf8caKxhBY8Vx3zvx2mD?=
 =?us-ascii?Q?9NM77sKw8Pxot5gE7ZMGxB2+YiHCi3t7R+hrE/sy9rEl+oR1ebEm1q78VmTS?=
 =?us-ascii?Q?1JT7S0NhEN0n8aTCjgzAjC7guqkB0RwQX4Kbg+lECgEime1MFHYeIdxzfjLM?=
 =?us-ascii?Q?MuaOgpJKWTmGxRoYD4lus2uxtP36uuxaVar9nuBMRj16Vi2TEQ9XtylEk9Gn?=
 =?us-ascii?Q?DqLSGFuU9955RA4g1Jsce3+YTlNU/NhfZOzViK1Rfc9ufQlEwO+gF8pFRJGl?=
 =?us-ascii?Q?6yA0zTyR9aV+nP7o81C0jv8BRA8g4kSZLTORN36XDmLDZvkFu5TCc8SjViJJ?=
 =?us-ascii?Q?yg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 400de523-2efb-4c32-c05a-08dae9026c48
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2022 18:36:24.3822
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NZI1INlocMBQOiWi81hr9InpWXbPBiqVhU7VTldURzquEr59CCQhwLcZo1JZlKuE2+RQ0CbecNxGMUQtOUgt7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6942
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 27, 2022 at 01:01:44PM -0800, Ashok Raj wrote:
> The kernel caches features about each CPU's features at boot in an
> x86_capability[] structure. The microcode update takes one snapshot and
> compares it with the saved copy at boot.
> 
> However, the capabilities in the boot copy can be turned off as a result of
> certain command line parameters or configuration restrictions. This can
> cause a mismatch when comparing the values before and after the microcode
> update.
> 
> microcode_check() is called after an update to report any previously
> cached CPUID bits might have changed due to the update.
> 

I'll send you a clean version. Somehow this picked up an interim change and
the change to microcode_check() is not there. I remember testing but it
happened to be a different system I updated. 

I'll send something after the new years.. working during holidays isn't
efficient :-(.


Cheers,
Ashok