Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5332861rwl; Wed, 28 Dec 2022 17:20:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXvWurp9ZoeAid6LVYg/0/XNVnLhoIzLLH35133lE/nFEWUoAYfszSyJx0Cu4vjVpSuXzZLf X-Received: by 2002:a05:6402:2420:b0:463:a84c:6805 with SMTP id t32-20020a056402242000b00463a84c6805mr24650091eda.15.1672276832059; Wed, 28 Dec 2022 17:20:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672276832; cv=none; d=google.com; s=arc-20160816; b=waOtQqebL0qkt0aDvVPAY7CY/Qud4j4l4eM7O0Eifqx/ujiaY+ziZe17Qsv+0ioeij BQYZLQi4nJ6lz02hEdyO0o9d9oy0ZNn/EZ6cQEi2OhVJIGaHfd1oRBhyhLTZXIsanvaG Y4DSro58sPS7On7f60jEYhGcEZ9TOkqHGSI3L4rfYLKPqk3k5A/49poH7LeliUNUvX9q /lSdyRiWg1/6egODsiOfvCHtbUWovYicSczY5QGlQSfU9sRCGPkdk/+kqBhGtb0T0Wl4 sX4bMuxw2nXXlFwftGkSHULN/0lRvWyswlen+9Oy+NWBVpZq/ZtFtIKtKmWTdn8/aBC0 udmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=f2p2shVUpdpBRcPbig+xzUB8/WfGytn/tvXqnk/G7/Y=; b=jYmL2qBZErvhB3FcRDp8SWJ/oOPB40bS3yOGxuRupLz5vEqqtNBe+lff0y7kVnuf+D B5SKzGsb25JF5GpK3f0W2mmpM3X3wvz4ys0vB6Ns+TMdi6XLz0AFipkfAOvy9ZtlaPIc RTQQTTJ7yR8qTu6P1CI7e9Mi1fjQo4tIMU0C7FKhrWqu2PisE2OTd1O5CKnACE3ARD8/ tO7h9SNitFGZ6bwTEE09A2bNN25iMVrIFjM+Wc2ZxKI0Su241F3oQhzUFg52OtAqUFWX q+bCWEvOY/2q1rnQvE0i1dfE7tM84HLOzk7j210rJ+bzPcMLgJn3Tn7vAv1SYItvcWyt N9WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Gzjw0D8i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k26-20020aa7d8da000000b0046c44118d51si12716963eds.57.2022.12.28.17.20.17; Wed, 28 Dec 2022 17:20:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Gzjw0D8i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbiL2Aky (ORCPT + 62 others); Wed, 28 Dec 2022 19:40:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbiL2Aku (ORCPT ); Wed, 28 Dec 2022 19:40:50 -0500 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0748DF8D for ; Wed, 28 Dec 2022 16:40:48 -0800 (PST) Received: by mail-ot1-x330.google.com with SMTP id r2-20020a9d7cc2000000b006718a7f7fbaso10723448otn.2 for ; Wed, 28 Dec 2022 16:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f2p2shVUpdpBRcPbig+xzUB8/WfGytn/tvXqnk/G7/Y=; b=Gzjw0D8iyAbTjlB/MOb4J4YmMSW1zdzpRQCifiwhKhsZ7e8lkDYZvuuDw9+alRwI9j 3becoCce9AZU4D3fLWu5VgjqdWZmwVbd16kzYohhpmZHS64shJslyqIbB4nhVjZ0BvJd Z4W7VaKotC5HqA/8wU3fn8lx7vi9Ox2i0PP+M1J7GM9ZuO3VCpP7hQrRndAfHkWkOpX+ GqnNNrnymEPDCRoO6MXXEEoMbfXd5hdAdox8Pdi/2sMyzkBeHL9F5HM5PoULI+bK7L4z xMvOqu25W0oUvfDLAg7fCGEqRnesaAEkZgN7/t8t2Vlu6z6gNhM4BhIjvS3lWghb//4p Mj0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f2p2shVUpdpBRcPbig+xzUB8/WfGytn/tvXqnk/G7/Y=; b=Ho6SxbL7noeh93Vl9WdvUhfBezzep8z9qDwSVsi1+PApNSeLgcbDzELg1uyUpSd+VJ dXwvxrpRJ2tjs6kI1HnvyosPNpIj96FdnLRQeERJbqfRLbkCcijjliAQsGj3WDvv/RsU A0+kJE4eqeseyImwWpV46dQbt6InzEK/2s97WWtDgB2TiDDsh+8/66uu+WoDSFqxa5VC cFB3JP/YXxQCr1tw5306dKD6ln8Z7EpzD1AXN6lHr2+n9Wkx29T/9aVuHJpKTM1juA5p SHtRqlu28Z4E4XzyGizwI4xdgLrCtJ41zzkdALLc2GRXySNeAWjyfc00YnsYQYl6NHkt hQoQ== X-Gm-Message-State: AFqh2krS5tT4lPO8Q4L7Nf1P+LrGCuR4qkASF/Ow/RIuJ1pXI3csbYbJ jSGn/tTVlxmxKR19A9pDGvIdamfbE0hdWwrqVBW51Q== X-Received: by 2002:a05:6830:3499:b0:66c:61c8:ceeb with SMTP id c25-20020a056830349900b0066c61c8ceebmr1793244otu.12.1672274448080; Wed, 28 Dec 2022 16:40:48 -0800 (PST) MIME-Version: 1.0 References: <20221221210917.458537-1-fabrizio.castro.jz@renesas.com> <20221221210917.458537-4-fabrizio.castro.jz@renesas.com> In-Reply-To: <20221221210917.458537-4-fabrizio.castro.jz@renesas.com> From: Linus Walleij Date: Thu, 29 Dec 2022 01:40:36 +0100 Message-ID: Subject: Re: [PATCH v2 3/4] gpio: Add support for the Renesas RZ/V2M PWC GPIOs To: Fabrizio Castro Cc: Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Sebastian Reichel , Geert Uytterhoeven , Lee Jones , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Chris Paterson , Biju Das , linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Jacopo Mondi Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2022 at 10:09 PM Fabrizio Castro wrote: > The RZ/V2M SoC contains an External Power Sequence Controller > (PWC) module. The PWC module provides an external power supply > on/off sequence, on/off signal for the LPDDR4 core power supply, > General-Purpose Outputs, and key input signals. > > Add a driver for controlling the General-Purpose Outputs. > > Signed-off-by: Fabrizio Castro This is a nice driver. Reviewed-by: Linus Walleij Yours, Linus Walleij