Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Dec 2022 21:34:37 -0600
From:   Bjorn Andersson <andersson@kernel.org>
To:     Luca Weiss <luca@z3ntu.xyz>
Cc:     linux-arm-msm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Rayyan Ansari <rayyan@ansari.sh>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: qcom: pm8226: add IADC node
Message-ID: <20221229033437.kxwe73bomxw6sfi2@builder.lan>
References: <20221223193403.781355-1-rayyan@ansari.sh>
 <20221223193403.781355-4-rayyan@ansari.sh>
 <4448368.LvFx2qVVIh@g550jk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4448368.LvFx2qVVIh@g550jk>
Precedence: bulk

On Mon, Dec 26, 2022 at 01:14:59PM +0100, Luca Weiss wrote:
> Hi Rayyan,
> 
> On Freitag, 23. Dezember 2022 20:34:03 CET Rayyan Ansari wrote:
> > Add a node for the current ADC (IADC) found in PM8226.
> > 
> > Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> > ---
> >  arch/arm/boot/dts/qcom-pm8226.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> > b/arch/arm/boot/dts/qcom-pm8226.dtsi index 403324a35cf5..82470549f240
> > 100644
> > --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> > +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> > @@ -88,6 +88,12 @@ adc-chan@f {
> >  			};
> >  		};
> > 
> > +		pm8226_iadc: iadc@3600 {
> 
> Make this adc@ to conform to qcom,spmi-pmic.yaml docs
> 
> > +			compatible = "qcom,spmi-iadc";
> 
> Make this "qcom,pm8226-iadc", "qcom,spmi-iadc" and add to docs to conform to 
> qcom,spmi-iadc.yaml
> 

I adjusted the patch according to your requests and applied it. Rayyan,
please update dt binding documentation per Luca's request.

Thanks,
Bjorn

> Regards
> Luca
> 
> > +			reg = <0x3600>;
> > +			interrupts = <0x0 0x36 0x0 
> IRQ_TYPE_EDGE_RISING>;
> > +		};
> > +
> >  		rtc@6000 {
> >  			compatible = "qcom,pm8941-rtc";
> >  			reg = <0x6000>, <0x6100>;
> 
> 
> 
>