Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp5772611rwl; Thu, 29 Dec 2022 02:42:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXvlKf1YR2jXVA56sHjJ2/Fxwa1270B/LpiaOXgnhLhZkY4Op1//3JhMdqdklVfkVpfhWK2v X-Received: by 2002:a05:6a20:4995:b0:aa:7eab:25a5 with SMTP id fs21-20020a056a20499500b000aa7eab25a5mr31481087pzb.34.1672310572375; Thu, 29 Dec 2022 02:42:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672310572; cv=none; d=google.com; s=arc-20160816; b=p+QfmLcUPU+beazvZf3QsR0k4LNA1Z6krLalM6IsUN04/64eHJCjR8u9zSnFfPqaeg yqM/n/7i2sJPc1tFSqAu7HDuwVqqyTuWavI+LfARymKesdbMOb1UTLEoTPo1+paF6ghj VFYENkrLWeksFLnqf8cSCK8OAKCE37dAZG3VYtOmTWraQJmmFCE84U6CTjY5XnyC/KOc RZUrYUbJ8YLcQJDdVKfqQxZxDpCqcihoyYse+hRxWhqy2WXCqIxidT66tPiwtxliPMMk nJTygDlUgWZxTIzrBKf9wndH4MY3J+xo/c8r/JMtKtE0CF/9/c2gpvqoYhp0GxalWdP6 +lHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=vMKLMjJpe5LSVosq/kgKiCUoGwlkMRk7EHg56MOXRG0=; b=kfYcwbTIu8smWh6mb2navkkQcfX1/2miptkcMscN+vac/PgVDJ8Zt8NbNXO8MmdjaY GfXpkR4fm2qEw2y4cjBVdeWpKLDiEYMP8lBhUISspFO0r1cXLg6fTKxIwi76mAjhR7iM gKj0n0POMjXGgKerVEhHTY/ippAw0HHfeAqG3cw2ICtPl4dsBjXrWwciOjewmusCn6mN cP6O2lBL98hl9g1/CnHaRrQ5UiT8hc4+eGecC3gFxAWdxf+SYsN+f1ATuCvVD0kWtAs/ AT3PPJHJRZHmiEkClEIOFf9miQxN9DIXfjbP6Q7i0eLMU2JfnXApDYZg3gs1wND3sDGC HgNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W0/mzJ+B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m16-20020a63ed50000000b00476990d057asi18729066pgk.472.2022.12.29.02.42.44; Thu, 29 Dec 2022 02:42:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W0/mzJ+B"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233260AbiL2KYP (ORCPT + 62 others); Thu, 29 Dec 2022 05:24:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233259AbiL2KXk (ORCPT ); Thu, 29 Dec 2022 05:23:40 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE1145FAC for ; Thu, 29 Dec 2022 02:19:12 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id y25so26935640lfa.9 for ; Thu, 29 Dec 2022 02:19:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vMKLMjJpe5LSVosq/kgKiCUoGwlkMRk7EHg56MOXRG0=; b=W0/mzJ+BVYSeYNkqjUy3oTgPwLK1Bx4J2+308QC0ISlojj5vA7qUfYge3guPCW0vHR b4uo//YVXlquaTDtBEvxbnRLbSNe2ihsWAdvxUgYoZl+UxYKxRxRXRGdEQEh7KaHZttC xpqJPTr4MDV22D3FtYZIe7qJK+0g+cgNpJuRko0WgzLNja/E9UpMy3KX18bIVuCgwKiL V8rVp2b+G80ZWFuy43MTMYfn63OXdXuXo5NEd6S8hbKUe/B6ad/PPDyK0m7G68Rp9Ud+ WY5lvy6RWe3ZNXefsOkQFswi8xsP9eDLrPYQdvUe7Z+JZCEz5+l1pwcPfVV/fNbCcnr1 3AAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vMKLMjJpe5LSVosq/kgKiCUoGwlkMRk7EHg56MOXRG0=; b=ptruT/rHFqRW6vBm75g59eoiZAI8iWPRf+f8CI9hsLIgZqqv7Wn7trHKLDZhZzngig kNvVZjt/+K7L2Neq8D2f0cBEEH5AKK7sJMI+QOcYe0OnoPmHTiqjoAgn3PaGBVmWQRj+ 2uLXFX8pxylIRPUawJ5TxrFOqkr09XJ5UjWEn/KsPDSu82p0aExbgGc68uAQTxo5wG1E I5kFPr6ohc8KNIe2VIUlel6BD2yzn7mnT6CXFjUcOagJlCvu4PReJWl8VDDVOBW6O1sT Ufwe7WVSgzQuP9wOT9F3gwRdyAjmIkqopR+K7ruMld8EkH9di70RDuBtqD5B8xGCQmLS yXSg== X-Gm-Message-State: AFqh2koeUPKsz3fMZqOYY1jC/cvZanqOnecejF3F+5Doowdsy808o/Co PsVvsfANcIhrVhAGE+bwHyQHbA== X-Received: by 2002:a05:6512:3b2c:b0:4a4:68b7:deab with SMTP id f44-20020a0565123b2c00b004a468b7deabmr11677612lfv.7.1672309151197; Thu, 29 Dec 2022 02:19:11 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id d2-20020ac241c2000000b004a05402c5c3sm3024922lfi.93.2022.12.29.02.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Dec 2022 02:19:10 -0800 (PST) Message-ID: Date: Thu, 29 Dec 2022 11:19:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 2/3] dt-bindings: usb: generic-xhci: add Samsung Exynos compatible To: Daehwan Jung , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Thinh Nguyen , Mathias Nyman , Felipe Balbi Cc: "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com References: <1672307866-25839-1-git-send-email-dh10.jung@samsung.com> <1672307866-25839-3-git-send-email-dh10.jung@samsung.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <1672307866-25839-3-git-send-email-dh10.jung@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/12/2022 10:57, Daehwan Jung wrote: > Add compatible for Samsung Exynos SOCs Missing full stop. Please explain here in details the hardware. Otherwise it looks it is not for any hardware and patch should be dropped. Also, missing DTS. I am going to keep NAK-ing this till you provide the user. NAK. > > Signed-off-by: Daehwan Jung > --- > Documentation/devicetree/bindings/usb/generic-xhci.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > index db841589fc33..f54aff477637 100644 > --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > @@ -29,6 +29,8 @@ properties: > enum: > - brcm,xhci-brcm-v2 > - brcm,bcm7445-xhci > + - description: Samsung Exynos SoCs with xHCI > + const: samsung,exynos-xhci Missing fallback. > - description: Generic xHCI device> const: xhci-platform > deprecated: true Best regards, Krzysztof