Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221228200234.86391-1-mig@semihalf.com> <Y6zuJrb+8j+XCksN@lunn.ch>
In-Reply-To: <Y6zuJrb+8j+XCksN@lunn.ch>
From:   =?UTF-8?Q?Micha=C5=82_Grzelak?= <mig@semihalf.com>
Date:   Thu, 29 Dec 2022 15:14:47 +0100
Message-ID: <CADcojVPnZYtNHJUsLJCcHTnG=j0dfCbDNRqf2xmhcmV3b-oGfQ@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: dts: dove.dtsi: Move ethphy to fix schema error
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     linux-kernel@vger.kernel.org, sebastian.hesselbarth@gmail.com,
        gregory.clement@bootlin.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        mw@semihalf.com, upstream@semihalf.com, mchl.grzlk@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andrew,

Thanks for quick reply.

On Thu, Dec 29, 2022 at 2:32 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Wed, Dec 28, 2022 at 09:02:34PM +0100, Micha=C5=82 Grzelak wrote:
> > Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml
> > gives the following warnings:
> > mdio-bus@72004: Unevaluated properties are not allowed
> > ('ethernet-phy' was unexpected)
> >       arch/arm/boot/dts/dove-cubox.dtb
> >       arch/arm/boot/dts/dove-cubox-es.dtb
> >       arch/arm/boot/dts/dove-d2plug.dtb
> >       arch/arm/boot/dts/dove-d2plug.dtb
> >       arch/arm/boot/dts/dove-dove-db.dtb
> >       arch/arm/boot/dts/dove-d3plug.dtb
> >       arch/arm/boot/dts/dove-sbc-a510.dtb
> > Fix them by removing empty ethphy subnode from dove.dtsi and describe
> > PHY on the relevant board .dts files level.
>
> I don't think your description is correct. What i think is causing the
> problem is that the ethphy subnode in dove.dtsi does not have an @X.
>

Yes, it is exactly the case. The problem is after adding dummy address
e.g. ethernet-phy@0 in dove.dtsi 'make dtbs_check' shows warnings
about missing required 'reg' property, that's why ethernet-phy is
moved to .dts files.

> By moving it into the .dts file, you can then give it the correct @1,
> or @3, which makes the linter happy. The kernel itself does not care
> about this, it is an example of the linter being much more strict than
> the kernel.
>
> If you agree with me, please update the description.

This patch exactly fixes this issue by setting proper
ethernet-phy@<reg value> in board files.
In such a case would you like me to update the commit message to
better describe the change or do you have other remarks to the diff?

Best regards,
Micha=C5=82