Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <330942f7-6f53-cc7b-2b91-71b8bec6fe4e@linaro.org>
Date:   Thu, 29 Dec 2022 16:00:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v3] dt-bindings: net: marvell,orion-mdio: Fix examples
Content-Language: en-US
To:     =?UTF-8?Q?Micha=c5=82_Grzelak?= <mig@semihalf.com>
Cc:     linux-kernel@vger.kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        andrew@lunn.ch, chris.packham@alliedtelesis.co.nz,
        netdev@vger.kernel.org, devicetree@vger.kernel.org,
        upstream@semihalf.com, mw@semihalf.com, mchl.grzlk@gmail.com
References: <20221229142219.93427-1-mig@semihalf.com>
 <8e4ec6b0-63cf-c086-c00e-5b4e8a2b2d25@linaro.org>
 <CADcojVOt+pWSZkVdOSE15HmdfFSZWNDUkEA1hNvn62vGAYjFsg@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CADcojVOt+pWSZkVdOSE15HmdfFSZWNDUkEA1hNvn62vGAYjFsg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 29/12/2022 15:51, Michał Grzelak wrote:
> Hi Krzysztof,
> 
> On Thu, Dec 29, 2022 at 3:30 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 29/12/2022 15:22, Michał Grzelak wrote:
>>> As stated in marvell-orion-mdio.txt deleted in commit 0781434af811f
>>> ("dt-bindings: net: orion-mdio: Convert to JSON schema") if
>>> 'interrupts' property is present, width of 'reg' should be 0x84.
>>> Otherwise, width of 'reg' should be 0x4. Fix 'examples:' and add
>>> constraints checking whether 'interrupts' property is present
>>> and validate it against fixed values in reg.
>>>
>>> Signed-off-by: Michał Grzelak <mig@semihalf.com>
>>
>> This is a friendly reminder during the review process.
>>
>> It looks like you received a tag and forgot to add it.
>>
>> If you do not know the process, here is a short explanation:
>> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
>> versions. However, there's no need to repost patches *only* to add the
>> tags. The upstream maintainer will do that for acks received on the
>> version they apply.
>>
>> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
>>
>> If a tag was not added on purpose, please state why and what changed.
> 
> Deletion of tag wasn't on purpose, it was done by accident. Would you
> like me to resend the patch with it being added, or leave it as is?

No need, I added it here, so will be picked-up by maintainers.

Best regards,
Krzysztof