Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Bjorn Andersson <andersson@kernel.org>
To:     agross@kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-arm-msm@vger.kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
        konrad.dybcio@linaro.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8250: add cache size
Date:   Thu, 29 Dec 2022 11:23:30 -0600
Message-Id: <167233461757.1099840.14274696553215554413.b4-ty@kernel.org>
In-Reply-To: <20221229132731.1193713-1-krzysztof.kozlowski@linaro.org>
References: <20221229132731.1193713-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 29 Dec 2022 14:27:31 +0100, Krzysztof Kozlowski wrote:
> Add full cache description to DTS to avoid:
> 1. "Early cacheinfo failed" warnings,
> 2. Cache topology detection which leads to early memory allocations and
>    "BUG: sleeping function called from invalid context" on PREEMPT_RT
>    kernel:
> 
>   smp: Bringing up secondary CPUs ...
>   Detected VIPT I-cache on CPU1
>   BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:46
>   in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/1
>   preempt_count: 1, expected: 0
>   RCU nest depth: 1, expected: 1
>   3 locks held by swapper/1/0:
>    #0: ffff5e337eee5f18 (&pcp->lock){+.+.}-{3:3}, at: get_page_from_freelist+0x20c/0xffc
>    #1: ffffa9e24a900b18 (rcu_read_lock){....}-{1:3}, at: rt_spin_trylock+0x40/0xe4
>    #2: ffff5e337efc8918 (&zone->lock){+.+.}-{3:3}, at: rmqueue_bulk+0x54/0x720
>   irq event stamp: 0
>   Call trace:
>    __might_resched+0x17c/0x214
>    rt_spin_lock+0x5c/0x100
>    rmqueue_bulk+0x54/0x720
>    get_page_from_freelist+0xcfc/0xffc
>    __alloc_pages+0xec/0x1150
>    alloc_page_interleave+0x1c/0xd0
>    alloc_pages+0xec/0x160
>    new_slab+0x330/0x454
>    ___slab_alloc+0x5b8/0xba0
>    __kmem_cache_alloc_node+0xf4/0x20c
>    __kmalloc+0x60/0x100
>    detect_cache_attributes+0x2a8/0x5a0
>    update_siblings_masks+0x28/0x300
>    store_cpu_topology+0x58/0x70
>    secondary_start_kernel+0xc8/0x154
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm8250: add cache size
      commit: ac1d8a8e2eb5bd67e266e3121bb6b39b7f28a9ec

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>