Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6332684rwl; Thu, 29 Dec 2022 10:56:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXtyhhFn77Lib+6PfIQ+t4RgzfR7LG74F0tiJWfJcWqrhZMduVcDQkZ+mYkPhLq8ZT2kLAYW X-Received: by 2002:a05:6a20:be26:b0:b0:3329:c395 with SMTP id ge38-20020a056a20be2600b000b03329c395mr43180117pzb.30.1672340186206; Thu, 29 Dec 2022 10:56:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672340186; cv=none; d=google.com; s=arc-20160816; b=mgmNbTbChSoiiDyhdjrY+TbT5S9G/O4Euj63ffp+3kfW83QLhbME4M66b/OJvFs85B fEUjiLnvczj0B1zclp1/Y9pF81DV9oufaEA2XS5vi77aMXOWzypxNmVSui0AD4J6CcMq kViy0WyvMOccF4kJQnmT4rV9dXZrWLMY3Qeq8JZ07RX8mGDrs3hrzCYz3Qh36vA3arho 0dD3o2ndHheug21LiU6WVRC61Z+XIDamFGHA/4y7LC0kEpp//kYygLjLJWhcvHMCJMwB Bf1FhFHAClzs1Gsbv4/VYFlo3oQzhgfej0MTeRO+6MiN2w42DYrbUHWDpD2pcBkGl+a8 GVZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0OnG4BzavkIkRsoSKPQtFcsTzHVmQDZ4N5dtwuYHgN0=; b=j9L8RYjpdvjgyTBvKvl3+FS3IarJTRAltmEUlsbkLbsoScBnzOAndfHw/uZy4BjEyq tQcMDSfvdqzUZtC9Vad61CNd3RnDe8jgB4Cwa9428iKCbfJg31xSMGEi9M+nC6FHTadW nrh+k+KUp6j3jx6PqxqvxD2Z6WBf0uzbYDWWbFDKmSJJuuBgO2uUcvNFWya3TvYUcVrP 4E+t/ShyhB0ae8vGqYnVciiusssDOKurPNq5B3qiDFPByW39tU+VzlZVhKeo8RiscAoQ EmUsVulFemyueTvcNbTdyAzzRuASDn0qGZ32DiGbWx5yLM3VFb0qlKHKqgP9h6YmVUrS qr1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W+OBdfuS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bd7-20020a056a00278700b00576abbc404esi19545684pfb.238.2022.12.29.10.56.18; Thu, 29 Dec 2022 10:56:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W+OBdfuS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233856AbiL2SnV (ORCPT + 62 others); Thu, 29 Dec 2022 13:43:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231313AbiL2SnP (ORCPT ); Thu, 29 Dec 2022 13:43:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BA621CD for ; Thu, 29 Dec 2022 10:43:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5BD9BB819F3 for ; Thu, 29 Dec 2022 18:43:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54130C433EF; Thu, 29 Dec 2022 18:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672339392; bh=0OnG4BzavkIkRsoSKPQtFcsTzHVmQDZ4N5dtwuYHgN0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W+OBdfuSw4VOQX517g6q5EguwCRbm0l0qJ51JEhmnZE4fzbFO8j8eVZppHhAgTwfq xOIO9HUmtSLSwHP1TW2zxfICi7TpQfej9s8/t4jlQsrRk2d5NeXx2UCkw4Ui9b6rO9 vJaeewC6kmyndfGHRuGvZOEzH+V9xqUoK9L/7D4WH+7zYss/ZF1bIcT9sm+EHF1mU8 4zZVsgztSuyEtFdRdTPgxJ8gpGZcZ479dml8cHibManlzjNtG5pjh2yAQjM3n3RdFf pL8+4LIEyi1jLaNU4stn6ZFAejXKTx1kZEsylmNz6qpvQ2NihICOB/YmOxhFSy6LU6 D6DBDdCqJQ8/w== Date: Thu, 29 Dec 2022 11:43:08 -0700 From: Keith Busch To: Tong Zhang Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, t.zhang2@samsung.com Subject: Re: [PATCH v2] nvme-pci: fix error handling in nvme_pci_enable() Message-ID: References: <20221229183731.4013056-1-ztong0001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221229183731.4013056-1-ztong0001@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good. Reviewed-by: Keith Busch