Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 29 Dec 2022 16:50:07 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
CC:     Evgeniy Dushistov <dushistov@mail.ru>,
        Al Viro <viro@zeniv.linux.org.uk>,
        <linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v5 3/4] fs/ufs: Use ufs_put_page() in ufs_rename()
Message-ID: <Y641v67DTBgo3Sjn@iweiny-desk3>
References: <20221229225100.22141-1-fmdefrancesco@gmail.com>
 <20221229225100.22141-4-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221229225100.22141-4-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XMfk7bTv+twuJ2qz9KfuJay6kxykf6nwkpMU0lbHJ5vODUhYw2nemCK/J+bM?=
 =?us-ascii?Q?fDFB49aafZdggwXVgaHIp3iiPuqRvq+3YCjJelcztTy1jrwryp7T1Yx38tKY?=
 =?us-ascii?Q?YzBfYQUbWlbHhsMMNKCEY3BH+g8CgdikY37IZ5/FBscAo+qVAdDs5uAjwLNC?=
 =?us-ascii?Q?HZr8jopzA2ELwc1wtlqdomGfh7+He+ohAqaiq1KWXOq+grh3ChLF6RFJvsXa?=
 =?us-ascii?Q?K1cDXznvGASrroj4RwHE/TWV4kUznODpEGFzYLKekGZxg1rrJb1Atk+8TQU3?=
 =?us-ascii?Q?m1sVdxwRX3Ku9Q4fWRDMxBgdZy9yqmITDw86Sr/BIBKaXDiNc9b5V051OVVz?=
 =?us-ascii?Q?hbRqMA0Vgd/XgEHPZT5yJ54hSsU5kNZGdw0/xn9DbAYYSLLE42fMwDGMA1As?=
 =?us-ascii?Q?yfDx+rRq7cAAbX2KEmPyBbQkWFlNVE6anymxjcVvvanL7s/9HbVIXrzdlkAU?=
 =?us-ascii?Q?fqJT5ty7Bhd9ewzPw795YcxzTo61nWrhRfUaKm/4z83ljZaInVqPe5/vPNmE?=
 =?us-ascii?Q?4BzGpWzZyuFbEoAfjWk/R6ScEykTxUzm95pYmANdDK2TAPzbuHYsTwvDtWEY?=
 =?us-ascii?Q?UHdaieFTrkqYBLrq6H5NhXVZouPl4nm0nGODykf/nqNu9+0iEEdQGBImy/lP?=
 =?us-ascii?Q?+qFrI5OOeXNTVe63E0jlMijwajGOcGlOVBYjsIJEI3FUv7LsHHEAmNtayq8M?=
 =?us-ascii?Q?oqfispQ5nxwio/jlpuqrYXoGFjMWIZSx06gytP0he8bdbJttJodJdaEneH1k?=
 =?us-ascii?Q?bevm00OjF85TZwwZ3mnANN/AT//PP9ADKA0L4kvT/2w2uKcCzxPGFJmshC05?=
 =?us-ascii?Q?ZWF/syOV/w9yx8bnrBUv2UP5zliR+kyWjZpoweMoq4e/VhYQxrB44mkYpKVo?=
 =?us-ascii?Q?7AeGa0LFAkgmxmKAKHSKQCd7l2qatOMgIaM/RFycFMwxwRwSMVzL8RghBbnp?=
 =?us-ascii?Q?uSa2yo3pvPw0WyPLpyWlJ5Xpz2OqAb/lg3Wt08EfPj8+MLrmHU15Np4hoExq?=
 =?us-ascii?Q?vutGLuF4s+EhTFOLI87La3oyFh6FD36ucDuhJjvPFUbTob6fj/A+dLDAlYja?=
 =?us-ascii?Q?6pHgm+MGhWZezCKD053SUaQaY3Jyt1Tc1bHzRex55XBnfG8P33Yc57yWsp1u?=
 =?us-ascii?Q?DHkzrq95m6Grs6Z+KH0sjYZsCd6AOULKLCRDP7vZO/x1WqXAr/eft+c2JvZ8?=
 =?us-ascii?Q?HGxiIShr+r3qaU8CA5FvZhxRpyyFs0DTDvSzmuc3MpvCy1FuQmKREPIVWzxY?=
 =?us-ascii?Q?Y1UcYoe1a8zQPSxgQuS7jBFo+yOrlOdYXXeZBG77znQZPLTSQp26kdHBvw79?=
 =?us-ascii?Q?2O8ZQWZX2sCJIMkuO/S01euW/hNsjs6jpxt+ULbyr4GOuTv/BKGBNS4UEYlD?=
 =?us-ascii?Q?FOBHAwGBEPT0FyIRohM9+0OxySaUloXfkY+SxLdEvw/Td1/M6XVS3HzfDyhs?=
 =?us-ascii?Q?vdHVOAzZsHSQSNZ39+crB/cVoh4tVuw9HCcfJBPO0mvGEFLtHHjWCO0Hw7YE?=
 =?us-ascii?Q?k1G0MyTnHha+uffViQBu3QvVuyNj6SA/8X7SBLo6glxtw6QkBVzV+4+aqb7Q?=
 =?us-ascii?Q?NmndEOcq9XMlmug3uFen7Hb62+hX8gAJZOflNw9W?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e368cb0a-0aa3-4719-6df0-08dae9ffce05
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2022 00:50:11.0460
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s+/6nGL0gSSLrfF1/9fNOYGOcVnInvZp6fZ2+qErmcp0H11ZWC0i4JssRaMyIvOOZIxQWN5Gj0QNPELt8FjU4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4615
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 29, 2022 at 11:50:59PM +0100, Fabio M. De Francesco wrote:
> Use the ufs_put_page() helper in ufs_rename() instead of open-coding three
> kunmap() + put_page().
> 
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  fs/ufs/dir.c   | 2 +-
>  fs/ufs/namei.c | 9 +++------
>  fs/ufs/ufs.h   | 1 +
>  3 files changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c
> index ae3b20354a28..0bfd563ab0c2 100644
> --- a/fs/ufs/dir.c
> +++ b/fs/ufs/dir.c
> @@ -61,7 +61,7 @@ static int ufs_commit_chunk(struct page *page, loff_t pos, unsigned len)
>  	return err;
>  }
>  
> -static inline void ufs_put_page(struct page *page)
> +inline void ufs_put_page(struct page *page)
>  {
>  	kunmap(page);
>  	put_page(page);
> diff --git a/fs/ufs/namei.c b/fs/ufs/namei.c
> index 29d5a0e0c8f0..486b0f2e8b7a 100644
> --- a/fs/ufs/namei.c
> +++ b/fs/ufs/namei.c
> @@ -307,8 +307,7 @@ static int ufs_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
>  		if (old_dir != new_dir)
>  			ufs_set_link(old_inode, dir_de, dir_page, new_dir, 0);
>  		else {
> -			kunmap(dir_page);
> -			put_page(dir_page);
> +			ufs_put_page(dir_page);
>  		}
>  		inode_dec_link_count(old_dir);
>  	}
> @@ -317,12 +316,10 @@ static int ufs_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
>  
>  out_dir:
>  	if (dir_de) {
> -		kunmap(dir_page);
> -		put_page(dir_page);
> +		ufs_put_page(dir_page);
>  	}
>  out_old:
> -	kunmap(old_page);
> -	put_page(old_page);
> +	ufs_put_page(old_page);
>  out:
>  	return err;
>  }
> diff --git a/fs/ufs/ufs.h b/fs/ufs/ufs.h
> index 550f7c5a3636..f7ba8df25d03 100644
> --- a/fs/ufs/ufs.h
> +++ b/fs/ufs/ufs.h
> @@ -98,6 +98,7 @@ extern struct ufs_cg_private_info * ufs_load_cylinder (struct super_block *, uns
>  extern void ufs_put_cylinder (struct super_block *, unsigned);
>  
>  /* dir.c */
> +extern void ufs_put_page(struct page *page);
>  extern const struct inode_operations ufs_dir_inode_operations;
>  extern int ufs_add_link (struct dentry *, struct inode *);
>  extern ino_t ufs_inode_by_name(struct inode *, const struct qstr *);
> -- 
> 2.39.0
>