Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6730887rwl; Thu, 29 Dec 2022 19:28:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXtDe0XlUBVvaP2hbNpMUIuk1kYeEC1qACuE89QJWPlci4D+XwKJ1K8Qy63XBBrKaXbwadqz X-Received: by 2002:a05:6a20:1586:b0:ad:5a5d:3571 with SMTP id h6-20020a056a20158600b000ad5a5d3571mr46606820pzj.4.1672370936540; Thu, 29 Dec 2022 19:28:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672370936; cv=none; d=google.com; s=arc-20160816; b=KjFZUrNYyLmZVOYC0QvbKSLcLF3/N2io9a9IHQ/Szk9DQ0FsPm8JMHxs/hf1xUNxCq 7rPQG86nOONqwRyJSP4AoOF7uJmbw0kytdnPNi/VyaE4GyJxngRr5KyY1wmnTtXDgk1V GocxIAfO5+jhqOx4g538u/tOtXqV/Wty7b0kKwFcEgymZM4p886d++OF2rSnW6jbCVXN KkXZ28b8gRry//lYuSmxqc2omNJ4pRQqJn9Y94wK5HF9YhGOtHgNm03X0VF5XX08UG5C G2yUXR47Y1Z/w3uKyr9fpx1nglCJGPd7Tulv10FIoC7ywJ+9aAuqDV9Gzzz5AVYs7z0p kp2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=WY+sIsM1wSz4mwClqaMa9lEUgAt27EX1Ow30wZcRzqw=; b=1ARI8ODhcco+BljXjA2LOMYbK0cd7eM/GCORJ9mpp0a6nyJD8sAYN1QZaET3yj7klA QHDx21LO1/56M1AytOr1hHlUfPHVX+kxx0LHUyHysBZGiKWoEhKeQyec8nMAI7Zwb0Bf Nhq53FgIYo/+PnVgu0hZp+wTo9+G4SbxSmPePky9uvTW2wzykUCuZH0gWvGBsF7sgPin +ntzqxUxt1JT3f27ncLGnMCHzqXQfKt3S5lTKW3qIyDbV+vqN/lBPu6nOB2+vFujjcwr 3sKdOz8lxtf25gAnmHUVrKa13xxr7W+EJtDZlT57tODpyZCYHsZqHxPDJ5MWHr7edWHD CpQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gEjkS0Ed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 203-20020a6302d4000000b00478b774f0ebsi20986750pgc.635.2022.12.29.19.28.47; Thu, 29 Dec 2022 19:28:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gEjkS0Ed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234353AbiL3Cv2 (ORCPT + 65 others); Thu, 29 Dec 2022 21:51:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbiL3CvZ (ORCPT ); Thu, 29 Dec 2022 21:51:25 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06F082638; Thu, 29 Dec 2022 18:51:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8EB60B819EB; Fri, 30 Dec 2022 02:51:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD662C433EF; Fri, 30 Dec 2022 02:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672368682; bh=HulvsuCGLYDSm7wtBF1VVsTHpiI4VFtybnD2qVartKU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gEjkS0Edbbzzgo0PBEc8bHzFvuuzTriMlUNpvDBx9QSLslr2QlObTgnXhMjZpxDfj uDkdgrFKVAHaog2pFkeFu1iExXYD5S6UNjr6+fa2SiPSbcXSAD9G2/C1TSw/atVdoi KKu5pMUWjnvqXWfU/SVZlKXg/UdwuuayfaeAL/kLeAjIba4n0OKv2RyFV6jDAyDp1b 79y3ktxf9qZxOEKDfoDLQOy2NznVPdVZ8Rpy3fOwN8v7D6xTz8xJFyqJvzzMAOX1WA ufNejPvlw2h22s2psp5QvnUWoOj0/MZ6A5dOMBLYWuDX9cpRZoA/s99R/M7ciCQNpx ebotmWHyZ0IfQ== Date: Thu, 29 Dec 2022 18:51:20 -0800 From: Jakub Kicinski To: Jason Wang Cc: "Michael S. Tsirkin" , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, alvaro.karsz@solid-run.com, eperezma@redhat.com Subject: Re: [PATCH 1/4] virtio-net: convert rx mode setting to use workqueue Message-ID: <20221229185120.20f43a1b@kernel.org> In-Reply-To: <6026e801-6fda-fee9-a69b-d06a80368621@redhat.com> References: <20221226074908.8154-1-jasowang@redhat.com> <20221226074908.8154-2-jasowang@redhat.com> <20221227023447-mutt-send-email-mst@kernel.org> <6026e801-6fda-fee9-a69b-d06a80368621@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Dec 2022 17:06:10 +0800 Jason Wang wrote: > > Hmm so user tells us to e.g enable promisc. We report completion > > but card is still dropping packets. I think this > > has a chance to break some setups. > > I think all those filters are best efforts, am I wrong? Are the flags protected by the addr lock which needs BH, tho? Taking netif_addr_lock_bh() to look at dev->flags seems a bit surprising to me.