Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Dec 2022 10:56:28 +0800
From:   Kevin Hao <haokexin@gmail.com>
To:     Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc:     linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vipin Sharma <vipinsh@google.com>
Subject: Re: [PATCH] scripts/tags.sh: Fix the Kconfig tags generation when
 using latest ctags
Message-ID: <Y65TXGzQTJ/+5Mr5@pek-khao-d2>
References: <20221229055401.855185-1-haokexin@gmail.com>
 <5e1b0401-db1e-a7a4-787c-4b93d02f5b73@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="V/Y5c8o4YZu8/fyS"
Content-Disposition: inline
In-Reply-To: <5e1b0401-db1e-a7a4-787c-4b93d02f5b73@collabora.com>
Precedence: bulk


--V/Y5c8o4YZu8/fyS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 29, 2022 at 02:33:15PM +0200, Cristian Ciocaltea wrote:
>=20
> On 12/29/22 07:54, Kevin Hao wrote:
> > The Kconfig language has already been built-in in the latest ctags, so
> > it would error exit if we try to define it as an user-defined language
> > via '--langdef=3Dkconfig'. This results that there is no Kconfig tags in
> > the final tag file. Fix this by skipping the user Kconfig definition for
> > the latest ctags.
> >=20
> > Signed-off-by: Kevin Hao <haokexin@gmail.com>
> > ---
> >   scripts/tags.sh | 10 ++++++----
> >   1 file changed, 6 insertions(+), 4 deletions(-)
> >=20
> > diff --git a/scripts/tags.sh b/scripts/tags.sh
> > index e137cf15aae9..c56b13ae3fdf 100755
> > --- a/scripts/tags.sh
> > +++ b/scripts/tags.sh
> > @@ -264,10 +264,12 @@ exuberant()
> >   	--$CTAGS_EXTRA=3D+fq --c-kinds=3D+px --fields=3D+iaS --langmap=3Dc:+=
=2Eh \
> >   	"${regex[@]}"
> > -	setup_regex exuberant kconfig
> > -	all_kconfigs | xargs $1 -a                              \
> > -	--langdef=3Dkconfig --language-force=3Dkconfig "${regex[@]}"
> > -
> > +	KCONFIG_ARGS=3D""
> > +	if ! $1 --list-languages | grep -iq kconfig; then
> > +		setup_regex exuberant kconfig
> > +		KCONFIG_ARGS=3D"--langdef=3Dkconfig --language-force=3Dkconfig ${reg=
ex[@]}"
> > +	fi
> > +	all_kconfigs | xargs $1 -a $KCONFIG_ARGS
> >   }
>=20
> The 'regex' array needs quoting to prevent word splitting/globbing.

Fair enough.

> I would
> suggest to transform 'KCONFIG_ARGS' into an array as well:

Sounds great. V2 is coming.

Thanks,
Kevin

>=20
> KCONFIG_ARGS=3D()
> if ! $1 --list-languages | grep -iq kconfig; then
> 	setup_regex exuberant kconfig
> 	KCONFIG_ARGS=3D(--langdef=3Dkconfig --language-force=3Dkconfig "${regex[=
@]}")
> fi
> all_kconfigs | xargs $1 -a "${KCONFIG_ARGS[@]}"
>=20
>=20
> >   emacs()

--V/Y5c8o4YZu8/fyS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEHc6qFoLCZqgJD98Zk1jtMN6usXEFAmOuU1wACgkQk1jtMN6u
sXEnlQf/Z8WDmHpzGfxDOdDP7z8nxoq+RR9f1R2LkeQg085MTAYa2V9IbNUAnsVe
DSo/3ZYhBZ9LPZjEvSRdp9qkOO9zvmJTy68myO4515bLWG56WF0w8jI/XqsbDIiI
nELY5ZLVxw2oUzUrTlBandtHMRudOpsMiHrmmoS07aiy4v8pSBCEUGg1dBZ2r05d
GLQYbQ2ptNG27LgpeElcCPJHUgLPZeRLRckZay/W8blO8G5o1e7lWzfQ4/j7HikC
GhBqQ2pyA1xNotI0UafLpmOGZTBS1dOJrYkrvu+gPILKoziBlRDP8jaopCETq3XJ
EzNxBwNdBb411Tpx+06Vz0A5IBEOBg==
=Tx68
-----END PGP SIGNATURE-----

--V/Y5c8o4YZu8/fyS--