Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6760846rwl;
        Thu, 29 Dec 2022 20:13:04 -0800 (PST)
X-Google-Smtp-Source: AMrXdXvFuEn4WKCwwtWk2g3Tgzvc3pEngORv+2oY75sT5fBeSyqN9hpqgGKiXUlm1bNSyumTHvZB
X-Received: by 2002:a05:6a20:939a:b0:af:9539:a29e with SMTP id x26-20020a056a20939a00b000af9539a29emr38074890pzh.16.1672373583997;
        Thu, 29 Dec 2022 20:13:03 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1672373583; cv=none;
        d=google.com; s=arc-20160816;
        b=xCl9B6Pzjzc3OuFS4G3PhcCjnBUCSeYg9mfo60lhZ4pb3+wkO/W78Ocv9iEqSOwOxE
         c2k6hjQqob7cLCXW1De0sdAiuycc6+wKbJsXlYUSJTVbnKhK5g9AY0IZjPs3F2FNEVMp
         pqC9WuQR0Kztu0uk29Afurk/eJhvmyPywjjdXwhufUD4WP9fNiNprTBPqWHQo2Jmz2re
         N+QhzT4dnD5RZSNmuwrDKrG2ZiHUizJwngRn9HRjBDsj3CJAfy1uGDQ3EhN8rBGJEbqa
         J0hF0jRZOpvtqmMp6p3CwG+0Ukt0rWiqoEBpyr7e9LgMbmL43WYBAtW2tqnTrfj6mUxX
         LGXQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=tHb6oQ1DijLPwosHVe5IASjyYb2BWdrYkGVcCUq8k3k=;
        b=PnOywrwXRHW1ESTe8bLXtdtLNJZMhyZcHM/MQ1AFtNKxMYerLpAti08nggBiwlBqiY
         OaZt2ZAcSlbkb+lbOkNhRLw/KcnYkhF/A/8Y2l+l3DIPhorWxb9hzUVo2X+tB+EFHYIE
         ie+Up9w0cDsRrTogm3uzKmDqWgcDg00aZZomTxS7vkTP0l5EEWAlxc1WRttF/ykQNHrB
         W4a7kB4GWb/HhOiN3sp5o4JwyX5eMbvQs7Sr1pPk4yHnvtplsFZ2DaSMqyN1QxXJ5+uZ
         MS2bgEswaKXa7p09HuZvHubDF5vBK8295XG7nlqUqnw1PSwzL9Wf3AAfD0MXl/cqRDua
         zojQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kR05itrw;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id r17-20020a635d11000000b00478413ae229si20919019pgb.194.2022.12.29.20.12.55;
        Thu, 29 Dec 2022 20:13:03 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kR05itrw;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234342AbiL3EJd (ORCPT <rfc822;a839024@gmail.com> + 64 others);
        Thu, 29 Dec 2022 23:09:33 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36818 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229570AbiL3EJa (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Dec 2022 23:09:30 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D5BEA1A1;
        Thu, 29 Dec 2022 20:09:29 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id C6907B819DB;
        Fri, 30 Dec 2022 04:09:27 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28AF3C433EF;
        Fri, 30 Dec 2022 04:09:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1672373366;
        bh=FW0Ghro1YfdNHaROU9BLpNPW2URNdS5e0jD4DYmFGVY=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=kR05itrw1kY8GUsweeZDGSYnJBtWuUFsFErsSMBT/BpgOg+eumQO/OE1RdlGak3Ck
         N2XTmaGosrMItGcO/RcaBkLEz5EFY6jPNxfexB1LrXy8d7dHmMHCAJzzd6XuCdf+Vc
         hFA8ZogeaeEekR2fBOPdp/UheZKA21tuJiWwsTrLX2LoAMQAxoBtR2cNg7opETwHYK
         LawMlUvg7FDBREjRR8Fmiwnv8MSChIn3x5BUIRvjZeVBZPYFfVSPBQK9GNYI8CiqbB
         RQEdgAAUbcIV5dG4NcMg5pyUFUj3iHKiJhwmYKjILhbdtYHn0+LgE0AkzMSKNZnIjN
         pWSGiYAO9rfow==
Date:   Thu, 29 Dec 2022 20:09:25 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Sean Anderson <sean.anderson@seco.com>
Cc:     Ioana Ciornei <ioana.ciornei@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: dpaa2-mac: Get serdes only for backplane links
Message-ID: <20221229200925.35443196@kernel.org>
In-Reply-To: <20221227230918.2440351-1-sean.anderson@seco.com>
References: <20221227230918.2440351-1-sean.anderson@seco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Dec 2022 18:09:18 -0500 Sean Anderson wrote:
> +	if (!(mac->features & !DPAA2_MAC_FEATURE_PROTOCOL_CHANGE) ||

This line is odd as sparse points out