Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6847350rwl; Thu, 29 Dec 2022 22:28:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXtL/0MZhCjUC7tS+4IBUsYQ8z9pubAV8BXOxGYcMILGPDjnNfkIwxYIhlPpRPfo/ESuK7lo X-Received: by 2002:a17:906:3a85:b0:7c4:f0b5:fedc with SMTP id y5-20020a1709063a8500b007c4f0b5fedcmr25979913ejd.65.1672381691241; Thu, 29 Dec 2022 22:28:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672381691; cv=none; d=google.com; s=arc-20160816; b=Gu1gpU+HfNpHK/GOTchGw3OWo52IhRwrVhOhVZKeI//O1FGtgTJz405Vji9MdWotN5 2JGmZReKjNcDuKX1uAa/Z9e4ygN0UBgUUHhSIGKOCcssA0qLiu7nlzFaIMIz043j8nUM 15P0I0ljRLA/lEGut1rHgdY7Cj6jRguBajnjRgpvJ/n0VWjN4OrU4fu5VD9ro23y8eml wAvLOwr/Q+KdZ8Qpc7zweyiWHZ+gzw85HaWHRQVsK8D/c2L9/aTNrYrZ5veg+dsGeVX0 pDqKXxQXSV+wPKfvaBl/SqYRQUr0caFspVPzuhaKmC6fq2ZHaPpEQT7LgZneeQezimtu NZ1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HZ1UEuoswFV91eUeLIRJsGfxTtDFlYQbel62pi18o2U=; b=woEedQPiY2O0cBsV9XDEsLpGM9GqTwPDJxaym66RtHaZ/MQZAl8QwFVcL6duMHLGXp wl2pkuadoA/DtCApN12dbhDEWW8HX/nCTtTpkxyPPWyv69ELjaE8Gpkf87F68Pv0a1lE RSuhpSDmBu3fxeYdK1u3JQIweS64UUa7lhZ44DjUVmR+aJaEco/lxU+IToajktecJe/Q Yw4IbgLGvdyaIzECCflzulEDtbctdbUy7y5MmnGE4MHELGXSEB1XnEMap7aIhH/eeZ7c klmU4P2IWlJitpyvZ53XfCFvjapKxTysW5RkZC9kmw5dyrMkJ5wRLtACUAAj+UTcprST EEdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=OBWfK1V2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p20-20020a1709060dd400b007c179af6e06si13344266eji.955.2022.12.29.22.27.56; Thu, 29 Dec 2022 22:28:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=OBWfK1V2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234454AbiL3GEi (ORCPT + 64 others); Fri, 30 Dec 2022 01:04:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbiL3GEf (ORCPT ); Fri, 30 Dec 2022 01:04:35 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 879D92705; Thu, 29 Dec 2022 22:04:33 -0800 (PST) X-UUID: b010f305589044018866764ff239394a-20221230 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=HZ1UEuoswFV91eUeLIRJsGfxTtDFlYQbel62pi18o2U=; b=OBWfK1V22CSmR5yTHA99TwuXBwEX0VQUzqsi4Pj33nUywBueYO3lOMuInfXj5jE9BWhE5H8QP9KRMWnDC1I4ZkzlbEeAg+uoan/2dhHot6TnxhXms2W2z58fS4CvzRhJDFFx2L2aLW47pQmnlX4tjbteYXeXaqo1m3n/lifhJiA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.16,REQID:d932d63d-87bf-4f90-9edf-125800eae4c7,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:09771b1,CLOUDID:943f60f4-ff42-4fb0-b929-626456a83c14,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0 X-CID-BVR: 1,FCT|NGT X-UUID: b010f305589044018866764ff239394a-20221230 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 349687402; Fri, 30 Dec 2022 14:04:27 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 30 Dec 2022 14:04:27 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 30 Dec 2022 14:04:27 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 22/23] clk: mediatek: clk-mt7986-topckgen: Properly keep some clocks enabled Date: Fri, 30 Dec 2022 14:04:26 +0800 Message-ID: <20221230060426.16415-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20221223094259.87373-23-angelogioacchino.delregno@collabora.com> References: <20221223094259.87373-23-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Instead of calling clk_prepare_enable() on a bunch of clocks at probe > time, set the CLK_IS_CRITICAL flag to the same as these are required > to be always on, and this is the right way of achieving that. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Miles Chen