Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
HMM_SOURCE_IP: 10.64.8.41:57830.1668558064
HMM_ATTACHE_NUM: 0000
HMM_SOURCE_TYPE: SMTP
Received: from clientip-123.150.8.42 (unknown [10.64.8.41])
        by 189.cn (HERMES) with SMTP id F070F1001F5;
        Fri, 30 Dec 2022 14:25:34 +0800 (CST)
Received: from  ([123.150.8.42])
        by gateway-153622-dep-79f476db8-8kzc7 with ESMTP id 7796922a98ec4021adcdfb749bb91026 for rostedt@goodmis.org;
        Fri, 30 Dec 2022 14:25:35 CST
X-Transaction-ID: 7796922a98ec4021adcdfb749bb91026
X-Real-From: chensong_2000@189.cn
X-Receive-IP: 123.150.8.42
X-MEDUSA-Status: 0
Sender: chensong_2000@189.cn
From:   Song Chen <chensong_2000@189.cn>
To:     rostedt@goodmis.org, mhiramat@kernel.org, arnd@arndb.de
Cc:     linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        linux-arch@vger.kernel.org, Song Chen <chensong_2000@189.cn>
Subject: [PATCH v5 0/3] reorganize trace_peobe_tmpl.h
Date:   Fri, 30 Dec 2022 14:33:04 +0800
Message-Id: <1672381984-18260-1-git-send-email-chensong_2000@189.cn>
X-Mailer: git-send-email 2.7.4
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,
        FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,SPF_HELO_PASS,SPF_PASS
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

In the first patchset, my intension was to remove trace_probe_tmpl.h,
just keep a unified process_fetch_insn and process_fetch_insn_bottom
in trace_probe.c for all *probes. is_uprobe was the most important
move to approach. If it was not accepted, the whole patchset couldn't
stand.

Then I change my goal to at least no warnings or errors when impelenting
a new feature based on trace probe if it includes trace_probe_tmpl.h by
provideing default behaviors. What's more, it also removes redundant
code in kprobe and eprobe.

---
v2:
1, reorganize patchset.

v3:
1, mark nokprobe_inline for get_event_field.
2, remove warnings reported from kernel test robot.
3, fix errors reported from kernel test robot.

v4:
1, reset changes in v3(2) and v3(3), they are not reasonable fix.
2, fixed errors by adding "#ifdef CONFIG_HAVE_REGS_AND_STACK_ACCESS_API".

v5:
1, move process_fetch_insn to trace_probe_tmpl.h in another patch.

Song Chen (3):
  kernel/trace: Introduce trace_probe_print_args and use it in *probes
  kernel/trace: Provide default impelentations defined in
    trace_probe_tmpl.h
  kernel/trace: extract common part in process_fetch_insn

 kernel/trace/trace_eprobe.c       | 83 ++++---------------------------
 kernel/trace/trace_events_synth.c |  6 +--
 kernel/trace/trace_kprobe.c       | 72 +++------------------------
 kernel/trace/trace_probe.c        | 27 ++++++++++
 kernel/trace/trace_probe.h        |  2 +
 kernel/trace/trace_probe_kernel.h | 30 ++++++++---
 kernel/trace/trace_probe_tmpl.h   | 48 ++++++++----------
 kernel/trace/trace_uprobe.c       | 13 ++---
 8 files changed, 96 insertions(+), 185 deletions(-)

-- 
2.25.1