Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp6964663rwl; Fri, 30 Dec 2022 01:05:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXu6Sl8tJYDXHvWfB8HPxLSueiIPSS2U8CLIIf37KR6LJn1nUT/fdPCMHEmCQhfWF/GbN4Lq X-Received: by 2002:a17:902:dad0:b0:191:3ec0:9166 with SMTP id q16-20020a170902dad000b001913ec09166mr51108750plx.6.1672391145540; Fri, 30 Dec 2022 01:05:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672391145; cv=none; d=google.com; s=arc-20160816; b=KWULFDkz6aBIBndGVKr/zBPm8CxFDFIGf4MKtFC7UNytsNB5wbnLkMGPhvODVp3WtR e/XO7kHH2LqeevQTWU47nyr2cLTY1tCsfzCHVSDDdNJbRVrDsZCUYoBiKYX22Lm+k0gG E7MtQk5rj8SCrW5tZ9IXAiZ2CpDFY/c7Q3sHU7fgjPfwDg9yRMJyRTHLcSo63wgIq8XN tl+tn6mXSTbO4RErKsoevZ2ZRIvcuftEeKc2pEB605yL+MMyR3PyOfP8+1B35oDaT6L5 yqA8SU4hFu1hVk7+D71yr0srdbotP1Kkl5t6DTL+Hhk3FZa7W5wnGkoDoOtHCDfsoyHO 1Klw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=9HkybAdjC40pqk0L1AvXjL22v1hmp35ak9rgDsXiqnc=; b=AJGXqlYfzxRA7Zc/A0DMETuDcf2VhxYFliBHaCwR0xr32SMEI/5l8P7n9MTVOL6B4x gW0OgkEal0LjqE1ATrpTfq7t4MsiV49RBHXJ83H6ifQjcNS2UymkKF/4ng/HVTJ2+NWj NfaSTdVl3NWoBYPnwwrvRk+B3DxrbtN/Lhu0N0ETutKxnrqUh1IN2AQBdfT/E3+OndfC 7YedZPKE7GiFIANQ9UYTBV6SoI2oXZHXAGn4rsPC9DV87PWlnP6Wdbpx5HpFaLMMMj00 sl1hNMxH1CHtWurmxFZuLnsnU2Ey7Lg8u/ZVmzAL19GLqN7rqw+dEt4MSAZa4BzsKJU/ cHiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=moyUQvrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a17090341c700b00186c3afbd25si21492190ple.349.2022.12.30.01.05.37; Fri, 30 Dec 2022 01:05:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=moyUQvrt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234840AbiL3IoO (ORCPT + 64 others); Fri, 30 Dec 2022 03:44:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbiL3IoM (ORCPT ); Fri, 30 Dec 2022 03:44:12 -0500 Received: from forwardcorp1a.mail.yandex.net (forwardcorp1a.mail.yandex.net [178.154.239.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3610E1A040; Fri, 30 Dec 2022 00:44:08 -0800 (PST) Received: from vla5-b2806cb321eb.qloud-c.yandex.net (vla5-b2806cb321eb.qloud-c.yandex.net [IPv6:2a02:6b8:c18:3e0d:0:640:b280:6cb3]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTP id CEB065FD5D; Fri, 30 Dec 2022 11:44:03 +0300 (MSK) Received: from [IPV6:2a02:6b8:b081:b702::1:2] (unknown [2a02:6b8:b081:b702::1:2]) by vla5-b2806cb321eb.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id 2iNnBJ0QXqM1-hpii9JF2; Fri, 30 Dec 2022 11:44:03 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1672389843; bh=9HkybAdjC40pqk0L1AvXjL22v1hmp35ak9rgDsXiqnc=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=moyUQvrtCJavoqdqNpjlgnOYPerhAGlEJzfxu9kmlO72fjeZHujRiUdWSDLCiSkNL rfzEujRryPDC2eebAr1iTn+8u0hukir0Yc36vKuJJCZjNmVMJGuegwVrEVYOueew11 FFCKSsQmsZbBFulfDnoT6WHwJBu/1r6AS5BUGaEk= Authentication-Results: vla5-b2806cb321eb.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.ru Message-ID: Date: Fri, 30 Dec 2022 11:44:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator Content-Language: en-US To: Jakub Kicinski Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Paolo Abeni References: <20221226084353.1914921-1-d-tatianin@yandex-team.ru> <20221229182227.5de48def@kernel.org> From: Daniil Tatianin In-Reply-To: <20221229182227.5de48def@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/30/22 5:22 AM, Jakub Kicinski wrote: > On Mon, 26 Dec 2022 11:43:53 +0300 Daniil Tatianin wrote: >> Otherwise we would dereference a NULL aggregator pointer when calling >> __set_agg_ports_ready on the line below. > > Fixes tag, please? Looks like this code was introduced with the initial git import. Would that still be useful?