Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 30 Dec 2022 13:50:20 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Tudor Ambarus <tudor.ambarus@linaro.org>
Cc:     Arnd Bergmann <arnd@kernel.org>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <pratyush@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Michael Walle <michael@walle.cc>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
        Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
        Boris Brezillon <boris.brezillon@collabora.com>,
        Mauro Lima <mauro.lima@eclypsium.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] mtd: cfi: allow building spi-intel standalone
Message-ID: <20221230135020.485a3efc@xps-13>
In-Reply-To: <32ddf1f8-eda1-da00-a3dc-901c4ee61217@linaro.org>
References: <20221220141352.1486360-1-arnd@kernel.org>
        <cae6328b-5204-a1ab-810d-8fb64e466453@linaro.org>
        <20221220165701.5696df1a@xps-13>
        <026225c6-f17f-e9da-b7c0-5d3473a97e89@linaro.org>
        <32ddf1f8-eda1-da00-a3dc-901c4ee61217@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Tudor,

tudor.ambarus@linaro.org wrote on Mon, 26 Dec 2022 16:22:02 +0200:

> On 21.12.2022 08:49, Tudor Ambarus wrote:
> >=20
> >=20
> > On 20.12.2022 17:57, Miquel Raynal wrote: =20
> >> Hi Tudor,
> >> =20
> >=20
> > Hi,
> >  =20
> >> tudor.ambarus@linaro.org wrote on Tue, 20 Dec 2022 17:44:49 +0200:
> >> =20
> >>> Hi, Arnd,
> >>>
> >>> On 20.12.2022 16:13, Arnd Bergmann wrote: =20
> >>>> From: Arnd Bergmann <arnd@arndb.de>
> >>>>
> >>>> When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver
> >>>> fails to build, as it includes the shared CFI header:
> >>>>
> >>>> include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix >=
>>> selected. No NOR chip support can work. [-Werror=3Dcpp]
> >>>> =C2=A0=C2=A0=C2=A0=C2=A0 62 | #warning No CONFIG_MTD_CFI_Ix selected=
. No NOR chip >>>> support can work.
> >>>>
> >>>> linux/mtd/spi-nor.h does not actually need to include cfi.h, so
> >>>> remove the inclusion here to fix the warning. This uncovers a
> >>>> missing #include in spi-nor/core.c so add that there to
> >>>> prevent a different build issue.
> >>>>
> >>>> Fixes: e23e5a05d1fd ("mtd: spi-nor: intel-spi: Convert to SPI MEM")
> >>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> =20
> >>>
> >>> Looks good to me. I'll let the linux-0day bot run over it and apply it
> >>> once -rc1 is out. =20
> >>
> >> The issue sometimes produces build errors, shall I send it through a
> >> fixes PR instead?
> >> =20
> >=20
> > Yes, that I was thinking about.
> >  =20
>=20
> Seems that I shouldn't push to mtd/fixes, so:
> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>

Oh yes you can, sorry for the misunderstanding, but as I am often alone
to do it, I read your "I will apply" message last time and understood "I
will apply on spi-nor/next".=20

You can update mtd/fixes to -rc1 and push the patch, as long as we keep
each other in sync ;)

Thanks!
Miqu=C3=A8l