Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cf215c60-8019-924f-c4d2-4204bb6a87f3@seco.com>
Date:   Fri, 30 Dec 2022 10:23:49 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH net] net: dpaa2-mac: Get serdes only for backplane links
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Ioana Ciornei <ioana.ciornei@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>
References: <20221227230918.2440351-1-sean.anderson@seco.com>
 <20221229200925.35443196@kernel.org>
Content-Language: en-US
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20221229200925.35443196@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3RZVHZuNFJOdzhPNU9FODE3bWd6YWg1eXRHdGJvRGN0RGNJbm4vWHZ0Mjhh?=
 =?utf-8?B?OEMzYWRKMlBCbU0weWFqSTY1bXVjRDYzSHVTMHA3WS9MdDV0Y3c0ejV0MlpJ?=
 =?utf-8?B?N2NyQlBXdmdRZWwwb3ErVjJGWWwvUUVONGkzUExhOTE0Vjk1ZWsxMHFObFhX?=
 =?utf-8?B?UjV6bDZaNWVOK2hDQXpINUQrYlRVNmZMelZnWGZYZ3ZDSnNBdFp2clNBMjZu?=
 =?utf-8?B?bTMvbnRKZ25Qd012ck1QNGxLQTJBenlaOVAvUnF6ZnVwNkc2QXFwQk9pQi90?=
 =?utf-8?B?dWNBWWhmNk42OFozalM5Wk1WOVBZUTRJdzhMWUw1ZFA3cHkraER4N2lWZnFO?=
 =?utf-8?B?bWhsOEt1R2VDREVERkpEdXhIcHBUbk9NRy9oekxJK2NMbFdKVTlIb3o1NG9h?=
 =?utf-8?B?by9NTU9LWTVvTGt2MzRkVjYwRXdqTjdSYmljNTNXbXpFMmhDL0d2SUpPNW83?=
 =?utf-8?B?VUtZaGhGbGQ4SS9wYXFYKzBlZUtpbEhyWkV6cWlKTzJyU25XdC9vQ090dGhL?=
 =?utf-8?B?N0VuRXZyMng1eGFXbTNPaGJSM2dobUh2VHhxelJiSGd6L1dQNmd4M01leXVZ?=
 =?utf-8?B?TXRwdGU5MzlnMXZJYnVWSWhZSXFZQUdwUWp4VVFZMGhxMmRORG5HblFKZVlH?=
 =?utf-8?B?bU5DaHV5MmZ3c2tFZDNuUUt1SG5HMU5IN2RyM2hQTEhUcnczbmZwSkYzT0FT?=
 =?utf-8?B?MU0yVWgveGhVZ21PUEFtRm9ISmxyb29hdWlWTTdsSEVVNkwwb0xqN2I0UWgw?=
 =?utf-8?B?SStmeW5pS0RmSEpYSklZalFzbFBObXZGamtZT1R1SDVTWWY1dklibE9rZEEz?=
 =?utf-8?B?QUZlc0NucnJrY3ZBblRXM0lRUnNic3dIR2pqU2lnSi9lOUVPZDU0SVczUjVY?=
 =?utf-8?B?ZERMQWdlMGd4LzJCS21aSjUvNzZqNzNyYk8yTVk0TVBUOG1sTHJCekdzZ0NG?=
 =?utf-8?B?THRaL2VNaWpybVVXTXNlbUljZlUzQkRUMy9abTVRcDBDOGQrYUxLckduMWdM?=
 =?utf-8?B?VGFyNm81T2M1eDdTQk81S3BxTXNOUTR1ZEk2cU9XZlo5bDgyTklkN2JXaFpI?=
 =?utf-8?B?cmpPeEI0MC9VczBsSEdWSG54ZVRib1NhWUM0aldHSzN3K09vcHN6b1pVWFcz?=
 =?utf-8?B?VTNlelE2YnVPUUEwd3FRK1NoM08ydmlnWjhITWVGWnBqR2wvd2RtRDdmRTRU?=
 =?utf-8?B?MUJpdVJYVWdVSTFsczNubVhKYWg2NmRmOEgxaUVFYTI1VFpJeXZNL0JDZkc4?=
 =?utf-8?B?TGEzZTlQY2s1K3hYMU5LQzJOaUN5MzJFZ3Qzay9QUk0vczlpZlZXTEoyRmZK?=
 =?utf-8?B?NTVIc2FVODk5UkNoN3oxNkpkOUlWK1FkYXIyRXRGUndsU2NyUUJWcVY1bmxO?=
 =?utf-8?B?SWhWbkJWZXFsNmVxMUk0cGl3UWNVR1BKWEwyS0hPNTlBc1Y4R1RucjdSYmZR?=
 =?utf-8?B?WjR0enFqRFlsNlV5N2FPT3g5dWR4UTNnSE5WZEY2Q1ZCREg0UE5nSFI3R3gy?=
 =?utf-8?B?VXlIQi8rbHd4Rm5meWY1cnZWaC9RdzN3eXM0ZzNaM05sUWpMUXYyMFUzNE8r?=
 =?utf-8?B?d1FELzU0T1I1ZUVleDBSZzJUOVNiZGV3eG5wVFF1dktINHNvenB0SVBGTk9V?=
 =?utf-8?B?L3hmNTRmSXBjVVcyeGFtUWQyNzltS1RMV3ROR1VkL0FvQlNadnFDaU90ZklJ?=
 =?utf-8?B?eGRlRkFSMEZ2ZXpobFVJSEMvZ1N3ckdNS3BEanZJNldFSFZLRURCSXZOWjVR?=
 =?utf-8?B?YWJZRGFrbWZqcVhBYmhPRjl4NHAvaCsxakxJWmVpcXdNazVDQmpXeWxVcmQ3?=
 =?utf-8?B?U0xzSGl6T1RWTmJUMUxZSzQ1MVR1WUJXUkRUbDAvUER6VGpyN2t5UXYwNmVl?=
 =?utf-8?B?WHpqeFhJVUNIUDlIaCtqR2YrL0IrQldzenFYLzdmTHBWM2hvRWhOS3BGRmh5?=
 =?utf-8?B?WkhORVFsTjMxVDBneFE2d0lLMmdLM3NOeEUzVjVZUWRzUDBWeW45RWV5eFVK?=
 =?utf-8?B?QjlQTGFTY0RUNElyUWR4anlEZnZBb2JjMXYvTnNQdW1KNkx0TG1qODdzdStl?=
 =?utf-8?B?aE1FZ2NTWWNUUkRHZUtUOUs2RDVLTmoySWt2OXF4TVhKSVFiVE4rcmZ3bzN4?=
 =?utf-8?B?TjhRWmVyelMwRmx0Yjlwc3pjbHZvS3VEcnlEa1dieUVJWmlQS1gyTVJaRjA3?=
 =?utf-8?B?Znc9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed133c9b-446b-4234-7bb7-08daea79de0c
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Dec 2022 15:23:56.6148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VcdWnl1EgNU7cgOWArWiXQwYZLzRYc6g1TUDNcHFzLpDhanqUlsvHmEs1KsZK5mH8CNVoKWiE0yOHEIZsNjftA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR03MB8308
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/29/22 23:09, Jakub Kicinski wrote:
> On Tue, 27 Dec 2022 18:09:18 -0500 Sean Anderson wrote:
>> +	if (!(mac->features & !DPAA2_MAC_FEATURE_PROTOCOL_CHANGE) ||
> 
> This line is odd as sparse points out

Ah, you're right.

--Sean