Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221223142419.3781410-1-ammar.faizi@intel.com> <20221223142419.3781410-2-ammar.faizi@intel.com>
In-Reply-To: <20221223142419.3781410-2-ammar.faizi@intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 30 Dec 2022 19:13:35 +0100
Message-ID: <CAJZ5v0j1nB9W=uNHKhqLHovTgAq_5ZYkzp6z==AspY4Dfp3PxA@mail.gmail.com>
Subject: Re: [PATCH v1 1/2] ACPI: Silence missing prototype warnings
To:     Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc:     Robert Moore <robert.moore@intel.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Linux ACPI Mailing List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ACPICA Mailing List <devel@acpica.org>,
        LLVM Mailing List <llvm@lists.linux.dev>,
        "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 23, 2022 at 3:25 PM Ammar Faizi <ammarfaizi2@gnuweeb.org> wrote:
>
> From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
>
> Compiling with clang-16:
>
>   drivers/acpi/acpi_lpit.c:142:6: error: no previous prototype \
>   for function 'acpi_init_lpit' [-Werror,-Wmissing-prototypes]
>
>   drivers/acpi/ioapic.c:212:6: error: no previous prototype \
>   for function 'pci_ioapic_remove' [-Werror,-Wmissing-prototypes]
>
>   drivers/acpi/ioapic.c:229:5: error: no previous prototype \
>   for function 'acpi_ioapic_remove' [-Werror,-Wmissing-prototypes]
>
> Include "internal.h" to silence them.
>
> Cc: LLVM Mailing List <llvm@lists.linux.dev>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
> ---
>  drivers/acpi/acpi_lpit.c | 1 +
>  drivers/acpi/ioapic.c    | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c
> index 50540d4d4948..3843d2576d3f 100644
> --- a/drivers/acpi/acpi_lpit.c
> +++ b/drivers/acpi/acpi_lpit.c
> @@ -10,6 +10,7 @@
>  #include <linux/acpi.h>
>  #include <asm/msr.h>
>  #include <asm/tsc.h>
> +#include "internal.h"
>
>  struct lpit_residency_info {
>         struct acpi_generic_address gaddr;
> diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c
> index a690c7b18623..6677955b4a8e 100644
> --- a/drivers/acpi/ioapic.c
> +++ b/drivers/acpi/ioapic.c
> @@ -24,6 +24,7 @@
>  #include <linux/acpi.h>
>  #include <linux/pci.h>
>  #include <acpi/acpi.h>
> +#include "internal.h"
>
>  struct acpi_pci_ioapic {
>         acpi_handle     root_handle;
> --

Applied as 6.3 material, thanks!