Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8063360rwl; Fri, 30 Dec 2022 21:43:57 -0800 (PST) X-Google-Smtp-Source: AMrXdXs+pMoodhYtayK1uLJvlspV7qvg5FoQoTfF8I9DMB1Lf0n9+SAqcbOLK0I+rOFMS5RbNY3y X-Received: by 2002:a17:907:c786:b0:7ad:a797:5bb9 with SMTP id tz6-20020a170907c78600b007ada7975bb9mr42902193ejc.29.1672465437531; Fri, 30 Dec 2022 21:43:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672465437; cv=none; d=google.com; s=arc-20160816; b=zmm9VuRetLtzGZaio+111/el58fcbkJ+JkP+u3SYNQ5LeNUueRtcEApQfl7n64vA+H OFWE6cA/kyuRoyR09kLUW+obMaAHjrbirs3w2/WSKbBhqknK9NwdKrLQ3Lut41OCOPoH mznt0Yw1SLrPClAOgFc25XqCnQ9WLG2m4jr6L7nmA8q6tmFgU5r0vhYhibcI9iYTeOuq RM/M90zqE2kbTp+3xt2XoZcJG+ahMqbo89rNBC93LDECr/UcIJ+XmrFHSV/CDau8u+wk JfPrDN19tLMs3EZrAwzIGxyLaXFJPXhQ6ozsADIhfXgm23JHGtsTnaMkfiIeJq9C7SQk oF2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=U6FVhZWgge6NJbivU00i1A5fKqM6hiSuRrcLPf6bSqc=; b=t9Xc24VhZUQpcie93GTafWhLyeC9TczDvXz0xuOiKdjr5gm7cUihs1YIeCFsC2IHd5 hQUEFtQrHAieS3TX6gUIszTQlgl0kSI7aHupSEN05KT4qKb2/PhyYZuEH3WwXA8gi0wS pfSyijv8AKeGLEzFkoHJIcN3AInvIvFQqxnzwHZZo0+6ohbQutJs0I/MUYv91M6VhWQT uipzFSEdNrAUsr4o+Od043L8f+RbXMbwIiyKN34AGW6gb5I200/BPZnKFiCn882zJfLk mAx5EtcbmqExvwHtX40SGOuR7SPqvG42qjEBaxLQRbwDXRFoyJwpZBbB3aCy+WUNLn2l Sqaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kDaob7R5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs40-20020a1709072d2800b007b7eb087819si21415466ejc.200.2022.12.30.21.43.43; Fri, 30 Dec 2022 21:43:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kDaob7R5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbiLaDzg (ORCPT + 62 others); Fri, 30 Dec 2022 22:55:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiLaDzd (ORCPT ); Fri, 30 Dec 2022 22:55:33 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D864BC9C; Fri, 30 Dec 2022 19:55:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8D7AB8162C; Sat, 31 Dec 2022 03:55:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CA4CC433EF; Sat, 31 Dec 2022 03:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672458930; bh=Pa1PYVoJoUZNt9IVRLhwAsdHtIKR1d2rvQTtv41uneE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kDaob7R5MJIEm/6MMBRzNcLBeopos02AnaOOY1AWl962V0JH7bjoW5uf6RczVV6JF u3DN1BbnGpyUeZheC2ziW18NyKTDDusOKI5tzMABqIwh6lejwdAFTIXHuYxhE4g+8F iJ/+FBmG7R7X8jx2nRjVAm0DYIS+0a13/6uIX8+ANCMRyKEBh3TFbioAJFYCMlvaNJ vCWovn3uEOOkAIOM+7CRwzK/2o1AcR9jrTcBabcRL70VNMvWqmRuMzR5igRj2jbHBt Eo8iOwnQ8I+aP23yuIJnDqVBrTB2gTFIMvTVl83xh8F6+j0Ov/sJPKK5A/Ma1D3818 E0xHg6pZpV7dA== Date: Fri, 30 Dec 2022 19:55:29 -0800 From: Jakub Kicinski To: Daniil Tatianin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [RESEND PATCH net v1] drivers/net/bonding/bond_3ad: return when there's no aggregator Message-ID: <20221230195529.67a5266a@kernel.org> In-Reply-To: References: <20221226084353.1914921-1-d-tatianin@yandex-team.ru> <20221229182227.5de48def@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Dec 2022 11:44:02 +0300 Daniil Tatianin wrote: > On 12/30/22 5:22 AM, Jakub Kicinski wrote: > > On Mon, 26 Dec 2022 11:43:53 +0300 Daniil Tatianin wrote: > >> Otherwise we would dereference a NULL aggregator pointer when calling > >> __set_agg_ports_ready on the line below. > > > > Fixes tag, please? > Looks like this code was introduced with the initial git import. > Would that still be useful? yessir, the point is to let backporters know how far the bug goes. The initial import is our local equivalent of infinity, for all practical purposes.