Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8223429rwl; Sat, 31 Dec 2022 01:50:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXs4A1DknyB81nIs/C/uco71b2NbvkU0fFugmBa8MRxmHK4z2xBIXWr9LrMP2KKf78+bVMpT X-Received: by 2002:a62:87c1:0:b0:581:5dba:ac with SMTP id i184-20020a6287c1000000b005815dba00acmr16367921pfe.15.1672480250765; Sat, 31 Dec 2022 01:50:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672480250; cv=none; d=google.com; s=arc-20160816; b=hI8PRwBhy3/cD5u5Bj9RWhSkLOxONfaD/aNV6ARXXGQs5fMgUrrtSxA6q9MsafScwa ayeyyMMw13MP8Z42r8NJ1szx5TXFsmBrrFNyhCYwdMzgqUvvEdVX45cPGmxYlBRm92pK 65HG68gt0u4FM76KMPRlQo/aXr6rvb3lhgJB+btcd6LElHNFXiD583VAz63APu1v+Wzy vt6roAJCurdigGaWeXcCURxzlCTQ55s4zomwWBE9iaiZeoE0FLMUYVw4uv8bgWk1a3Xj f2D4NFf+8Ys/xkcH7G11yzmb7Nq7z979vtBqwX2sCSTUE+R1u3F6wd6qVXMEjiBqIau3 JgSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wereH6LHdBUC9kDDyzTdxHdgO+FIsA0w3UKr8l/p+2c=; b=DCmSwoDOLdGGILtWHHaNP8/vWZ8BfT97QBOEwofqrPR3QdypFuRbPFdABEO1H6VZdG lXtdcs9AED1AuoYXQB5efVIQb37rt693H5ffTSXjwjj9CuOVkeiUU7rPi2mPgXJjpRG9 3z6CA1j8P709JShXE4IKfpn4EuHCLbZQZQstpOp7pkj4nIcPECJfyZzpyxFujuUkr/Ft bBJkCpH9MJHKL4U6O8WoQ+A+JETpuGRH9O4c6MI0Tq5K3HusH9fbOeNGha50w5e8ZbNP ZwO8jmZEmqp0Cmw+iz7/Z6lvGxyd+CBMKWq1hUza+DHC8XdY9lvoIS1ZnljStMofmFzx ygOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=oBEx9t+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a22-20020a056a000c9600b005614fb190e4si24876569pfv.193.2022.12.31.01.50.42; Sat, 31 Dec 2022 01:50:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=oBEx9t+2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbiLaJs1 (ORCPT + 62 others); Sat, 31 Dec 2022 04:48:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229536AbiLaJsX (ORCPT ); Sat, 31 Dec 2022 04:48:23 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7176D2D7 for ; Sat, 31 Dec 2022 01:48:22 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 49A6B1EC04AD; Sat, 31 Dec 2022 10:48:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672480101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wereH6LHdBUC9kDDyzTdxHdgO+FIsA0w3UKr8l/p+2c=; b=oBEx9t+2nMWbl4wOSjExVFfM8W6KgpgcubJTWInjr+IwcCqV0JFuv7XEmHZwb+Lga+3sSX RUvReFUOumoCd7uYviKZSfbIav6sfuiqwrsCg1XUgbcgUs1Zu6em0bOqDl+VF/Xi7tfn2G w6FADtP1YWCeqYvWQCi+EkKrVXqJjPY= Date: Sat, 31 Dec 2022 10:48:16 +0100 From: Borislav Petkov To: "Jason A. Donenfeld" Cc: "H. Peter Anvin" , pbonzini@redhat.com, ebiggers@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, ardb@kernel.org, kraxel@redhat.com, philmd@linaro.org Subject: Re: [PATCH qemu] x86: don't let decompressed kernel image clobber setup_data Message-ID: References: <20221228143831.396245-1-Jason@zx2c4.com> <6cab26b5-06ae-468d-ac79-ecdecb86ef07@linaro.org> <9188EEE9-2759-4389-B39E-0FEBBA3FA57D@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 30, 2022 at 04:59:30PM +0100, Jason A. Donenfeld wrote: > I'll attach a .config file. Apply the patch at the top of this thread to > qemu, Hmm, so the patch at the top of this thread is fixing the clobbering of setup_data. But I tried latest qemu with your .config and it boots ok here. So how do I repro the original issue you're trying to fix? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette