Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6a199e03-267d-9924-9926-22a4175596ff@gmail.com>
Date:   Sat, 31 Dec 2022 11:08:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 00/20] staging: r8188eu: some xmit cleanups
Content-Language: en-US
To:     Martin Kaiser <martin@kaiser.cx>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Michael Straube <straube.linux@gmail.com>,
        Pavel Skripkin <paskripkin@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20221230180646.91008-1-martin@kaiser.cx>
From:   Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <20221230180646.91008-1-martin@kaiser.cx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/30/22 19:06, Martin Kaiser wrote:
> Start cleaning up the code that transmits data frames to the dongle
> via USB.
> 
> This should be applied on top of the "merge public action functions"
> series.
> 
> Martin Kaiser (20):
>    staging: r8188eu: make xmitframe_swencrypt a void function
>    staging: r8188eu: remove some unused CAM defines
>    staging: r8188eu: cmd_seq is write-only
>    staging: r8188eu: return immediately if we're not meant to encrypt
>    staging: r8188eu: remove unused parameter
>    staging: r8188eu: simplify rtl8188eu_xmit_tasklet
>    staging: r8188eu: remove rtl8188eu_init_xmit_priv
>    staging: r8188eu: remove duplicate psta check
>    staging: r8188eu: simplify frame type check
>    staging: r8188eu: simplify rtw_make_wlanhdr's error handling
>    staging: r8188eu: clean up qos_option setting
>    staging: r8188eu: remove unused bpending array
>    staging: r8188eu: remove unused dma_transfer_addr
>    staging: r8188eu: bm_pending is not used
>    staging: r8188eu: terminate_xmitthread_sema is not used
>    staging: r8188eu: tx_retevt semaphore is not used
>    staging: r8188eu: remove unnecessary rtw_free_xmitframe call
>    staging: r8188eu: phwxmit parameter is unused
>    staging: r8188eu: rtw_init_hwxmits is not needed
>    staging: r8188eu: we use a constant number of hw_xmit entries
> 
>   drivers/staging/r8188eu/core/rtw_cmd.c        |   4 -
>   drivers/staging/r8188eu/core/rtw_xmit.c       | 239 ++++++++----------
>   drivers/staging/r8188eu/hal/rtl8188eu_xmit.c  |  27 +-
>   drivers/staging/r8188eu/hal/usb_ops_linux.c   |  14 +-
>   .../staging/r8188eu/include/rtl8188e_spec.h   |  21 --
>   .../staging/r8188eu/include/rtl8188e_xmit.h   |   4 +-
>   drivers/staging/r8188eu/include/rtw_cmd.h     |   1 -
>   drivers/staging/r8188eu/include/rtw_xmit.h    |   9 +-
>   8 files changed, 116 insertions(+), 203 deletions(-)
> 
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150