Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8254318rwl; Sat, 31 Dec 2022 02:36:41 -0800 (PST) X-Google-Smtp-Source: AMrXdXv14YGZj5eBrshRqSh+e73yQQSfD9umi9qB3BqQHQwq+v2U/H5XCMP8kwxbndBrojeh5Xvb X-Received: by 2002:a17:907:1ca5:b0:7c0:edc9:9a6b with SMTP id nb37-20020a1709071ca500b007c0edc99a6bmr37705000ejc.41.1672483001678; Sat, 31 Dec 2022 02:36:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672483001; cv=none; d=google.com; s=arc-20160816; b=zfeobBEHILNRjaHo+/8dBPbk3dCkA7syA9GK0BRquRddl1kGpTUoeUqzSxBofJMQ3t 3Ol+Ssd8X+fLQcGHwDAi9vhM0sejUPk6qW6mBTjxkpouVGZoJiK82Y2W7jrzbNXbLxES VjAR1oc5cQNUt5bBIKFNkmyEcFUlOz7TlHdqYUahlyy+De4LzSnvJ2UVLcqOgVZ4Verl Vpt6u16ncH3ymr1xe+xJA/XAYiXhN32cVh9wN7yLO7gdhCttXM2qgR/0EAyYunBdDAs1 tGBX5XHVjypAlv40XyxjOgI+PCdI/oOEojYB9tD1g2JKyj8Y3JyVouacLhVWNAVKGQWA Lyow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9MuqDRhnKpKyPNJqiCzwVRQjhe4OOWQQi+bkhzu+NfM=; b=DtUvnPB+7F/8276v9sc/ykqPlWyY0TynU6wc3WswoaU+wJaIwe5sbzVYlEq+qTzsSv Kv2bWU1AbvSDJU2CIQiGTlKcZF1N5jWk2TRcabwV07hxmw2qVZnGLyi5t6I8O0MfpSa+ +92xSnRaNllI/qaflVbaqItTQYDJH2NI0xurCTcmnV/g6W90Vbtm3hXNGYa3EBQ+evcD xov0yvHkUwuZuPEkSLeVeT636v3WaiOg/qOZ+KFawtPqLcM5Icv1R6aa+r5/fMlC9+db pKWWItNnkb7fpFhgXK9BszW5Dt6HR4rVf+vGWBhVSBTxC1XSVWb1961m7g/9UKeia9tC yagA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w00PN8za; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm20-20020a170907949400b007c171bf2316si20324466ejc.634.2022.12.31.02.36.26; Sat, 31 Dec 2022 02:36:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=w00PN8za; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231174AbiLaJ61 (ORCPT + 63 others); Sat, 31 Dec 2022 04:58:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiLaJ6Z (ORCPT ); Sat, 31 Dec 2022 04:58:25 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B996AE0C2 for ; Sat, 31 Dec 2022 01:58:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ECC060A71 for ; Sat, 31 Dec 2022 09:58:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EF1BC433EF; Sat, 31 Dec 2022 09:58:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672480703; bh=c3GP3BWw7hX/GbErfIHklPnihWYlOThTtcWXdppJMrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=w00PN8zabbL96idkE4Q0S0LZRbk34evycGwnbddiNEIeIiaLisuMR1VePQK85hHCb hZrNqcO4MwYGDZ9rOJ5octTgDPwXczyB5GBoNgAq8eDj+SiAv9yaOkYxjVKhelqM+c 3d9WH8MqkJCppwjPnjdy8jZ23MdmtEZq3nAd3+3E= Date: Sat, 31 Dec 2022 10:58:21 +0100 From: Greg KH To: Yoochan Lee Cc: matt.hsiao@hpe.com, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] misc: hpilo: Fix use-after-free in ilo_open Message-ID: References: <20221231055310.2040648-1-yoochan1026@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221231055310.2040648-1-yoochan1026@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 31, 2022 at 02:53:10PM +0900, Yoochan Lee wrote: > --- a/drivers/misc/hpilo.h > +++ b/drivers/misc/hpilo.h > @@ -62,6 +62,7 @@ struct ilo_hwinfo { > spinlock_t fifo_lock; > > struct cdev cdev; > + struct kref refcnt; This is obviously incorrect, please never have 2 reference counts for the same structure. greg k-h