Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8469480rwl; Sat, 31 Dec 2022 06:21:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXsraizIrWnr4p8K36B22NPTrExT1rVtHYdMTZzuKkE/oDnywP8G4Y0mkY7BWX+yp9DsPidU X-Received: by 2002:a17:907:d48a:b0:7c1:766e:e09 with SMTP id vj10-20020a170907d48a00b007c1766e0e09mr30014237ejc.29.1672496496653; Sat, 31 Dec 2022 06:21:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672496496; cv=none; d=google.com; s=arc-20160816; b=AH39fqW1aUEnXUF4dRFjtqqxshzb79bQS24xht4ZxGVtgFHkqCoLHLxXJvRHLt/jTl wEh+J+c7qg/N0WJ6Vsr2lznOp6ae4PT7RsjlPO67LlyxDv2NRX0/uE0WXNM7NIuB/4HH dhzCNhBHYcX1HbIYWTIDmqvIUu8P1D/I7mu+zgFTXv/dC3kcc+7wuxblPKccA9ZMCP5b zpeCShRFbUytpevqoNHE/Kg4Kd9eEYRSmaV9ySDoqqFk+7ZYW/4xcRkuCeSm05nJ4mlO BALrcLxUKKkf2tZlz5nNhdkEU8LlvSL/r1rLSCEnotDnHBoh6Lz/AyQD/WJZ7A8MI8dc epuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1swn0xwgNdguNiw43DhjJqxNtHVgXYZnUSm8WOToSuo=; b=S+zpWjS37WhhO+Vydvw+Y5IhebO7fZQ8lxgl293OQNXR2xXVR4Fq1GI690pTMiIF6w K7Pzb9YvGgOtLDaJb8/d5mWpgn78bt+eTZE5Zjlb6XjijnXioGR52AnWzXY5jsEpKgiq tJEPHwTvIF08ZGzU8YBFO7n+HnWqMHIQ9Ihb4kfRTtm/RCGi2Z+Cr8PCqefe3DeOcLsl u+WrDZYgZZuVNk7HbkrZIX5ZDESqO3O7Bwl2tRcj1S3O4Z326U31j8BY8NudpRjyUTma kPE8NFitsWPnKWin/frFaMZm1lFagb2gLy7zBfm7WbGa4auw/ty9vwN9kI7p01IEo9pP So1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="LzKR1o/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne26-20020a1709077b9a00b0084c4e8e10fbsi16129390ejc.51.2022.12.31.06.21.21; Sat, 31 Dec 2022 06:21:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b="LzKR1o/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232021AbiLaNvh (ORCPT + 62 others); Sat, 31 Dec 2022 08:51:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231693AbiLaNvf (ORCPT ); Sat, 31 Dec 2022 08:51:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27C886383 for ; Sat, 31 Dec 2022 05:51:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8D3F60BEA for ; Sat, 31 Dec 2022 13:51:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2421C433D2; Sat, 31 Dec 2022 13:51:32 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="LzKR1o/L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1672494691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1swn0xwgNdguNiw43DhjJqxNtHVgXYZnUSm8WOToSuo=; b=LzKR1o/LkAdiF6MQnQZuxpn3T6rBbriro7O0n1mUAFSbF1qGtnNS9Lhps0XwRRb9kbrE6p o4AtXcOZBddrfITpfFJbpsKVnugNBebeusahm34sX3p04dwhC+MLbHshQ/KtFResg+FE4n sb7Ri73QTrtccYqxb0OAQbjzv2kVUxs= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 7f4aebf1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 31 Dec 2022 13:51:30 +0000 (UTC) Date: Sat, 31 Dec 2022 14:51:28 +0100 From: "Jason A. Donenfeld" To: Borislav Petkov Cc: "H. Peter Anvin" , pbonzini@redhat.com, ebiggers@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, ardb@kernel.org, kraxel@redhat.com, philmd@linaro.org Subject: Re: [PATCH qemu] x86: don't let decompressed kernel image clobber setup_data Message-ID: References: <46466e54-25c3-3194-8546-a57cd4a80d9d@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 31, 2022 at 02:48:12PM +0100, Borislav Petkov wrote: > On Sat, Dec 31, 2022 at 02:44:08PM +0100, Jason A. Donenfeld wrote: > > Are you using patch v1 minus the 62 MiB thing? > > No, I want to see the original failure - the one that prompted you to send > > https://lore.kernel.org/r/20221228143831.396245-1-Jason@zx2c4.com That failure is unrelated to the ident mapping issue Peter and I discussed. The original failure is described in the commit message: decompression clobbers the data, so sd->next points to garbage.