Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8545988rwl; Sat, 31 Dec 2022 07:34:44 -0800 (PST) X-Google-Smtp-Source: AMrXdXtNbPaGRqiz3uhKafc3xXOluG2s44oh3VROtWFBw9wOKVB1FLwj1XM8bdcxIUHZRu6Y8mcw X-Received: by 2002:a05:6a20:1e4b:b0:af:8ff3:fc7b with SMTP id cy11-20020a056a201e4b00b000af8ff3fc7bmr39061380pzb.25.1672500884543; Sat, 31 Dec 2022 07:34:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672500884; cv=none; d=google.com; s=arc-20160816; b=B415i5638IYXNn2+YicGdQpDPtHdP+G8yU7zT0NBjGapkHKRQ77BRlN4QPPrPKIfPT JMwYqBiQOptC3gP78A5Y++9IiD1gH7REoIPUkVxhSqgoWk3fnG570T7+uiZ5dqM7zdN4 vAT8/gFd9U+JDrColgGYvAu80PhJCvJys/hPxma502Vd97w37tHF6y3kzIQJztCB/Cxw oV4siEO6KyMcHvK2txnILZV8hAfUJ3a0MceGNwCF/cK7QKzceBRJQ1fkJOcP3TWWZwnV Ht44lkgDFp5aWkPIRO4b+tkvdeZj6ItGaMS1vGb8TC9min9t4BOJIB427enHki6xPF9R 3Gkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=z1dUhnKe7gxJ0QUpJzxtakKCkxVA8FGz20WPR9Jz1/A=; b=ua9xz/SllVYit+MRZmBu3AMKlBRAl5SKXP0an8fukprlfHTQRHqVj3CjTuOZdzpFaM PlnW/J9NC6HrwU8nJZ95mc7AFpLhcjZLcKd7RDuGfmwmjUrtGJJsUgKBC+Qh576ZTtwr fhBkLcgN7Rm/KPpf3AnmLVjU202IP87a4qIIIW2Y2udAea/sESg/soh11aSYszCjO/TJ rFRuwpQaIKqLCMJzWHrgVVBMFQITnqurJRZNuMmcoQq+JSJ+kn9c1RGFrvLB0TwIoRqW FQa2wrVb8ZbLA963Jalxsamlz2R1Q6LUP4ckpOJYxRgI5hlVOgSaVhmNW0an/XHvhPdI 21Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Pfsdy4ke; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 64-20020a630443000000b0049b37046fb9si13102133pge.243.2022.12.31.07.34.36; Sat, 31 Dec 2022 07:34:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Pfsdy4ke; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231862AbiLaPPX (ORCPT + 62 others); Sat, 31 Dec 2022 10:15:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229842AbiLaPPT (ORCPT ); Sat, 31 Dec 2022 10:15:19 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C924C310; Sat, 31 Dec 2022 07:15:18 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id a30so496320pfr.6; Sat, 31 Dec 2022 07:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=z1dUhnKe7gxJ0QUpJzxtakKCkxVA8FGz20WPR9Jz1/A=; b=Pfsdy4keTpSvVmVxuLNg3r5OP9eykOkfltTBMdPNeiWVWNbSgdh68ebjMbbkbmA3rS Ym56ZntslJpWn+omQpg3lnWStnO5L6Kept6rCqyNP0RtfHjAaF+0P2quWeZtMziPkltA sBvlfEeFyhI+4B09Ht1iLsYQ4veFIxPYk/7t7uItzCgMT3HFc/WQIA7VT0TAYNDkkJGv VgqZGiUpSZCa9g7Lk+o1V7Ar8v1rjyT5fk+jtMbTy75ufNZRKl0u/tCl/9SPbL+7mrWO SaCpkuMSmEKk9l8pXvt8kA5tjWPnp5Z/0AyPvkKNUXckJJq9si3owYvJ9FiM28AK795x mYeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z1dUhnKe7gxJ0QUpJzxtakKCkxVA8FGz20WPR9Jz1/A=; b=j8Efpbm2WzfH4nCGfh2Li+aLew9v4XSjfLP3YhHRHS7PWyyypZu/gsZemrM95jZ3gb Dn0zDbhuyFEfBWiN1S3gKMRtD/mSMIIa2syrdap9mP9a85mpzDh/Eoo5gU4rL2DvnqqH R/qQwNgBcAH6uE0k7wQdbshR/0fAcLAezl0d+zaAmzC+m4qY3c6QIr8CytgHi3SPR45c 1DFPjih3vRZkOFxBtmHAa3i15Saf/tIrRYWrSCaulWCBwIXcShOZCVz5paCnksENXCGe JMIYPnfssjmbii0tsHcwtXXxzBjinRJCzFqNPstQjLEgUjS63hPqjMy2sJhBxLbOLl8h h/dA== X-Gm-Message-State: AFqh2ko8amsH4ybileQqVLA5KqQ3S3RsBioX3m6+CIQeKuFpxm8ayjAn 6RrCimd+C1/kdvreGhLZ0Gk= X-Received: by 2002:aa7:9284:0:b0:581:6069:5c00 with SMTP id j4-20020aa79284000000b0058160695c00mr17152838pfa.28.1672499718315; Sat, 31 Dec 2022 07:15:18 -0800 (PST) Received: from WRT-WX9.. ([103.135.103.220]) by smtp.gmail.com with ESMTPSA id a8-20020aa78e88000000b005765a5ff1fasm385992pfr.213.2022.12.31.07.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Dec 2022 07:15:17 -0800 (PST) From: Changbin Du To: Andrii Nakryiko , Alexei Starovoitov , Daniel Borkmann Cc: Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Changbin Du , Leo Yan , Andrii Nakryiko Subject: [PATCH] libbpf: Return -ENODATA for missing btf section Date: Sat, 31 Dec 2022 23:14:36 +0800 Message-Id: <20221231151436.6541-1-changbin.du@gmail.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As discussed before, return -ENODATA (No data available) would be more meaningful than ENOENT (No such file or directory). Suggested-by: Leo Yan Cc: Andrii Nakryiko Signed-off-by: Changbin Du --- tools/lib/bpf/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c index dd2badf1a54e..2c89454c0136 100644 --- a/tools/lib/bpf/btf.c +++ b/tools/lib/bpf/btf.c @@ -991,7 +991,7 @@ static struct btf *btf_parse_elf(const char *path, struct btf *base_btf, if (!btf_data) { pr_warn("failed to find '%s' ELF section in %s\n", BTF_ELF_SEC, path); - err = -ENOENT; + err = -ENODATA; goto done; } btf = btf_new(btf_data->d_buf, btf_data->d_size, base_btf); -- 2.37.2