Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221230163512.23736-1-dmitrii.bundin.a@gmail.com> <20221230133726.4c2e7e148a8a6627cd621e0f@linux-foundation.org>
In-Reply-To: <20221230133726.4c2e7e148a8a6627cd621e0f@linux-foundation.org>
From:   Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Date:   Sat, 31 Dec 2022 20:26:17 +0300
Message-ID: <CANXV_XwqgEZ5qhP-A1YNOuP7wri5Ax=1yj1CV2BwOFQMyr+hBQ@mail.gmail.com>
Subject: Re: [PATCH] scripts/gdb: add mm introspection utils
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     jan.kiszka@siemens.com, kbingham@kernel.org,
        gregkh@linuxfoundation.org, mingo@redhat.com, x86@kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz,
        Mike Rapoport <rppt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Dec 31, 2022 at 12:37 AM Andrew Morton
<akpm@linux-foundation.org> wrote:
> Should it have a check that it's being run on the supported
> architecture?

The x86 code is under the if utils.is_target_arch("x86") ... else
gdb.GdbError("Virtual address translation is not supported for this
arch") check so for now it will be an error to use this command for
other archs. In the patch v2 I mentioned x86 explicitly in the commit
message and also addressed issues Mike pointed out. Could you please
apply https://lore.kernel.org/all/20221231171258.7907-1-dmitrii.bundin.a@gmail.com/
in place of v1?